Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0030082Openbravo ERPZ. Otherspublic2015-06-03 13:452016-02-02 09:35
jorge-garcia 
jorge-garcia 
urgentmajoralways
closedfixed 
5
 
3.0PR15Q3 
vmromanos
Advanced Payables and Receivables Mngmt
Production - Confirmed Stable
2014-07-18
3.0PR14Q3
https://code.openbravo.com/erp/devel/pi/diff/87765308f9bd/modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_GEN_PAYMENTSCHEDULE_INV.xml [^]
No
0030082: Payment plan is updating wrong in some circunstancies
Payment plan is updating wrong if Payment Method is set as Automatic Receipt and a sales order is partially paid.
As group admin role:
   Create a new Payment Method and set Automatic Receipt = 'Y'
   Add it to a financial account.
   Create a Sales Order, set the previously created payment method and Invoice Terms = Immediate.
   Click on Add Payment an create a partial payment for the Sales Order.
   Create a Sales Invoice from it and complete it
   Check the Received field of the Payment Plan of the invoice has been updated with the sum of the full payment and the partial payment of the order and the Outstanding amount is wrong as well.
  Check the payment details of the payment plan from both (order and invoice) are created correctly
No tags attached.
depends on backport 00301213.0PR15Q2.2 closed jorge-garcia Payment plan is updating wrong in some circunstancies 
depends on backport 00301223.0PR15Q1.5 closed jorge-garcia Payment plan is updating wrong in some circunstancies 
caused by feature request 0025696 closed Sandrahuguet Add invoice paid status control funcionality 
related to defect 00299723.0PR15Q3 closed jorge-garcia Outstanding amount of sales order payment plan is not updated when payment method is set as automatic receipt 
related to defect 0033500 closed AtulOpenbravo Wrong payment schedule details when return to vendor document is invoiced using credit a memo invoice 
blocks defect 0030007 closed aferraz Payment schedule amount incorrectly calculated when adding a payment from reconcile window to a sales order 
blocks defect 00301703.0PR15Q3 closed aferraz Generic UpdatePaymentPlan module script 
Issue History
2015-06-03 13:45jorge-garciaNew Issue
2015-06-03 13:45jorge-garciaAssigned To => Triage Finance
2015-06-03 13:45jorge-garciaModules => Advanced Payables and Receivables Mngmt
2015-06-03 13:45jorge-garciaTriggers an Emergency Pack => No
2015-06-03 16:36jorge-garciaRelationship addedrelated to 0029972
2015-06-04 12:53jorge-garciaNote Added: 0078060
2015-06-04 12:53jorge-garciaNote Edited: 0078060bug_revision_view_page.php?bugnote_id=0078060#r8750
2015-06-04 12:54jorge-garciaAssigned ToTriage Finance => jorge-garcia
2015-06-04 12:54jorge-garciaStatusnew => acknowledged
2015-06-08 10:56jorge-garciaRegression level => Production - Confirmed Stable
2015-06-08 10:56jorge-garciaRegression date => 2014-07-18
2015-06-08 10:56jorge-garciaRegression introduced in release => 3.0PR14Q3
2015-06-08 10:56jorge-garciaRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/77b6251af841 [^]
2015-06-08 11:00jorge-garciaStatusacknowledged => scheduled
2015-06-08 11:01jorge-garciaTarget Version => 3.0PR15Q3
2015-06-09 17:51jorge-garciaRegression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/77b6251af841 [^] => https://code.openbravo.com/erp/devel/pi/diff/87765308f9bd/modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_GEN_PAYMENTSCHEDULE_INV.xml [^]
2015-06-11 16:39vmromanosRelationship addedcaused by 0025696
2015-06-12 13:46hgbotCheckin
2015-06-12 13:46hgbotNote Added: 0078244
2015-06-12 13:46hgbotStatusscheduled => resolved
2015-06-12 13:46hgbotResolutionopen => fixed
2015-06-12 13:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/99cc73c54bf0ac353efa16f2a8e47c815300df0e [^]
2015-06-12 13:46hgbotCheckin
2015-06-12 13:46hgbotNote Added: 0078246
2015-06-12 13:53vmromanosReview Assigned To => vmromanos
2015-06-12 13:53vmromanosNote Added: 0078249
2015-06-12 13:53vmromanosStatusresolved => closed
2015-06-14 19:58hudsonbotCheckin
2015-06-14 19:58hudsonbotNote Added: 0078269
2015-06-14 19:58hudsonbotCheckin
2015-06-14 19:58hudsonbotNote Added: 0078270
2015-06-22 11:58vmromanosRelationship addedblocks 0030007
2015-06-22 11:58vmromanosRelationship addedblocks 0030170
2016-02-02 09:35hgbotCheckin
2016-02-02 09:35hgbotNote Added: 0083807
2016-08-10 14:23aferrazRelationship addedrelated to 0033500

Notes
(0078060)
jorge-garcia   
2015-06-04 12:53   
Test Plan:

**Try this fix with the fix of the issue 29972 applied as well**

As group admin role:
 Create a new Payment Method and set Automatic Receipt = 'Y'
   Add it to a financial account.

 1) Test 1:
   Create a Sales Order, set the previously created payment method and Invoice Terms = Immediate.
   Click on Add Payment an create a partial payment for the Sales Order.
   Create a Sales Invoice from it and complete it
   Check the Received field and Outstanding field of the Payment Plan of the invoice has been updated correctly.
   Check the Received field and Outstanding field of the Payment Plan of the order has been updated correctly.
 
 2) Test 2:
   Create a Sales Order, set the previously created payment method and Invoice Terms = Immediate.
   Click on Add Payment an create a full payment for the Sales Order.
   Create a Sales Invoice from it and complete it
   Check the Received field and Outstanding field of the Payment Plan of the invoice has been updated correctly.
   Check the Received field and Outstanding field of the Payment Plan of the order has been updated correctly.

 3) Test 3:
   Create a Sales Order, set the previously created payment method and Invoice Terms = Immediate.
   Create a Sales Invoice from it and complete it
   Check the Received field and Outstanding field of the Payment Plan of the invoice has been updated correctly.
   Check the Received field and Outstanding field of the Payment Plan of the order has been updated correctly.

(0078244)
hgbot   
2015-06-12 13:46   
Repository: erp/devel/pi
Changeset: 99cc73c54bf0ac353efa16f2a8e47c815300df0e
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Jun 10 13:09:56 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/99cc73c54bf0ac353efa16f2a8e47c815300df0e [^]

Fixed issue 30082: Payment plan is updating wrong in some circumstances

Payment plan is updating wrong if Payment Method is set as Automatic Receipt
and a sales order is partially paid.

The problem was that the function duplicates the value of the received amount
created in the Complete process of the invoice, because the function searches
all the payment details of the payment plan that has an invoice paid
(invoicepaid column).

The solution is to search those payment details that are not pre-paid and then
update the payment plan.

Now, the values are filled correctly.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_GEN_PAYMENTSCHEDULE_INV.xml
---
(0078246)
hgbot   
2015-06-12 13:46   
Repository: erp/devel/pi
Changeset: ab5e144258614a33ed239fd3989894f752fb175e
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Jun 12 12:49:18 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ab5e144258614a33ed239fd3989894f752fb175e [^]

Related to issue 30082: code review improvements

The invoice's payment schedules and payment monitor is only updated when all the payment schedule details are paid.

This changeset covers the scenario where an order is partially paid. Before this change, the invoice's payment schedules and payment monitor were wrongly updated considering that the payment schedule was fully paid when any of its payment schedule details was paid. That asumption may be wrong in some scenarios, for example when the order is associated to one or more payment schedule details not yet paid (isinvoicepaid=N) and at least one already paid.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_GEN_PAYMENTSCHEDULE_INV.xml
---
(0078249)
vmromanos   
2015-06-12 13:53   
Code review + testing OK
(0078269)
hudsonbot   
2015-06-14 19:58   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1cf5ab8b5006 [^]
Maturity status: Test
(0078270)
hudsonbot   
2015-06-14 19:58   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1cf5ab8b5006 [^]
Maturity status: Test
(0083807)
hgbot   
2016-02-02 09:35   
Repository: tools/automation/int
Changeset: e7a1aa2cb768823f44b1948ffc91a2a63ec3aadc
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Sep 25 09:39:00 2015 +0200
URL: http://code.openbravo.com/tools/automation/int/rev/e7a1aa2cb768823f44b1948ffc91a2a63ec3aadc [^]

Related to issue 30082: Added some automated tests

---
M src-test/com/openbravo/test/integration/erp/gui/procurement/transactions/purchaseorder/PurchaseOrderHeaderTab.java
M src-test/com/openbravo/test/integration/erp/modules/client/application/gui/GeneratedTab.java
M src-test/com/openbravo/test/integration/erp/modules/client/application/gui/OBStandardView.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/RegressionSuite.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/build.xml
M src-test/com/openbravo/test/integration/erp/testscripts/procurement/transactions/PurchaseOrder.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APRRegression021.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APRRegression022.java
---