Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030055Openbravo ERPA. Platformpublic2015-05-31 14:042015-11-14 13:02
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR15Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030055: Cleanup all eclipse warnings in src-trl
DescriptionThis bug is to fix all (per openbravo preferences) eclipse warnings in src-trl folder.

Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0030056 closed shuehner Cleanup all eclipse warnings in src-wad 
related to defect 0030053 closed shuehner Cleanup local unused variables warning 
related to defect 0030054 closed shuehner Cleanup warnings in wad generated code (srcAD) 
related to defect 0030052 closed shuehner Lots of 'Unnecessary cast' warnings in pi after enabling that extra warning in Eclipse 
blocks feature request 0031477 new shuehner Tracking issue to reduce the huge number of eclipse warnings in pi 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-05-31 14:04shuehnerNew Issue
2015-05-31 14:04shuehnerAssigned To => shuehner
2015-05-31 14:04shuehnerModules => Core
2015-05-31 14:04shuehnerTriggers an Emergency Pack => No
2015-05-31 14:30shuehnerRelationship addedrelated to 0030056
2015-06-01 13:09hgbotCheckin
2015-06-01 13:09hgbotNote Added: 0077936
2015-06-01 13:09hgbotStatusnew => resolved
2015-06-01 13:09hgbotResolutionopen => fixed
2015-06-01 13:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1474b680f2164bc6802ed7c46d131b38951ecb7a [^]
2015-06-01 13:11shuehnerReview Assigned To => alostale
2015-06-04 12:24alostaleRelationship addedrelated to 0030053
2015-06-04 12:24alostaleRelationship addedrelated to 0030054
2015-06-04 12:24alostaleRelationship addedrelated to 0030052
2015-06-04 12:55alostaleNote Added: 0078064
2015-06-04 12:55alostaleStatusresolved => closed
2015-06-04 12:55alostaleFixed in Version => 3.0PR15Q3
2015-11-14 13:02shuehnerRelationship addedblocks 0031477

Notes
(0077936)
hgbot   
2015-06-01 13:09   
Repository: erp/devel/pi
Changeset: 1474b680f2164bc6802ed7c46d131b38951ecb7a
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sun May 31 14:06:56 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1474b680f2164bc6802ed7c46d131b38951ecb7a [^]

Fixed 30055. Fix all warnings in src-trl

Two types of changes:
- Remove variables which are never read
- Do not assign to parameters, copy to local var instead
  References of parameters cannot be modified in java
  Content of objects passed in can be, however in all this
  cases object are String which are immutable
  Same fix always: Copy of local variable keeping name
  of old param as new variable name to reduce diff to review.
  - That avoid any developer confusing maybe thinking change
    of param would be visible in caller.

---
M src-trl/src/org/openbravo/translate/RTLSkin.java
M src-trl/src/org/openbravo/translate/Translate.java
---
(0078064)
alostale   
2015-06-04 12:55   
code reviewed