Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030033Openbravo ERP04. Warehouse managementpublic2015-05-27 16:322015-09-11 15:56
Reporterngarcia 
Assigned Toaferraz 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030033: Create Inventory Count List process does not insert products without stock if product has a mandatory attribute
DescriptionCreate Inventory Count List process does not insert products without stock if product has a mandatory attribute. The problem is that due to the fix of the following bug, records are deleted from the m_storage_detail if the attribute set is set as Require At Least one value and Use Attribute Set Value as is different from 'Specification':

https://issues.openbravo.com/view.php?id=20159 [^]
Steps To ReproduceAs group admin role:
   Create two Attribute Sets. Check the Lot in both of them
   Check the Require At Least One Value to one of them
   Create two products and assign one attribute set to each one (mandatory and non mandatory)
   Create a Goods Receipt, add the two products, assign an attribute set value to both of them and complete
   Create a Goods Shipment and add the two products in order to leave the stock to 0
   Create a Physical Inventory header and launch the Create Inventory Count Process
   Check a line is created for the product with the non mandatory attribute set with the value assigned in the goods receipt line
   You cannot manually add that line to the physical inventory
Proposed SolutionAfter discussing it with Maarten, he proposes not to remove the lines in the M_STORAGE_DETAIL when the product gets out of stock and it is not present in any warehouse document in draft status and implement a process the user should launch to remove the lines with all the quantities to 0
Additional Information
TagsNo tags attached.
Relationships
related to defect 00201593.0MP11 closed jecharri Product with mandatory attribute should not generate lines without attribute in m_storage_detail 
related to defect 0029571 closed jorge-garcia In Physical Inventory Lines, Book Quantity is not updated to 0 by Update Quantity process if product has a mandatory attribute 
related to defect 0030697 closed AtulOpenbravo Create Inventory Count List inserts inactive products 
causes defect 0032806 closed markmm82 Cannot void a goods receipt if the role does not have access to Client window 
Attached Filespng Receipt.png (145,438) 2015-09-09 19:22
https://issues.openbravo.com/file_download.php?file_id=8441&type=bug
png

png Popup.png (143,851) 2015-09-09 19:23
https://issues.openbravo.com/file_download.php?file_id=8442&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2015-05-27 16:32ngarciaNew Issue
2015-05-27 16:32ngarciaAssigned To => Triage Finance
2015-05-27 16:32ngarciaModules => Core
2015-05-27 16:32ngarciaResolution time => 1432850400
2015-05-27 16:32ngarciaTriggers an Emergency Pack => No
2015-05-27 16:33ngarciaIssue Monitored: networkb
2015-05-27 16:33ngarciaRelationship addedrelated to 0020159
2015-05-27 16:33ngarciaRelationship addedrelated to 0029571
2015-05-29 10:11aferrazAssigned ToTriage Finance => aferraz
2015-05-29 11:41ngarciaProposed Solution updated
2015-08-20 10:56aferrazStatusnew => scheduled
2015-08-28 14:56ngarciaRelationship addedrelated to 0030697
2015-09-09 19:05aferrazNote Added: 0080296
2015-09-09 19:22aferrazFile Added: Receipt.png
2015-09-09 19:23aferrazFile Added: Popup.png
2015-09-11 09:32hgbotCheckin
2015-09-11 09:32hgbotNote Added: 0080329
2015-09-11 09:32hgbotStatusscheduled => resolved
2015-09-11 09:32hgbotResolutionopen => fixed
2015-09-11 09:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/17eb51a4c06e4c52758955c846be5a7b91c4edcb [^]
2015-09-11 09:32hgbotCheckin
2015-09-11 09:32hgbotNote Added: 0080330
2015-09-11 09:34dmiguelezReview Assigned To => dmiguelez
2015-09-11 09:34dmiguelezNote Added: 0080331
2015-09-11 09:34dmiguelezStatusresolved => closed
2015-09-11 09:36dmiguelezNote Added: 0080332
2015-09-11 10:08aferrazNote Edited: 0080332bug_revision_view_page.php?bugnote_id=0080332#r9421
2015-09-11 15:56hudsonbotCheckin
2015-09-11 15:56hudsonbotNote Added: 0080343
2015-09-11 15:56hudsonbotCheckin
2015-09-11 15:56hudsonbotNote Added: 0080344
2016-08-29 10:04ngarciaRelationship addedcauses 0032806

Notes
(0080296)
aferraz   
2015-09-09 19:05   
Test plan:

As F&B Admin:

- Create an Attribute Set. Check only Lot flag.
- Create another Attribute Set. Check Lot and Require At Least One Value flags.

- Create a product and assign the first attribute set to it.
- Create another product and assign the second attribute set to it.

- Create a Goods Receipt.
  Add a line with first product, quantity = 1.
  Add a line with second product, quantity = 2.
  Add another line with second product, quantity = 3.
  
- Create a Goods Shipment and add three lines in order to leave the stock of created products to 0

- Create a Physical Inventory header and launch the Create Inventory Count Process, leaving Inventory Quantity option empty.
  Check a line is created for the first product (non mandatory attribute) but not for the second product (mandatory attribute).
  Increase the quantity count of the line created for the first product to 1 and process the inventory.

- Move to the created Goods Receipt and click on Close button. Select Void and click Ok.
  Realize Create Physical Inventory popup is shown with a grid with two lines (one for each receipt line with a mandatory attribute and without stock)
  Click on Cancel. Realize no stock error message is shown.
  Click on Close button. Select Void and click Ok.
  Realize a completed succesfully message is shown.

- Go to Physical Inventory window.
  Realize an inventory has been created with previous two lines, each one with receipt movement quantity.
(0080329)
hgbot   
2015-09-11 09:32   
Repository: erp/devel/pi
Changeset: 17eb51a4c06e4c52758955c846be5a7b91c4edcb
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Sep 10 10:08:39 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/17eb51a4c06e4c52758955c846be5a7b91c4edcb [^]

Fixes issue 30033: Can't create stock for product with attribute without stock

We will not be able to void a receipt with a product with a mandatory attribute set value and without stock, if client does not allow negative stock. We will also not be able to create an inventory to increase the stock of this product because we can not select this attribute set value with a selector, and Create Inventory Count List process does not insert lines with products without stock if product has a mandatory attribute.
Now, if we are voiding a Goods Receipt with any line with mandatory attribute set value and without stock, a new popup will allow us to automatically create a Physical Inventory to generate stock for this product and then void the receipt.

---
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M src/org/openbravo/erpCommon/ad_actionButton/ProcessGoods.java
A src/org/openbravo/erpCommon/ad_actionButton/PhysicalInventory.html
A src/org/openbravo/erpCommon/ad_actionButton/PhysicalInventory.xml
A src/org/openbravo/erpCommon/ad_actionButton/PhysicalInventoryGrid.srpt
A src/org/openbravo/erpCommon/ad_actionButton/PhysicalInventoryGrid.xml
---
(0080330)
hgbot   
2015-09-11 09:32   
Repository: erp/devel/pi
Changeset: 9a27b30560fc64f9e5de24d25011310889f867ce
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Sep 11 09:30:57 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9a27b30560fc64f9e5de24d25011310889f867ce [^]

Related to Issue 30033: Code Review Changes.
Removed global variables and transformed them into local ones.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/erpCommon/ad_actionButton/PhysicalInventory.html
M src/org/openbravo/erpCommon/ad_actionButton/PhysicalInventory.xml
M src/org/openbravo/erpCommon/ad_actionButton/ProcessGoods.java
---
(0080331)
dmiguelez   
2015-09-11 09:34   
Code Review + Testing Ok
(0080332)
dmiguelez   
2015-09-11 09:36   
(edited on: 2015-09-11 10:08)
The fix to this issue has not been to modify the Create Inventory Count Process.

In order to do so it is needed to be able to differentiate one Attribute Set Instance from another from a user perspective, and it is not possible right now.

What it has been done is to allow to create an Inventory Regularization while Voiding a Goods Receipt for the Products that might rise a problem. This has been done to solve the issue the Client was facing.

The proposed and more general solution would be implemented when possible.
(0080343)
hudsonbot   
2015-09-11 15:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2b0a88efd3f9 [^]
Maturity status: Test
(0080344)
hudsonbot   
2015-09-11 15:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2b0a88efd3f9 [^]
Maturity status: Test