Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030010Openbravo ERP03. Procurement managementpublic2015-05-25 17:112015-05-27 10:37
Reporterngarcia 
Assigned Tovmromanos 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q2.2Fixed in Version3.0PR15Q2.2 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2015-02-10
Regression introduced in release3.0PR15Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/07f0f908a7eb8af5a08df2c96b3ee827dcc1eb52 [^]
Triggers an Emergency PackNo
Summary0030010: Cannot create a purchase order from the Requisition To Order window
DescriptionCannot create a purchase order from the Requisition To Order window
Steps To ReproduceAs group admin role:
   Create a Requisition and book it
   Go to the Requisition To Order window, select the line from the first grid, click on Add, select the line for the second grid, click on Create and OK
   The following error is shown:
      Process failed during execution
   And the logs shows:
java.lang.NumberFormatException
    at java.math.BigDecimal.<init>(BigDecimal.java:545)
    at java.math.BigDecimal.<init>(BigDecimal.java:739)
    at org.openbravo.erpCommon.ad_forms.RequisitionToOrder.processPurchaseOrder(RequisitionToOrder.java:570)...
Proposed SolutionIn the following instruction of the RequisitionToOrder.java file, the quantityorder field can be null:

new BigDecimal(lines[i].quantityorder)
Additional Information
TagsApproved
Relationships
blocks defect 0030002 closed vmromanos Cannot create a purchase order from the Requisition To Order window 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-05-26 11:14aferrazTypedefect => backport
2015-05-26 11:14aferrazTarget Version => 3.0PR15Q2.2
2015-05-26 16:46dmitry_mezentsevTag Attached: Approved
2015-05-26 18:33vmromanosAssigned Toaferraz => vmromanos
2015-05-27 10:36hgbotCheckin
2015-05-27 10:36hgbotNote Added: 0077795
2015-05-27 10:36hgbotStatusscheduled => resolved
2015-05-27 10:36hgbotResolutionopen => fixed
2015-05-27 10:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q2.2/rev/232e891a91189f1c16e8ea7a37ef08bca56a6ef7 [^]
2015-05-27 10:37aferrazReview Assigned To => aferraz
2015-05-27 10:37aferrazNote Added: 0077797
2015-05-27 10:37aferrazStatusresolved => closed
2015-05-27 10:37aferrazFixed in Version => 3.0PR15Q2.2

Notes
(0077795)
hgbot   
2015-05-27 10:36   
Repository: erp/backports/3.0PR15Q2.2
Changeset: 232e891a91189f1c16e8ea7a37ef08bca56a6ef7
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue May 26 18:20:34 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q2.2/rev/232e891a91189f1c16e8ea7a37ef08bca56a6ef7 [^]

Fixed bug 30010: Error in Requisition To Order window

When creating a purchase order from the Requisition To Order window, an error was raised when lines[i].quantityorder is empty.
Now the SQL query returns quantityorder = 0 when it's null. Then, when inserting the purchase order line, the process inserts "" if quantityorder = 0

---
M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder.java
M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder_data.xsql
---
(0077797)
aferraz   
2015-05-27 10:37   
Code review + Testing OK