Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030002Openbravo ERP03. Procurement managementpublic2015-05-25 17:112015-05-28 01:10
Reporterngarcia 
Assigned Tovmromanos 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR15Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket36382
Regression levelProduction - QA Approved
Regression date2015-02-10
Regression introduced in release3.0PR15Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/07f0f908a7eb8af5a08df2c96b3ee827dcc1eb52 [^]
Triggers an Emergency PackNo
Summary0030002: Cannot create a purchase order from the Requisition To Order window
DescriptionCannot create a purchase order from the Requisition To Order window
Steps To ReproduceAs group admin role:
   Create a Requisition and book it
   Go to the Requisition To Order window, select the line from the first grid, click on Add, select the line for the second grid, click on Create and OK
   The following error is shown:
      Process failed during execution
   And the logs shows:
java.lang.NumberFormatException
    at java.math.BigDecimal.<init>(BigDecimal.java:545)
    at java.math.BigDecimal.<init>(BigDecimal.java:739)
    at org.openbravo.erpCommon.ad_forms.RequisitionToOrder.processPurchaseOrder(RequisitionToOrder.java:570)...
Proposed SolutionIn the following instruction of the RequisitionToOrder.java file, the quantityorder field can be null:

new BigDecimal(lines[i].quantityorder)
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00300103.0PR15Q2.2 closed vmromanos Cannot create a purchase order from the Requisition To Order window 
caused by defect 00287753.0PR15Q2 closed reinaldoguerra "Order quantity" incorrectly set in Purchase Order Line when several requisition line are referenced 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-05-25 17:11ngarciaNew Issue
2015-05-25 17:11ngarciaAssigned To => Triage Finance
2015-05-25 17:11ngarciaOBNetwork customer => Yes
2015-05-25 17:11ngarciaModules => Core
2015-05-25 17:11ngarciaSupport ticket => 36382
2015-05-25 17:11ngarciaResolution time => 1432504800
2015-05-25 17:11ngarciaRegression level => Production - QA Approved
2015-05-25 17:11ngarciaRegression date => 2015-02-10
2015-05-25 17:11ngarciaRegression introduced in release => 3.0PR15Q2
2015-05-25 17:11ngarciaRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/07f0f908a7eb8af5a08df2c96b3ee827dcc1eb52 [^]
2015-05-25 17:11ngarciaTriggers an Emergency Pack => No
2015-05-25 17:12ngarciaRelationship addedcaused by 0028775
2015-05-25 17:26ngarciaIssue Monitored: networkb
2015-05-26 11:14aferrazAssigned ToTriage Finance => aferraz
2015-05-26 11:14aferrazStatusnew => scheduled
2015-05-26 12:46aferrazNote Added: 0077755
2015-05-26 18:33vmromanosAssigned Toaferraz => vmromanos
2015-05-27 10:35hgbotCheckin
2015-05-27 10:35hgbotNote Added: 0077793
2015-05-27 10:35hgbotStatusscheduled => resolved
2015-05-27 10:35hgbotResolutionopen => fixed
2015-05-27 10:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f8b937eb67f22440b6ea307d50e7ff41f2641dab [^]
2015-05-27 10:36aferrazReview Assigned To => aferraz
2015-05-27 10:36aferrazNote Added: 0077796
2015-05-27 10:36aferrazStatusresolved => closed
2015-05-27 10:36aferrazFixed in Version => 3.0PR15Q3
2015-05-28 01:10hudsonbotCheckin
2015-05-28 01:10hudsonbotNote Added: 0077841

Notes
(0077755)
aferraz   
2015-05-26 12:46   
Test plan:

As F&B Admin:

- Create a Requisition and book it
- Go to the Requisition To Order window, select the line from the first grid, click on Add, select the line for the second grid, click on Create and OK
- Realize Purchase Order is correctly created
(0077793)
hgbot   
2015-05-27 10:35   
Repository: erp/devel/pi
Changeset: f8b937eb67f22440b6ea307d50e7ff41f2641dab
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue May 26 18:20:34 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f8b937eb67f22440b6ea307d50e7ff41f2641dab [^]

Fixed bug 30002: Error in Requisition To Order window

When creating a purchase order from the Requisition To Order window, an error was raised when lines[i].quantityorder is empty.
Now the SQL query returns quantityorder = 0 when it's null. Then, when inserting the purchase order line, the process inserts "" if quantityorder = 0

---
M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder.java
M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder_data.xsql
---
(0077796)
aferraz   
2015-05-27 10:36   
Code review + Testing OK
(0077841)
hudsonbot   
2015-05-28 01:10   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ae25da3bd47f [^]
Maturity status: Test