Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0029982Openbravo ERP08. Project and service managementpublic2015-05-22 13:072015-06-04 14:27
ngarcia 
AtulOpenbravo 
urgentmajoralways
closedfixed 
5
 
 
vmromanos
Core
No
0029982: Cannot create a sales order from a project phase if the price list of the project is not defined
Cannot create a sales order from a project phase if the price list of the project is not defined
As group admin role:
   Create a Multiphase Project
   Leave the Price List field empty
   Create a Project Phase
   Launch the Set Project Type process
   Change Project Status to Order
   Select the Project Phase and launch the Create Sales from Project Phase process
   Check a success message is shown but the sales order is not created
      "Document No.:"
No tags attached.
Issue History
2015-05-22 13:07ngarciaNew Issue
2015-05-22 13:07ngarciaAssigned To => Triage Finance
2015-05-22 13:07ngarciaModules => Core
2015-05-22 13:07ngarciaTriggers an Emergency Pack => No
2015-05-22 13:08ngarciaIssue Monitored: networkb
2015-05-25 12:48jonalegriaesarteResolution time => 1434924000
2015-05-29 07:35AtulOpenbravoAssigned ToTriage Finance => AtulOpenbravo
2015-05-29 07:35AtulOpenbravoStatusnew => scheduled
2015-06-03 14:25hgbotCheckin
2015-06-03 14:25hgbotNote Added: 0078020
2015-06-03 14:25hgbotStatusscheduled => resolved
2015-06-03 14:25hgbotResolutionopen => fixed
2015-06-03 14:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9660c62a65e2ac18ea84bd76127ed21f2a5b772e [^]
2015-06-03 14:25hgbotCheckin
2015-06-03 14:25hgbotNote Added: 0078021
2015-06-03 14:28vmromanosReview Assigned To => vmromanos
2015-06-03 14:28vmromanosNote Added: 0078022
2015-06-03 14:28vmromanosStatusresolved => closed
2015-06-04 14:27hudsonbotCheckin
2015-06-04 14:27hudsonbotNote Added: 0078073
2015-06-04 14:27hudsonbotCheckin
2015-06-04 14:27hudsonbotNote Added: 0078074

Notes
(0078020)
hgbot   
2015-06-03 14:25   
Repository: erp/devel/pi
Changeset: 9660c62a65e2ac18ea84bd76127ed21f2a5b772e
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Fri May 29 18:13:33 2015 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/9660c62a65e2ac18ea84bd76127ed21f2a5b772e [^]

Fixes Issue 29982:Cannot create a sales order from a project phase if the
price list of the project is not defined

ChangeProjectStatusToOrder function takes care to check whether pricelist in
project is null in case of multiphase project category 'S'.

Query used in for loop did not fetched records in GenerateSoFromProjectPhase as
pricelist was null. Now query returns results with null pricelists also so
that proper error message is shown.

---
M src-db/database/model/functions/C_CHANGEPROJECTSTATUSTOORDER.xml
M src-db/database/model/functions/C_GENERATESOFROMPROJECTPHASE.xml
---
(0078021)
hgbot   
2015-06-03 14:25   
Repository: erp/devel/pi
Changeset: 6f5bd72a978907629af1669d4dce24f2dfc088da
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Jun 03 14:24:14 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6f5bd72a978907629af1669d4dce24f2dfc088da [^]

Related to issue 29982: code review improvements

Avoid useless join to M_PRICELIST table to improve performance
Use generic error message

---
M src-db/database/model/functions/C_CHANGEPROJECTSTATUSTOORDER.xml
M src-db/database/model/functions/C_GENERATESOFROMPROJECTPHASE.xml
---
(0078022)
vmromanos   
2015-06-03 14:28   
Code review + testing OK
(0078073)
hudsonbot   
2015-06-04 14:27   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c031eb54738d [^]
Maturity status: Test
(0078074)
hudsonbot   
2015-06-04 14:27   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c031eb54738d [^]
Maturity status: Test