Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029942Openbravo ERP09. Financial managementpublic2015-05-20 13:162016-02-02 09:35
Reporterinigosanchez 
Assigned Toaferraz 
PriorityimmediateSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2014-09-23
Regression introduced in release3.0PR14Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/179d97ee602d [^]
Triggers an Emergency PackNo
Summary0029942: NPE Error raised when a "Recieved From" value is filled in Add Payment P&E window
DescriptionNPE Error raised when a "Recieved From" value is filled in Add Payment P&E window.This happens when is not exists a payment method.
Steps To Reproduce- As group admin go to [Financial Account] window. Select "Cuenta de Banco".
- Add new Transaction and press "+" selector to open "Add Payment" P&E Window.
- In "Received From" field press in the magnifying glass.
- Select "Sl Rapid, SA" and press OK.

NPE Error is thrown in a popup: org.openbravo.base.exception.OBException: java.lang.NullPointerException
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00299803.0PR15Q2.2 closed aferraz NPE Error raised when a "Recieved From" value is filled in Add Payment P&E window 
depends on backport 00299813.0PR15Q1.5 closed aferraz NPE Error raised when a "Recieved From" value is filled in Add Payment P&E window 
caused by feature request 0029387 closed Sandrahuguet Transaction refactor project 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-05-20 13:16inigosanchezNew Issue
2015-05-20 13:16inigosanchezAssigned To => Triage Finance
2015-05-20 13:16inigosanchezModules => Core
2015-05-20 13:16inigosanchezTriggers an Emergency Pack => No
2015-05-20 13:56aferrazAssigned ToTriage Finance => aferraz
2015-05-20 14:00aferrazRelationship addedcaused by 0029387
2015-05-20 14:01aferrazRegression level => Production - Confirmed Stable
2015-05-20 14:01aferrazRegression date => 2014-08-21
2015-05-20 14:01aferrazRegression introduced in release => 3.0PR14Q4
2015-05-20 14:01aferrazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/8a0d6c8c1eb1 [^]
2015-05-20 14:02aferrazPrioritylow => immediate
2015-05-20 16:17aferrazRegression date2014-08-21 => 2014-09-23
2015-05-20 16:17aferrazRegression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/8a0d6c8c1eb1 [^] => https://code.openbravo.com/erp/devel/pi/rev/179d97ee602d [^]
2015-05-22 12:32aferrazStatusnew => scheduled
2015-05-26 11:55hgbotCheckin
2015-05-26 11:55hgbotNote Added: 0077750
2015-05-26 11:55hgbotStatusscheduled => resolved
2015-05-26 11:55hgbotResolutionopen => fixed
2015-05-26 11:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e58f5e3d1259e6a91ea79e4d89c33327b22193e4 [^]
2015-05-26 11:55vmromanosReview Assigned To => vmromanos
2015-05-26 11:55vmromanosNote Added: 0077753
2015-05-26 11:55vmromanosStatusresolved => closed
2015-05-27 00:39hudsonbotCheckin
2015-05-27 00:39hudsonbotNote Added: 0077779
2016-02-02 09:35hgbotCheckin
2016-02-02 09:35hgbotNote Added: 0083812

Notes
(0077750)
hgbot   
2015-05-26 11:55   
Repository: erp/devel/pi
Changeset: e58f5e3d1259e6a91ea79e4d89c33327b22193e4
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed May 20 14:06:47 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e58f5e3d1259e6a91ea79e4d89c33327b22193e4 [^]

Fixes issue 29942: NPE in Add Payment process request

When selecting a business partner with the magnifying glass in Add Payment process request, which does not match to the type of the document (a Vendor when the type is Received In); the payment method of the business partner was null and when accessing to its id, a NPE was raised.
Now, if payment method is null will be checked.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/ReceivedFromPaymentMethodActionHandler.java
---
(0077753)
vmromanos   
2015-05-26 11:55   
Code review + testing OK
(0077779)
hudsonbot   
2015-05-27 00:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2ac0a8fe23d2 [^]
Maturity status: Test
(0083812)
hgbot   
2016-02-02 09:35   
Repository: tools/automation/int
Changeset: 3441e287dc6493eccf4e4c3e02877c281ba7889a
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Sep 25 11:33:45 2015 +0200
URL: http://code.openbravo.com/tools/automation/int/rev/3441e287dc6493eccf4e4c3e02877c281ba7889a [^]

Related to issue 30641, Related to issue 29942: Added some automated tests

---
M src-test/com/openbravo/test/integration/erp/gui/financial/receivablespayables/transactions/AddPaymentProcess.java
M src-test/com/openbravo/test/integration/erp/gui/financial/receivablespayables/transactions/financialaccount/TransactionTab.java
M src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartner/BusinessPartnerTab.java
M src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartner/BusinessPartnerWindow.java
M src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartner/classic/BusinessPartnerTab.java
M src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartner/classic/BusinessPartnerWindow.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/RegressionSuite.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/build.xml
M src-test/com/openbravo/test/integration/erp/testscripts/financial/receivablespayables/transactions/FinancialAccount.java
M src-test/com/openbravo/test/integration/erp/testscripts/masterdata/businesspartner/BusinessPartner.java
M src-test/com/openbravo/test/integration/erp/testscripts/masterdata/businesspartner/BusinessPartnerScript.java
A src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartner/VendorCreditorTab.java
A src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartner/classic/VendorCreditorTab.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APRRegression30641In29942In.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APRRegression30641Out29942Out.java
A src-test/com/openbravo/test/integration/erp/testscripts/masterdata/businesspartner/VendorCreditorClassicScript.java
A src-test/com/openbravo/test/integration/erp/testscripts/masterdata/businesspartner/VendorCreditorScript.java
---