Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0029930Openbravo ERPZ. Otherspublic2015-05-19 10:592015-05-27 00:39
maite 
aferraz 
immediatemajoralways
closedfixed 
5
 
3.0PR15Q3 
vmromanos
Core
No
0029930: Exchange Rate defaulted to 1 in Add Payment process definition when no conversion rate exists between currencies
Exchange Rate defaulted to 1 in Add Payment process definition when no conversion rate exists between currencies
1. Access Financial Account "Cuenta de banco" and configure "Transferencia" Payment method as "Make payments in multiple currencies"
2. Create new transaction setting type "Withdrawal" and press + button to add payment
3. Change currency to MXN and realize that conversion rate is set to 1, when no conversion rate is really registered in the system between MXN and EUR. Conversion rate should be left empty, similar as occurs if you create payment directly in Payment Out window
No tags attached.
Issue History
2015-05-19 10:59maiteNew Issue
2015-05-19 10:59maiteAssigned To => Triage Finance
2015-05-19 10:59maiteModules => Core
2015-05-19 10:59maiteTriggers an Emergency Pack => No
2015-05-19 11:01maiteResolution time => 1434751200
2015-05-19 11:01maiteTarget Version => 3.0PR15Q3
2015-05-19 11:01maiteIssue Monitored: networkb
2015-05-25 18:46aferrazStatusnew => scheduled
2015-05-25 18:46aferrazAssigned ToTriage Finance => aferraz
2015-05-26 09:46aferrazNote Added: 0077734
2015-05-26 16:20hgbotCheckin
2015-05-26 16:20hgbotNote Added: 0077763
2015-05-26 16:20hgbotStatusscheduled => resolved
2015-05-26 16:20hgbotResolutionopen => fixed
2015-05-26 16:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0bf5a77eb42b400d348bcfe2c27c875d62e45e83 [^]
2015-05-26 16:21vmromanosReview Assigned To => vmromanos
2015-05-26 16:21vmromanosNote Added: 0077764
2015-05-26 16:21vmromanosStatusresolved => closed
2015-05-27 00:39hudsonbotCheckin
2015-05-27 00:39hudsonbotNote Added: 0077781

Notes
(0077734)
aferraz   
2015-05-26 09:46   
As F&B Admin:

- Go to Financial Account "Cuenta de banco" and configure "Transferencia" Payment method as "Receive payments in multiple currencies" and "Make payments in multiple currencies"

- Create new transaction setting type "Withdrawal" and press + button to add payment

- Change currency to MXN and realize that converted amount and conversion rate are empty, when no conversion rate is really registered in the system between MXN and EUR. Realize also, both fields are mandatory.

Repeat the same flow opening Add Payment from Purchase Order, Purchase Invoice, Payment Out, Sales Order, Sales Invoice, Payment In and Add Transaction.
(0077763)
hgbot   
2015-05-26 16:20   
Repository: erp/devel/pi
Changeset: 0bf5a77eb42b400d348bcfe2c27c875d62e45e83
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon May 25 20:02:16 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0bf5a77eb42b400d348bcfe2c27c875d62e45e83 [^]

Fixes issue 29930: Exchange Rate defaulted to 1 in Add Payment

Converted Amount and Conversion Rate fields in Add Payment process definition will be empty as default if conversion rate between currencies is not defined.
Also, those fields will be mandatory, to force the user tip them in case of multi currency payment.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/PaymentMethodMulticurrencyActionHandler.java
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0077764)
vmromanos   
2015-05-26 16:21   
Code review + testing OK
(0077781)
hudsonbot   
2015-05-27 00:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2ac0a8fe23d2 [^]
Maturity status: Test