0029910: exporting grid to csv can fail if audit fields are included

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0029910

Openbravo ERP

A. Platform

public

2015-05-18 10:30

2015-11-23 21:17

Reporter

yogaskarnik

Assigned To

platform

Priority

normal

Severity

minor

Reproducibility

sometimes

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

3.0PR15Q1

Target Version

Fixed in Version

3.0PR16Q1

Merge Request Status

Review Assigned To

caristu

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0029910: exporting grid to csv can fail if audit fields are included

Description

Under certain circumstances when trying to export a grid to csv including audit columns it can fail.

When this happens:
* The CSV file contains a single line with:
{"response":{"status":-4,"error":{"message":"Error while exporting a CSV file", "type":"system"}}}
* This exception appears in openbravo.log:
370815 [http-8080-1] ERROR org.openbravo.client.kernel.KernelUtils - Error while exporting a CSV file
org.openbravo.base.exception.OBException: Error while exporting a CSV file
    at org.openbravo.service.datasource.DataSourceServlet$QueryJSONWriterToCSV.<init>(DataSourceServlet.java:493)
...
Caused by: org.hibernate.LazyInitializationException: failed to lazily initialize a collection of role: ADElement.aDElementTrlList, no session or session was closed
    at org.hibernate.collection.AbstractPersistentCollection.throwLazyInitializationException(AbstractPersistentCollection.java:383)
    at org.hibernate.collection.AbstractPersistentCollection.throwLazyInitializationExceptionIfNotConnected(AbstractPersistentCollection.java:375)
    at org.hibernate.collection.AbstractPersistentCollection.initialize(AbstractPersistentCollection.java:368)
    at org.hibernate.collection.AbstractPersistentCollection.read(AbstractPersistentCollection.java:111)
    at org.hibernate.collection.PersistentBag.iterator(PersistentBag.java:272)
    at org.openbravo.client.application.window.OBViewUtil.getLabel(OBViewUtil.java:130)

See steps to reproduce: the problem is OBViewUtil caches audit elements, but initially not their possible translations required for labeling csv columns. Step 6 initalizes those elements but translations only for one of them, steps 8 tries to get label from proxy of a DAL object which session is not longer in the thread.

Steps To Reproduce

In an instance with *no* modules in development:
1. Open Sales Order window
2. Restart Tomcat (so JVM caches are restarted also)
3. Login with the same browser used in step 1 (without cleaning its cache)
4. Open Sales Order window (at this point view is not requested because it is cached in browser)
5. Add Created column to grid
6. Export to csv
7. Add Updated column to grid
8. Export to csv
-> FAILS with error mentioned above

Proposed Solution

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0022764	3.0MP20	closed	alostale	cannot open any window
has duplicate	defect	0030289		closed	platform	Sometimes the export to csv fails
related to	defect	0028477		closed	alostale	view generation: unneeded queries to trl tables