Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029905Retail ModulesWeb POSpublic2015-05-16 14:132015-09-28 18:09
Reportermtaal 
Assigned Tomarvintm 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionno change required 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029905: Performance improvements in OrderLoader and Mobile.Core
DescriptionSee attached diff. Depends on the changes of the related ticket in finance.

Summary of the improvements:
- only create one callable statements for a ticket
- call finance process in different way
- check if there is only one stock bin, if so use that one directly (this saves the most time...)
- do all log.debug in log.isDebugEnabled (performance gain is minimal for this one).

Mobile core change: do not reset the OBContext if the user did not change and don't do sourceVersion computation when saving transactions. The first one is important and the current approach can even be seen as a small bug even imho.

gr. Martin

See attached the timings for each of the changes.
Steps To ReproduceRun the order loader test case attached in the related issue 29904) to check timings.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on feature request 00299043.0PR15Q3 closed Sandrahuguet Openbravo ERP Performance improvements for orderloading in finance core 
Attached Filesdiff mobil-core.diff (3,376) 2015-05-16 14:13
https://issues.openbravo.com/file_download.php?file_id=8094&type=bug
txt Perf-Current-Core.txt (1,695) 2015-05-16 14:14
https://issues.openbravo.com/file_download.php?file_id=8095&type=bug
diff retail-pos.diff (12,520) 2015-05-22 16:42
https://issues.openbravo.com/file_download.php?file_id=8112&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-05-16 14:13mtaalNew Issue
2015-05-16 14:13mtaalAssigned To => marvintm
2015-05-16 14:13mtaalFile Added: retail-pos.diff
2015-05-16 14:13mtaalOBNetwork customer => No
2015-05-16 14:13mtaalTriggers an Emergency Pack => No
2015-05-16 14:13mtaalRelationship addeddepends on 0029904
2015-05-16 14:13mtaalFile Added: mobil-core.diff
2015-05-16 14:14mtaalFile Added: Perf-Current-Core.txt
2015-05-22 16:41mtaalFile Deleted: retail-pos.diff
2015-05-22 16:42mtaalFile Added: retail-pos.diff
2015-06-26 15:38marvintmTarget VersionRR15Q3 => RR15Q4
2015-09-28 18:09mtaalNote Added: 0080675
2015-09-28 18:09mtaalStatusnew => closed
2015-09-28 18:09mtaalResolutionopen => no change required
2015-09-28 18:09mtaalTarget VersionRR15Q4 =>

Notes
(0080675)
mtaal   
2015-09-28 18:09   
Was already done as part of merging hgvol branch with retail core