Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029887Openbravo ERP04. Warehouse managementpublic2015-05-13 12:042015-05-18 11:58
Reporteraferraz 
Assigned Toaferraz 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionProfessional Appliance
Product Version 
Target Version3.0PR15Q2.1Fixed in Version3.0PR15Q2.1 
Merge Request Status
Review Assigned Toumartirena
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029887: [Cost Adjutments] - Error in Price Correction Background if Costing Background has not been executed
Description[Cost Adjutments] - Error in Price Correction Background if Costing Background has not been executed
Steps To ReproduceAs QA Testing Admin:

- Create a Product with name Test for Spain organization
Add a Purchase price list version with 100 unit/list price

- Create a Purchase Order with Test product and quantity 5. Book it.

- Create a Purchase Invoice, creating lines from the created order. Change the unit price to 105. Complete it.

- Create a Goods Receipt, creating lines from the created invoice. Complete it.

- Go to Process Request window and run Price Correction Background process. Realize in Process Monitor, the status of the process is Error.

The problem is that if Costing Background process has not been executed, the transaction does not have the cost calculated, and when executing the Price Correction Background a null pointer exception will be raised.
Proposed SolutionAdd in processPriceDifference method in PriceDifferenceProcess class, a restriction to ensure the transactions have the cost calculated.
Additional Information
TagsApproved
Relationships
blocks defect 00298613.0PR15Q3 closed aferraz [Cost Adjutments] - Error in Price Correction Background if Costing Background has not been executed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-05-14 16:56aferrazTypedefect => backport
2015-05-14 16:56aferrazTarget Version3.0PR15Q3 => 3.0PR15Q2.1
2015-05-15 13:20dmitry_mezentsevTag Attached: Approved
2015-05-18 08:51aferrazSummary[Cost Adjutments] - Error in Price Correction Background if Consting Background has not been executed => [Cost Adjutments] - Error in Price Correction Background if Costing Background has not been executed
2015-05-18 08:51aferrazDescription Updatedbug_revision_view_page.php?rev_id=8556#r8556
2015-05-18 11:57hgbotCheckin
2015-05-18 11:57hgbotNote Added: 0077522
2015-05-18 11:57hgbotStatusscheduled => resolved
2015-05-18 11:57hgbotResolutionopen => fixed
2015-05-18 11:57hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/14775af5b6a0ac9017cb674f11c04a873c4dec07 [^] => http://code.openbravo.com/erp/backports/3.0PR15Q2.1/rev/cbea2f4da446c7e4808a425e51ab573180012c80 [^]
2015-05-18 11:58umartirenaReview Assigned To => umartirena
2015-05-18 11:58umartirenaNote Added: 0077524
2015-05-18 11:58umartirenaStatusresolved => closed
2015-05-18 11:58umartirenaFixed in Version => 3.0PR15Q2.1

Notes
(0077522)
hgbot   
2015-05-18 11:57   
Repository: erp/backports/3.0PR15Q2.1
Changeset: cbea2f4da446c7e4808a425e51ab573180012c80
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu May 14 17:24:16 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q2.1/rev/cbea2f4da446c7e4808a425e51ab573180012c80 [^]

Fixes issue 29889 & Fixes issue 29887: Error in Price Correction Background

IsCostCalculated will not be considered to set CheckPriceDifference flag, when completing an invoice.
Instead, when running Price Correction Background, transactions will be filtered by IsCostCalculated to avoid calculate price differences in transactions where cost has not been calculated.

---
M src-db/database/model/functions/C_INVOICE_POST.xml
M src/org/openbravo/costing/PriceDifferenceProcess.java
---
(0077524)
umartirena   
2015-05-18 11:58   
Code Review + Testing OK