Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029877Retail ModulesQuotationspublic2015-05-14 08:332015-09-25 15:30
Reporterebecerra 
Assigned Toebecerra 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029877: Quotation rejections for WebPOS
DescriptionOverview
Some improvements to quotations management in Openbravo WebPOS in order to be able to reject a quotation.

Functional requirements
The ability to reject a quotation should be granted through special permissions. Suggestion is to use a preference like in http://wiki.openbravo.com/wiki/Retail:Configuration_Guide#Security_Settings [^]
A rejected quotation in WebPOS should synch Rejected in the back office
A rejected quotation in back office won't be able to be retrieved from any WebPOS in the future.
“Reject quotation” will be a menu item just as “Convert quotation to order”.
After clicking in the menu item, a pop up will appear with rejection reasons.
A rejection reason should be selected just like in the back office. The reason values in the back office in front office should come from the same source.
These reasons will be small set (~10) so a combo is enough
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0030823 closed Orekaria Sometimes the Id of the order model is null 
Attached Filesdiff posterminal.diff (24,111) 2015-05-20 16:44
https://issues.openbravo.com/file_download.php?file_id=8102&type=bug
diff sample.data.diff (2,038) 2015-05-27 16:54
https://issues.openbravo.com/file_download.php?file_id=8130&type=bug
diff test_quotations.diff (5,593) 2015-09-08 18:48
https://issues.openbravo.com/file_download.php?file_id=8437&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-05-14 08:33ebecerraNew Issue
2015-05-14 08:33ebecerraAssigned To => ebecerra
2015-05-14 08:33ebecerraTriggers an Emergency Pack => No
2015-05-20 16:44ebecerraFile Added: posterminal.diff
2015-05-27 14:20ebecerraFile Added: test_quotations.diff
2015-05-27 16:54ebecerraFile Added: sample.data.diff
2015-09-02 14:49guillermogilReview Assigned To => marvintm
2015-09-02 15:02hgbotCheckin
2015-09-02 15:02hgbotNote Added: 0080022
2015-09-02 15:02hgbotStatusnew => resolved
2015-09-02 15:02hgbotResolutionopen => fixed
2015-09-02 15:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/936fab8641ffade6778b41347cec704b887a7e1c [^]
2015-09-02 15:03hgbotCheckin
2015-09-02 15:03hgbotNote Added: 0080023
2015-09-02 15:03hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/936fab8641ffade6778b41347cec704b887a7e1c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f91fcb42c4416470a7d01b3386b2e182ef33b2f0 [^]
2015-09-05 12:50OrekariaNote Added: 0080147
2015-09-05 12:50OrekariaStatusresolved => new
2015-09-05 12:50OrekariaResolutionfixed => open
2015-09-05 12:52hgbotCheckin
2015-09-05 12:52hgbotNote Added: 0080148
2015-09-08 18:47ebecerraFile Deleted: test_quotations.diff
2015-09-08 18:48ebecerraFile Added: test_quotations.diff
2015-09-14 18:04hgbotCheckin
2015-09-14 18:04hgbotNote Added: 0080386
2015-09-15 08:01guillermogilRelationship addedrelated to 0030823
2015-09-15 14:58OrekariaStatusnew => scheduled
2015-09-15 14:58OrekariaStatusscheduled => resolved
2015-09-15 14:58OrekariaFixed in Version => RR15Q4
2015-09-15 14:58OrekariaResolutionopen => fixed
2015-09-25 15:30marvintmStatusresolved => closed

Notes
(0080022)
hgbot   
2015-09-02 15:02   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: 936fab8641ffade6778b41347cec704b887a7e1c
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Wed Sep 02 08:37:32 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/936fab8641ffade6778b41347cec704b887a7e1c [^]

Fixed issue 29877: Added Reject Reason Sampledata

---
A referencedata/sampledata/The_White_Valley_Group/C_REJECT_REASON.xml
---
(0080023)
hgbot   
2015-09-02 15:03   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f91fcb42c4416470a7d01b3386b2e182ef33b2f0
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Wed Sep 02 08:36:22 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f91fcb42c4416470a7d01b3386b2e182ef33b2f0 [^]

Fixed issue 29877: Quotation rejections for WebPOS

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M web/org.openbravo.retail.posterminal/js/components/menu.js
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
A src/org/openbravo/retail/posterminal/QuotationsReject.java
A src/org/openbravo/retail/posterminal/term/RejectReason.java
A web/org.openbravo.retail.posterminal/js/components/modalrejectquotation.js
---
(0080147)
Orekaria   
2015-09-05 12:50   
in Oracle, the test is failing:

 org.openbravo.test.mobile.retail.pack.selenium.tests.sales.RejectQuotations.test
 Error Details

Expected: "UE"
     but: was "CJ"


Analyze why the value is not updated in the server or is not updated when the quotation is rejected (maybe a runsynchprocess is required?)
(0080148)
hgbot   
2015-09-05 12:52   
Repository: tools/automation/pi-mobile
Changeset: 338d729c18d7885e0fd75f82974dc63456aaac47
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sat Sep 05 12:52:18 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/338d729c18d7885e0fd75f82974dc63456aaac47 [^]

Related to issue 29877: Deactivated 'RejectQuotations' until the fix is ready

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/RejectQuotations.java
---
(0080386)
hgbot   
2015-09-14 18:04   
Repository: tools/automation/pi-mobile
Changeset: 1adf7fcd4e03d3024fedf1e4f782d91d91dbf9c7
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Mon Sep 14 18:04:15 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/1adf7fcd4e03d3024fedf1e4f782d91d91dbf9c7 [^]

Related to issue 29877: Quotation rejections for WebPOS

Better logic for Reject Quotation Tests

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/RejectQuotations.java
---