Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029872Openbravo ERP07. Sales managementpublic2015-05-13 17:382015-09-16 02:20
Reporterguillermogil 
Assigned Toguillermogil 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029872: Add the Payment status in sales order window
DescriptionIt could be nice to have the percent of the Payment in sales order window
It could be shown on grid and on the toolbar in form view (like invoice status)
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0030760 new Triage Platform Base It would be a good idea to disable by default sorting and filtering of computed columns 
related to defect 00308253.0PR16Q1 closed caristu Show in Status Bar doesn't honour the Active = N flag 
Attached Filespng Screenshot from 2015-05-13 17:39:31.png (60,779) 2015-05-13 17:40
https://issues.openbravo.com/file_download.php?file_id=8083&type=bug
png

diff paymentStatus.diff (8,619) 2015-05-14 16:45
https://issues.openbravo.com/file_download.php?file_id=8087&type=bug
diff paymentStatusTests.diff (11,566) 2015-05-28 16:51
https://issues.openbravo.com/file_download.php?file_id=8132&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-05-13 17:38guillermogilNew Issue
2015-05-13 17:38guillermogilAssigned To => guillermogil
2015-05-13 17:38guillermogilModules => Core
2015-05-13 17:38guillermogilTriggers an Emergency Pack => No
2015-05-13 17:40guillermogilFile Added: Screenshot from 2015-05-13 17:39:31.png
2015-05-14 16:45guillermogilFile Added: paymentStatus.diff
2015-05-20 17:24guillermogilFile Added: testPaymentStatus.diff
2015-05-28 16:50guillermogilFile Deleted: testPaymentStatus.diff
2015-05-28 16:51guillermogilFile Added: paymentStatusTests.diff
2015-08-27 10:21hgbotCheckin
2015-08-27 10:21hgbotNote Added: 0079769
2015-08-27 10:21hgbotStatusnew => resolved
2015-08-27 10:21hgbotResolutionopen => fixed
2015-08-27 10:21hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/fba0bdc5a8289513a6cfd71ddac00c2c938307a2 [^]
2015-08-27 11:07AugustoMauchNote Added: 0079772
2015-08-27 17:02hudsonbotCheckin
2015-08-27 17:02hudsonbotNote Added: 0079781
2015-08-31 10:56AugustoMauchNote Edited: 0079772bug_revision_view_page.php?bugnote_id=0079772#r9294
2015-09-04 09:08AugustoMauchRelationship addedrelated to 0030760
2015-09-09 13:36hgbotCheckin
2015-09-09 13:36hgbotNote Added: 0080278
2015-09-09 13:38vmromanosReview Assigned To => vmromanos
2015-09-09 13:38vmromanosNote Added: 0080279
2015-09-09 13:38vmromanosStatusresolved => closed
2015-09-09 23:11hudsonbotCheckin
2015-09-09 23:11hudsonbotNote Added: 0080300
2015-09-15 11:37vmromanosRelationship addedrelated to 0030825
2015-09-15 12:01lorenzofidalgoNote Added: 0080400
2015-09-15 12:12hgbotCheckin
2015-09-15 12:12hgbotNote Added: 0080401
2015-09-16 02:20hudsonbotCheckin
2015-09-16 02:20hudsonbotNote Added: 0080424

Notes
(0079769)
hgbot   
2015-08-27 10:21   
Repository: erp/devel/pi
Changeset: fba0bdc5a8289513a6cfd71ddac00c2c938307a2
Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
Date: Thu Aug 27 10:20:53 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/fba0bdc5a8289513a6cfd71ddac00c2c938307a2 [^]

Fixed issue 29872.Added computed column to show paid percentage.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0079772)
AugustoMauch   
2015-08-27 11:07   
(edited on: 2015-08-31 10:56)
Computed columns can potentially perform very poorly in high volume environments, specially when the grid is filtered and sorted using the computed column.

Before closing this issue this should be tested in a high volume environment.
(0079781)
hudsonbot   
2015-08-27 17:02   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/aa1822be5622 [^]
Maturity status: Test
(0080278)
hgbot   
2015-09-09 13:36   
Repository: erp/devel/pi
Changeset: fd369e6a038303e2bc833c76bf9c422a7b4fac4b
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Sep 09 13:35:01 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/fd369e6a038303e2bc833c76bf9c422a7b4fac4b [^]

Related to issue 29872: Deactivated the field for 15Q4

Due to the terrible impact both sorting and filtering by this field have for the performance, we have decided to deactivate this field for 15Q4, and to think about a generalistic way to deactivate the filtering and sorting for this field (and others) in 16Q1

---
M src-db/database/sourcedata/AD_FIELD.xml
---
(0080279)
vmromanos   
2015-09-09 13:38   
The field has been deactivated for 15Q4, as the filtering and sorting have a great impact in performance.

In 16Q1 we will think about a generalist way to avoid filtering and sorting for this field and others.
(0080300)
hudsonbot   
2015-09-09 23:11   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/35a1eec70785 [^]
Maturity status: Test
(0080400)
lorenzofidalgo   
2015-09-15 12:01   
"Payment status" has generated several problems. For now, it will not be shown and it has been delayed. So, for now, tests will not check that field.
(0080401)
hgbot   
2015-09-15 12:12   
Repository: erp/devel/pi
Changeset: f8a6e3e544bfb582b4c65408999e372fc4b1797d
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Sep 15 12:11:05 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f8a6e3e544bfb582b4c65408999e372fc4b1797d [^]

Related to bug 29872: Payment Status in Sales Order set as ISSHOWNINSTATUSBAR=N

This is a workaround for issue 30825, which shows this field in the Status Bar regardless it is set as Active = N

---
M src-db/database/sourcedata/AD_FIELD.xml
---
(0080424)
hudsonbot   
2015-09-16 02:20   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ab68e2868765 [^]
Maturity status: Test