Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0029861Openbravo ERP04. Warehouse managementpublic2015-05-13 12:042015-05-18 11:59
aferraz 
aferraz 
urgentmajoralways
closedfixed 
30Professional Appliance
 
3.0PR15Q33.0PR15Q3 
umartirena
Core
No
0029861: [Cost Adjutments] - Error in Price Correction Background if Costing Background has not been executed
[Cost Adjutments] - Error in Price Correction Background if Costing Background has not been executed
As QA Testing Admin:

- Create a Product with name Test for Spain organization
Add a Purchase price list version with 100 unit/list price

- Create a Purchase Order with Test product and quantity 5. Book it.

- Create a Purchase Invoice, creating lines from the created order. Change the unit price to 105. Complete it.

- Create a Goods Receipt, creating lines from the created invoice. Complete it.

- Go to Process Request window and run Price Correction Background process. Realize in Process Monitor, the status of the process is Error.

The problem is that if Costing Background process has not been executed, the transaction does not have the cost calculated, and when executing the Price Correction Background a null pointer exception will be raised.
Add in processPriceDifference method in PriceDifferenceProcess class, a restriction to ensure the transactions have the cost calculated.
No tags attached.
depends on backport 00298873.0PR15Q2.1 closed aferraz [Cost Adjutments] - Error in Price Correction Background if Costing Background has not been executed 
depends on backport 00298883.0PR15Q1.4 closed aferraz [Cost Adjutments] - Error in Price Correction Background if Costing Background has not been executed 
Issue History
2015-05-13 12:04aferrazNew Issue
2015-05-13 12:04aferrazAssigned To => aferraz
2015-05-13 12:04aferrazModules => Core
2015-05-13 12:04aferrazTriggers an Emergency Pack => No
2015-05-13 12:05aferrazSummaryError in Price Correction Background if Consting Background has not been executed => [Cost Adjutments] - Error in Price Correction Background if Consting Background has not been executed
2015-05-13 12:05aferrazDescription Updatedbug_revision_view_page.php?rev_id=8536#r8536
2015-05-14 13:47hgbotCheckin
2015-05-14 13:47hgbotNote Added: 0077445
2015-05-14 13:47hgbotStatusnew => resolved
2015-05-14 13:47hgbotResolutionopen => fixed
2015-05-14 13:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/14775af5b6a0ac9017cb674f11c04a873c4dec07 [^]
2015-05-14 16:55aferrazStatusresolved => new
2015-05-14 16:55aferrazResolutionfixed => open
2015-05-14 16:56aferrazStatusnew => scheduled
2015-05-14 16:57aferrazStatusscheduled => resolved
2015-05-14 16:57aferrazFixed in Version => 3.0PR15Q3
2015-05-14 16:57aferrazResolutionopen => fixed
2015-05-16 05:21hudsonbotCheckin
2015-05-16 05:21hudsonbotNote Added: 0077508
2015-05-18 08:51aferrazSummary[Cost Adjutments] - Error in Price Correction Background if Consting Background has not been executed => [Cost Adjutments] - Error in Price Correction Background if Costing Background has not been executed
2015-05-18 08:51aferrazDescription Updatedbug_revision_view_page.php?rev_id=8554#r8554
2015-05-18 11:59umartirenaReview Assigned To => umartirena
2015-05-18 11:59umartirenaNote Added: 0077525
2015-05-18 11:59umartirenaStatusresolved => closed

Notes
(0077445)
hgbot   
2015-05-14 13:47   
Repository: erp/devel/pi
Changeset: 14775af5b6a0ac9017cb674f11c04a873c4dec07
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed May 13 12:11:18 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/14775af5b6a0ac9017cb674f11c04a873c4dec07 [^]

Fixes issue 29701 & Fixes issue 29861: Error in Price Correction Background

IsCostCalculated will not be considered to set CheckPriceDifference flag, when completing an invoice.
Instead, when running Price Correction Background, transactions will be filtered by IsCostCalculated to avoid calculate price differences in transactions where cost has not been calculated.

---
M src-db/database/model/functions/C_INVOICE_POST.xml
M src/org/openbravo/costing/PriceDifferenceProcess.java
---
(0077508)
hudsonbot   
2015-05-16 05:21   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/33b0ebaa36ae [^]
Maturity status: Test
(0077525)
umartirena   
2015-05-18 11:59   
Code Review + Testing OK