Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029857Openbravo ERPA. Platformpublic2015-05-12 18:252015-06-01 10:10
Reporterjonalegriaesarte 
Assigned ToNaroaIriarte 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q3Fixed in Version3.0PR15Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029857: Linked items section in Accounting Transactions Details section is not working. It is in "Loading data" status forever
DescriptionLinked items section in Accounting Transactions Details section is not working. It is Loading data forever. It happens also in other windows, like Sales and Purchase invoices, depending on the environment (we can provide one)
Steps To Reproduce- Access to Accounting Transactions Details window
- Select one record
- Access to Linked Items section
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-05-12 18:25jonalegriaesarteNew Issue
2015-05-12 18:25jonalegriaesarteAssigned To => platform
2015-05-12 18:25jonalegriaesarteModules => Core
2015-05-12 18:25jonalegriaesarteResolution time => 1433455200
2015-05-12 18:25jonalegriaesarteTriggers an Emergency Pack => No
2015-05-12 18:26jonalegriaesarteSummaryLinked items section in Accounting Transactions Details section is not working. It is Loading data forever => Linked items section in Accounting Transactions Details section is not working. It is in "Loading data" status forever
2015-05-13 08:22alostaleNote Added: 0077363
2015-05-13 08:22alostaleStatusnew => acknowledged
2015-05-25 10:26heccamIssue Monitored: heccam
2015-05-26 13:14alostaleStatusacknowledged => scheduled
2015-05-26 13:14alostaleAssigned Toplatform => NaroaIriarte
2015-05-28 14:56NaroaIriarteIssue Monitored: alostale
2015-05-28 14:56NaroaIriarteReview Assigned To => alostale
2015-05-28 16:21hgbotCheckin
2015-05-28 16:21hgbotNote Added: 0077871
2015-05-28 16:21hgbotStatusscheduled => resolved
2015-05-28 16:21hgbotResolutionopen => fixed
2015-05-28 16:21hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1c6069a0eafafd4614edad9642e7b8e5cfb86dd1 [^]
2015-05-28 23:19hudsonbotCheckin
2015-05-28 23:19hudsonbotNote Added: 0077880
2015-06-01 10:08alostaleNote Added: 0077918
2015-06-01 10:08alostaleStatusresolved => closed
2015-06-01 10:10alostaleFixed in Version => 3.0PR15Q3

Notes
(0077363)
alostale   
2015-05-13 08:22   
This issue happens whenever there is no linked item. Though the response is correctly an empty json array [], it is not properly rendered in the linked items widget.
(0077871)
hgbot   
2015-05-28 16:21   
Repository: erp/devel/pi
Changeset: 1c6069a0eafafd4614edad9642e7b8e5cfb86dd1
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Thu May 28 16:19:09 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1c6069a0eafafd4614edad9642e7b8e5cfb86dd1 [^]

Fixed issue 29857: When there are not linked items it appears "Loading"

When there are no linked items, the linked items category section shows the message "Loading data..."
instead of the message "No items to show".

The problem was that the fact of not having any item category was not correctly handled.
In the initWidget function, when the linkedItemCategoryListGrid is created, in the function "dataArrived"
there was a condition which called the function that showed the correct message "No items to show" when the
startRow was '0' and when de endRow was '-1', the problem was that in this case of not having any linked Item
category, the endRow and the startRow where both '0', so, the correct message was never shown and it always shows
the message "Loading data...".
To fix this, the condition has been changed, now it is taking into account the length of the data, and if it
is '0' that means that there are not linked items so, the message "No items to show" is shown.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-linked-items.js
---
(0077880)
hudsonbot   
2015-05-28 23:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a95a68264f41 [^]
Maturity status: Test
(0077918)
alostale   
2015-06-01 10:08   
code reviewed

tested linked items both with records without linked items (in this case it correctly shows "No items to show" message and with linked items which shows them correctly.