Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029855Openbravo ERPA. Platformpublic2015-05-12 16:292021-02-05 07:42
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR21Q2 
Merge Request Statusmerged
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029855: ant validate modules reads excludeFilter.xml from wrong folder
DescriptionRunning test from issue 29854 shows following problems on top of the functional issue reported in 29854:

[validateModules] java.io.FileNotFoundException: /home/huehner/ob/branches/pi_pg/src/src-db/database/model/excludeFilter.xml (No such file or directory)
[validateModules] at java.io.FileInputStream.open(Native Method)
[validateModules] at java.io.FileInputStream.<init>(FileInputStream.java:146)
[validateModules] at org.apache.commons.digester.Digester.parse(Digester.java:1741)
[validateModules] at org.apache.ddlutils.io.DatabaseIO.readExcludedObjects(DatabaseIO.java:556)
[validateModules] at org.apache.ddlutils.platform.ExcludeFilter.fillFromFile(ExcludeFilter.java:104)
[validateModules] at org.openbravo.ddlutils.util.DBSMOBUtil.getExcludeFilter(DBSMOBUtil.java:1101)
[validateModules] at org.openbravo.service.system.SystemValidationTask.doExecute(SystemValidationTask.java:88)
[validateModules] at org.openbravo.dal.core.DalInitializingTask.execute(DalInitializingTask.java:120)

Checking path carefully shows that it uses wrong path construction

src/src-db/...

instead of just

src-db/...

Probably side-effect of build.xml::validate.modules calling src/build.xml::validate.modules so having base path inside src
Steps To Reproduceant validate.modules -Dmodule=org.openbravo.service.json
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00298543.0PR15Q4 closed caristu Weld,integration.google & json modules does not pass 'ant validate.modules' 
related to defect 00306803.0PR16Q3 closed alostale Weld module does not pass 'ant validate.modules' 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-05-12 16:29shuehnerNew Issue
2015-05-12 16:29shuehnerAssigned To => platform
2015-05-12 16:29shuehnerOBNetwork customer => No
2015-05-12 16:29shuehnerModules => Core
2015-05-12 16:29shuehnerTriggers an Emergency Pack => No
2015-05-12 16:29shuehnerRelationship addedrelated to 0029854
2015-05-12 16:33shuehnerNote Added: 0077344
2015-05-13 08:23alostaleStatusnew => acknowledged
2015-08-26 14:34caristuRelationship addedrelated to 0030680
2021-02-04 17:28hgbotMerge Request Status => open
2021-02-04 17:28hgbotNote Added: 0125983
2021-02-05 07:29hgbotMerge Request Statusopen => merged
2021-02-05 07:29hgbotNote Added: 0126001
2021-02-05 07:29hgbotResolutionopen => fixed
2021-02-05 07:29hgbotStatusacknowledged => resolved
2021-02-05 07:29hgbotFixed in Version => PR21Q2
2021-02-05 07:29hgbotNote Added: 0126004
2021-02-05 07:42alostaleAssigned Toplatform => shuehner
2021-02-05 07:42alostaleReview Assigned To => alostale
2021-02-05 07:42alostaleStatusresolved => closed

Notes
(0077344)
shuehner   
2015-05-12 16:33   
Note: when working around this apparently still some other NPE happens:
[validateModules] java.lang.NullPointerException
[validateModules] at org.openbravo.ddlutils.util.DBSMOBUtil.getExcludeFilter(DBSMOBUtil.java:1104)
[validateModules] at org.openbravo.service.system.SystemValidationTask.doExecute(SystemValidationTask.java:88)
[validateModules] at org.openbravo.dal.core.DalInitializingTask.execute(DalInitializingTask.java:120)
(0125983)
hgbot   
2021-02-04 17:28   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/304 [^]
(0126001)
hgbot   
2021-02-05 07:29   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/304 [^]
(0126004)
hgbot   
2021-02-05 07:29   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: add93934a5dc3edb120914515cac96917cee2432
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-02-04T17:17:13+01:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/add93934a5dc3edb120914515cac96917cee2432 [^]

Fixes ISSUE-29855. Remove broken ant validate.modules task

That does did not work properly since at least 2015.
The same validation is also run:
- via the junit task SystemValidatorTest.testModulesValidation
  (in there for all modules marked as InDevelopment)
- Also package.module by default runs the same validation yet again

---
M build.xml
M src/build.xml
---