Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029849Openbravo ERPA. Platformpublic2015-05-12 12:052015-05-21 09:19
Reporteregoitz 
Assigned Toalostale 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR15Q3 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029849: Not possible to overwrite the result of a callout from your own callout using a requestdispatcher an a decorator
Description-Not possible to overwrite the result of a callout from your own callout using a requestdispatcher an a decorator.
Steps To Reproduce-Using the attachemed modules change the partner of a sales order.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0027244 closed alostale Tomcat 7 is not supported 
related to design defect 0032189 closed inigosanchez Make the callouts extensible 
related to defect 0036192 closed platform Not possible to overwrite the result of a callout from your own callout using a requestdispatcher an a decorator in Tomcat 7 
Attached Filesgz callout.tar.gz (19,056) 2015-05-12 12:05
https://issues.openbravo.com/file_download.php?file_id=8073&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-05-12 12:05egoitzNew Issue
2015-05-12 12:05egoitzAssigned To => platform
2015-05-12 12:05egoitzFile Added: callout.tar.gz
2015-05-12 12:05egoitzModules => Core
2015-05-12 12:05egoitzResolution time => 1431640800
2015-05-12 12:05egoitzTriggers an Emergency Pack => No
2015-05-13 08:25alostaleRelationship addedrelated to 0027244
2015-05-13 13:40alostaleAssigned Toplatform => alostale
2015-05-13 13:51alostaleReview Assigned To => AugustoMauch
2015-05-13 13:52hgbotCheckin
2015-05-13 13:52hgbotNote Added: 0077381
2015-05-13 13:52hgbotStatusnew => resolved
2015-05-13 13:52hgbotResolutionopen => fixed
2015-05-13 13:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d142537185dc7a9164b96d860f4529c027dc6afa [^]
2015-05-14 17:48hudsonbotCheckin
2015-05-14 17:48hudsonbotNote Added: 0077456
2015-05-21 09:19AugustoMauchNote Added: 0077608
2015-05-21 09:19AugustoMauchStatusresolved => closed
2015-05-21 09:19AugustoMauchFixed in Version => 3.0PR15Q3
2016-02-26 14:15alostaleRelationship addedrelated to 0032189
2017-06-07 13:59maiteRelationship addedrelated to 0036192

Notes
(0077381)
hgbot   
2015-05-13 13:52   
Repository: erp/devel/pi
Changeset: d142537185dc7a9164b96d860f4529c027dc6afa
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed May 13 13:50:58 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d142537185dc7a9164b96d860f4529c027dc6afa [^]

fixed bug 29849: RequestDispatcher.include deletes context from current thread

  This code:

     RequestDispatcher dispatcher = request.getRequestDispatcher(url);
     dispatcher.include(wrappedRequest, response)

  deletes context OBContext and RequestContext.

  The problem is caused because the way Tomcat internally manages it. By definition
  RequestDispatcher.include should not execute the Request filters (only the include
  ones) but they were executed causing this issue. They were executed because
  of the manner the special attribute to get the dispatch type is obtained, as
  the wrappedRequest now extends javax.servlet.http.HttpServletRequestWrapper it
  is managed differently than before when this was not the case, now type was always
  "Request" even when it should be "Include".

  The fix consists on managing getAttribute from request differently when they are
  special Tomcat internal attributes getting them from the request instead of from
  the delegate.

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/RequestContext.java
---
(0077456)
hudsonbot   
2015-05-14 17:48   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/3375171dd310 [^]
Maturity status: Test
(0077608)
AugustoMauch   
2015-05-21 09:19   
Code reviewed and verified in pi@d142537185dc