Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0029828Openbravo ERP09. Financial managementpublic2015-05-08 12:312015-05-11 17:13
psanjuan 
vmromanos 
immediateminoralways
closedfixed 
20Ubuntu 8.04.1
 
3.0PR15Q1.43.0PR15Q1.4 
Sandrahuguet
Core
No
0029828: Open/Close Period Control window should only shown the calendars associated to an Organization
Open/Close Period Control window should only shown the calendars associated to an Organization
Go to Fiscal Calendar window
Create a new one called "Calendario España Test" for F&B España org (this organization already has a calendar assined in the "Organization" window).
Go to Year and create 2014 year.
Go to periods tab and create them (Periods) by using the process button "Create Periods".
Process completes successfully.

Go to Open/Close Period Control window and realize that the new calendar created is shown there. Select it and select all those periods. Try to open them.

Realize that those periods cannot be opened, realize that those periods do not have any document assigned and its status will always remains as "Mixed".

Above scenario is confusing.

Open/Close period control window should only show calendars assigned to Organizations set as ready, because once an organization is set as ready, calendar option turns to read-only, it can not be changed.
Approved
blocks defect 0029823 closed vmromanos Open/Close Period Control window should only shown the calendars associated to an Organization 
Issue History
2015-05-08 12:49vmromanosTypedefect => backport
2015-05-08 12:49vmromanosTarget Version => 3.0PR15Q1.4
2015-05-08 14:22dmitry_mezentsevTag Attached: Approved
2015-05-11 17:09SandrahuguetNote Added: 0077296
2015-05-11 17:09SandrahuguetStatusscheduled => resolved
2015-05-11 17:09SandrahuguetFixed in Version => 3.0PR15Q1.4
2015-05-11 17:09SandrahuguetFixed in SCM revision => https://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/3e8342709c19 [^]
2015-05-11 17:09SandrahuguetResolutionopen => fixed
2015-05-11 17:13SandrahuguetReview Assigned To => Sandrahuguet
2015-05-11 17:13SandrahuguetNote Added: 0077297
2015-05-11 17:13SandrahuguetStatusresolved => closed

Notes
(0077296)
Sandrahuguet   
2015-05-11 17:09   
Repository: erp/backports/3.0PR15Q1.4
Changeset: 3e8342709c1978c13af4f8d5bb628535976aadea
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri May 08 14:02:09 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/3e8342709c1978c13af4f8d5bb628535976aadea [^] [^]

Fixed bug 29828: Open/Close Period Control shows calendars associated to organizations

The Open/Close Period Control window was showing all the periods available at the C_Period table.
The target of this window is to open/close periods in fiscal calendars, so it should only show periods belonging to a fiscal calendar linked to an organization set as ready.

The fix has 2 parts:
1. Added a hql where clause to include only periods belonging to a fiscal calendar linked to an organization set as ready.
2. The hql filter clause was wrong because it was filtering by the c_period.ad_org_id. Instead it should be filtering by the organization linked to the calendar's periods

---
M src-db/database/sourcedata/AD_TAB.xml
(0077297)
Sandrahuguet   
2015-05-11 17:13   
Code review + testing OK