Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0029817 | Openbravo ERP | Z. Others | public | 2015-05-07 18:18 | 2015-05-12 17:40 |
|
| Reporter | ngarcia | |
| Assigned To | aferraz | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | pi | |
| Merge Request Status | |
| Review Assigned To | umartirena |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0029817: Two invoices with the same document number are grouped when adding a payment |
| Description | Two invoices with the same document number are grouped when adding a payment. They cannot be paid separately |
| Steps To Reproduce | As group admin role:
Create a Sales Invoice and complete it
Create another Sales Invoice header with the same values of the previous one (same document number too) but different document type and complete it
Add a payment to it and check the outstanding amount is the sum of both invoices' total
Repeat the process for the purchase flow and check it is wrong too |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2015-05-07 18:18 | ngarcia | New Issue | |
| 2015-05-07 18:18 | ngarcia | Assigned To | => Triage Finance |
| 2015-05-07 18:18 | ngarcia | Modules | => Core |
| 2015-05-07 18:18 | ngarcia | Resolution time | => 1433973600 |
| 2015-05-07 18:18 | ngarcia | Triggers an Emergency Pack | => No |
| 2015-05-07 18:20 | ngarcia | Issue Monitored: networkb | |
| 2015-05-08 10:16 | aferraz | Status | new => scheduled |
| 2015-05-08 10:16 | aferraz | Assigned To | Triage Finance => aferraz |
| 2015-05-08 12:41 | aferraz | Note Added: 0077230 | |
| 2015-05-11 17:56 | hgbot | Checkin | |
| 2015-05-11 17:56 | hgbot | Note Added: 0077301 | |
| 2015-05-11 17:56 | hgbot | Status | scheduled => resolved |
| 2015-05-11 17:56 | hgbot | Resolution | open => fixed |
| 2015-05-11 17:56 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/bb2bb339df34f1b46d2adfbcca855947ff9e8670 [^] |
| 2015-05-11 17:58 | umartirena | Review Assigned To | => umartirena |
| 2015-05-11 17:58 | umartirena | Note Added: 0077302 | |
| 2015-05-11 17:58 | umartirena | Status | resolved => closed |
| 2015-05-11 17:58 | umartirena | Fixed in Version | => pi |
| 2015-05-12 17:40 | hudsonbot | Checkin | |
| 2015-05-12 17:40 | hudsonbot | Note Added: 0077348 | |
|
Notes |
|
|
|
Test plan:
As group admin role:
Create a Sales Invoice and complete it
Create another Sales Invoice header with the same values of the previous one (same document number too) but different document type and complete it
Add a payment to it and check the outstanding amount is correct (the amount of the second invoice only)
Repeat the same flow for Purchase Invoice, Sales Order and Purchase Order |
|
|
|
(0077301)
|
|
hgbot
|
|
2015-05-11 17:56
|
|
Repository: erp/devel/pi
Changeset: bb2bb339df34f1b46d2adfbcca855947ff9e8670
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri May 08 12:32:19 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/bb2bb339df34f1b46d2adfbcca855947ff9e8670 [^]
Fixes issue 29817: Invoices with same documentno are grouped in Add Payment
Query in AddPaymentOrderInvoicesTransformer has been changed in order to take into account id and documenttype in the group by clause.
DocumentNo was taking into account but not id nor documenttype. Then, when there were two orders/invoices with the same documentno but different documenttypes, they were grouped in the Order/Invoice grid in Add Payment process.
Id group by has been added also to avoid grouping orders/invoices with the same documentno and documenttype.
---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/hqlinjections/AddPaymentOrderInvoicesTransformer.java
---
|
|
|
|
(0077302)
|
|
umartirena
|
|
2015-05-11 17:58
|
|
Code Review + Testing OK
Issue tested in:
* Sales/Purchase Order windows
* Sales/Purchase Invoice windows
* Payment In/Out windows |
|
|
|
|
|