Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029783Retail ModulesWeb POSpublic2015-05-05 17:042015-09-18 13:52
Reportermalsasua 
Assigned Tomario_castello 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in VersionRR15Q4 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029783: wrong position of currency symbol in the payment limit message
DescriptionIn the payment limit message, when the currency symbol is configured to be displayed at the left of the amount, in this message, always is displayed at the right of amount
Steps To ReproduceLog into the WebPOS
In the console, execute this line:

   OB.MobileApp.model.get('payments')[2].paymentMethod.maxLimitAmount = 10

In the ticket, add products that exceed 10 amount

Pay it with USA cash

the message displayed is:
"The maximum limit (10 $) for this payment method has been exceeded. Payment not allowed"
and it should be
"The maximum limit ($ 10) for this payment method has been exceeded. Payment not allowed"
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0029553RR15Q3 closed Orekaria When the payment limit message is printed, we use a specific condition for euro currency 
Attached Filespng issue29783.png (205,326) 2015-05-05 17:05
https://issues.openbravo.com/file_download.php?file_id=8054&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2015-05-05 17:04malsasuaNew Issue
2015-05-05 17:04malsasuaAssigned To => Retail
2015-05-05 17:04malsasuaTriggers an Emergency Pack => No
2015-05-05 17:05malsasuaFile Added: issue29783.png
2015-05-05 17:05malsasuaRelationship addedrelated to 0029553
2015-05-05 17:09malsasuaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=8445#r8445
2015-07-15 21:32hgbotCheckin
2015-07-15 21:32hgbotNote Added: 0078839
2015-07-15 21:32hgbotStatusnew => resolved
2015-07-15 21:32hgbotResolutionopen => fixed
2015-07-15 21:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/76c2a812ad1a3c8c11c31b0628cdda7e8e44ea68 [^]
2015-08-20 14:22marvintmAssigned ToRetail => Osmany
2015-08-20 14:24marvintmNote Added: 0079442
2015-08-20 14:24marvintmStatusresolved => new
2015-08-20 14:24marvintmResolutionfixed => open
2015-08-20 18:27mario_castelloAssigned ToOsmany => mario_castello
2015-09-09 17:49hgbotCheckin
2015-09-09 17:49hgbotNote Added: 0080286
2015-09-09 17:49hgbotStatusnew => resolved
2015-09-09 17:49hgbotResolutionopen => fixed
2015-09-09 17:49hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/76c2a812ad1a3c8c11c31b0628cdda7e8e44ea68 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/44fb21513cc5ae0fb70060e3e4ca252dd8cc3d16 [^]
2015-09-09 17:56hgbotCheckin
2015-09-09 17:56hgbotNote Added: 0080288
2015-09-18 11:27mtaalReview Assigned To => migueldejuana
2015-09-18 13:52migueldejuanaNote Added: 0080496
2015-09-18 13:52migueldejuanaStatusresolved => closed
2015-09-18 13:52migueldejuanaFixed in Version => RR15Q4

Notes
(0078839)
hgbot   
2015-07-15 21:32   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 76c2a812ad1a3c8c11c31b0628cdda7e8e44ea68
Author: Osmany Garcia Machado <osmany.machado <at> peoplewalking.com>
Date: Wed Jul 15 13:32:01 2015 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/76c2a812ad1a3c8c11c31b0628cdda7e8e44ea68 [^]

Fixed issue 29783: wrong position of currency symbol in the payment limit message.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0079442)
marvintm   
2015-08-20 14:24   
The solution is not correct. Instead of hardcoding the check for the dollar currency, the flag which the currency has to specify the position ("ISSYMBOLRIGHTSIDE") should be checked.
(0080286)
hgbot   
2015-09-09 17:49   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 44fb21513cc5ae0fb70060e3e4ca252dd8cc3d16
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Sep 09 09:47:30 2015 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/44fb21513cc5ae0fb70060e3e4ca252dd8cc3d16 [^]

Fixed issue 29783: Use function to show currency symbol in message

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/js/components/keypadcoins.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0080288)
hgbot   
2015-09-09 17:56   
Repository: tools/automation/pi-mobile
Changeset: 2784ecf36ebd6f97841be02fe6f9589213b0f2d2
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Tue Sep 08 18:50:57 2015 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2784ecf36ebd6f97841be02fe6f9589213b0f2d2 [^]

Related to issue 29783: Modify the verify message

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/I26881_CheckPaymentOverLimitAmount.java
---
(0080496)
migueldejuana   
2015-09-18 13:52   
Tested and reviewed in 6b56e870b9ca