Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029781Openbravo ERP09. Financial managementpublic2015-04-08 19:082015-05-07 11:09
Reportercaristu 
Assigned ToSandrahuguet 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0PR15Q1.4Fixed in Version3.0PR15Q1.4 
Merge Request Status
Review Assigned Toumartirena
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2014-06-19
Regression introduced in release3.0PR14Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/f94f08e02e3a [^]
Triggers an Emergency PackNo
Summary0029781: The done button appears disabled when it should not under some circumstances in Add Payment window
DescriptionThe done button appears disabled when it should not under some circumstances in Add Payment window.

The done button is disabled when not all the mandatory fields are populated, taking this into account, it is possible to follow some steps that makes this mechanism to detect that the overpayment action is not populated when it is hidden.

This causes the disabling of the Done button when it should not.
Steps To Reproduce1) Create a new Sales Order for the "Restaurantes Luna Llena, S.A." business partner
2) Create a line with one unit of product "Agua Sin Gas 1L"
3) Book it
4) Go to the [Payment In] window and create one record in the header, with Received From: Restaurantes Luna Llena, S.A. and amount: 1
5) Click in "Add Details" button. If there are not invoices to pay, the overpayment action field will appear. Leave it empty.
6) Switch the Transaction Type to "Orders". The order created previously is selected by default, with the amount set, so the Done button should be enabled. But it is disabled.
In order to disable we just need to write in the actual payment field

This behavior can be reproduced following other flows.
Proposed SolutionThe mandatory hidden fields should not be considered by the Done button disabling logic when they are not populated.
Additional Information
TagsApproved
Relationships
blocks defect 00295323.0PR15Q3 closed Sandrahuguet The done button appears disabled when it should not under some circumstances in Add Payment window 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-05-05 16:46SandrahuguetTypedefect => backport
2015-05-05 16:46SandrahuguetTarget Version3.0PR15Q3 => 3.0PR15Q1.4
2015-05-05 17:43dmitry_mezentsevTag Attached: Approved
2015-05-06 13:05SandrahuguetNote Added: 0077052
2015-05-06 13:43SandrahuguetReview Assigned To => umartirena
2015-05-06 13:43SandrahuguetPrioritynormal => immediate
2015-05-07 11:08hgbotCheckin
2015-05-07 11:08hgbotNote Added: 0077078
2015-05-07 11:08hgbotStatusscheduled => resolved
2015-05-07 11:08hgbotResolutionopen => fixed
2015-05-07 11:08hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/c9e385eb135a7ac4fc22bf93241231d2e04475f7 [^]
2015-05-07 11:08hgbotCheckin
2015-05-07 11:08hgbotNote Added: 0077079
2015-05-07 11:08hgbotCheckin
2015-05-07 11:08hgbotNote Added: 0077081
2015-05-07 11:09umartirenaNote Added: 0077082
2015-05-07 11:09umartirenaStatusresolved => closed
2015-05-07 11:09umartirenaFixed in Version => 3.0PR15Q1.4

Notes
(0077052)
Sandrahuguet   
2015-05-06 13:05   
Test Plan:

Create a new Sales Order for the "Restaurantes Luna Llena, S.A." business partner
Create a line with one unit of product "Agua Sin Gas 1L"
Book it
Go to Payment In window and create one record in the header, with Received From: Restaurantes Luna Llena, S.A. and amount: 1
Click in "Add Details" button. If there are not invoices to pay, the overpayment action field will appear. Leave it empty.
Switch the Transaction Type to "Orders". The order created previously is selected by default, with the amount set
Done button should be enabled
(0077078)
hgbot   
2015-05-07 11:08   
Repository: erp/backports/3.0PR15Q1.4
Changeset: c9e385eb135a7ac4fc22bf93241231d2e04475f7
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Wed May 06 11:09:24 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/c9e385eb135a7ac4fc22bf93241231d2e04475f7 [^]

Fixed bug 29781 The done button appears disabled when it should not

null parameter when it should be the view in recalcDisplayLogicOrReadOnlyLogic
call in updateDifference function

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0077079)
hgbot   
2015-05-07 11:08   
Repository: erp/backports/3.0PR15Q1.4
Changeset: 25f4b95b3cd959e03698d7cb5201fd7a9b2edf9b
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Wed May 06 17:33:29 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/25f4b95b3cd959e03698d7cb5201fd7a9b2edf9b [^]

related to issue 29781 apply js beautifier

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0077081)
hgbot   
2015-05-07 11:08   
Repository: erp/backports/3.0PR15Q1.4
Changeset: 93add9f3ed51c498d7bb8acba783fea2ae4e7582
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Wed May 06 18:01:12 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/93add9f3ed51c498d7bb8acba783fea2ae4e7582 [^]

related to issue 28971, related to issue 29781

handleButtonsStatus function does not exist in q1

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0077082)
umartirena   
2015-05-07 11:09   
Code Review + Testing OK