Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0029780Openbravo ERP09. Financial managementpublic2015-04-08 19:082015-05-08 12:54
caristu 
Sandrahuguet 
immediateminoralways
closedfixed 
5
pi 
3.0PR15Q2.13.0PR15Q2.1 
umartirena
Core
Production - Confirmed Stable
2014-06-19
3.0PR14Q3
https://code.openbravo.com/erp/devel/pi/rev/f94f08e02e3a [^]
No
0029780: The done button appears disabled when it should not under some circumstances in Add Payment window
The done button appears disabled when it should not under some circumstances in Add Payment window.

The done button is disabled when not all the mandatory fields are populated, taking this into account, it is possible to follow some steps that makes this mechanism to detect that the overpayment action is not populated when it is hidden.

This causes the disabling of the Done button when it should not.
1) Create a new Sales Order for the "Restaurantes Luna Llena, S.A." business partner
2) Create a line with one unit of product "Agua Sin Gas 1L"
3) Book it
4) Go to the [Payment In] window and create one record in the header, with Received From: Restaurantes Luna Llena, S.A. and amount: 1
5) Click in "Add Details" button. If there are not invoices to pay, the overpayment action field will appear. Leave it empty.
6) Switch the Transaction Type to "Orders". The order created previously is selected by default, with the amount set, so the Done button should be enabled. But it is disabled.
In order to disable we just need to write in the actual payment field

This behavior can be reproduced following other flows.
The mandatory hidden fields should not be considered by the Done button disabling logic when they are not populated.
Approved
blocks defect 00295323.0PR15Q3 closed Sandrahuguet The done button appears disabled when it should not under some circumstances in Add Payment window 
Issue History
2015-05-05 16:46SandrahuguetTypedefect => backport
2015-05-05 16:46SandrahuguetTarget Version3.0PR15Q3 => 3.0PR15Q2.1
2015-05-05 17:43dmitry_mezentsevTag Attached: Approved
2015-05-06 13:05SandrahuguetNote Added: 0077051
2015-05-06 13:43SandrahuguetPrioritynormal => immediate
2015-05-06 13:43SandrahuguetReview Assigned To => umartirena
2015-05-08 12:53hgbotCheckin
2015-05-08 12:53hgbotNote Added: 0077231
2015-05-08 12:53hgbotStatusscheduled => resolved
2015-05-08 12:53hgbotResolutionopen => fixed
2015-05-08 12:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q2.1/rev/91d01b8f8436ba6ee1e08d38c731002b919e639a [^]
2015-05-08 12:54umartirenaNote Added: 0077232
2015-05-08 12:54umartirenaStatusresolved => closed
2015-05-08 12:54umartirenaFixed in Version => 3.0PR15Q2.1

Notes
(0077051)
Sandrahuguet   
2015-05-06 13:05   
Test Plan:

Create a new Sales Order for the "Restaurantes Luna Llena, S.A." business partner
Create a line with one unit of product "Agua Sin Gas 1L"
Book it
Go to Payment In window and create one record in the header, with Received From: Restaurantes Luna Llena, S.A. and amount: 1
Click in "Add Details" button. If there are not invoices to pay, the overpayment action field will appear. Leave it empty.
Switch the Transaction Type to "Orders". The order created previously is selected by default, with the amount set
Done button should be enabled
(0077231)
hgbot   
2015-05-08 12:53   
Repository: erp/backports/3.0PR15Q2.1
Changeset: 91d01b8f8436ba6ee1e08d38c731002b919e639a
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Wed May 06 11:09:24 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q2.1/rev/91d01b8f8436ba6ee1e08d38c731002b919e639a [^]

Fixed bug 29780 The done button appears disabled when it should not

null parameter when it should be the view in recalcDisplayLogicOrReadOnlyLogic
call in updateDifference function

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0077232)
umartirena   
2015-05-08 12:54   
Code Review + Testing OK