Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029774Retail ModulesCash uppublic2015-05-05 11:322015-05-28 09:28
Reportermalsasua 
Assigned Tomalsasua 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionRR15Q3Fixed in VersionRR15Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029774: [cashup refactor] improve the performance of cashup
DescriptionChange the way that the invoices created in the cashup are inserted in database:
instead of to do an insert of one record by one record, the inserts are done with insert select, so the performance is better

Project: http://wiki.openbravo.com/wiki/Projects:CashUp_Improve_Performance [^]
Steps To Reproducen/a
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0029002 closed malsasua Performance problem doing concurrent cash ups 
causes defect 0030174RR15Q3 closed mtaal Triggers temporarily disabled for whole application through webpos 
causes defect 0031820 closed ranjith_qualiantech_com Duplicated invoice lines are added to an invoice during the cash up if the order line is already invoiced in more than one line 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-05-05 11:32malsasuaNew Issue
2015-05-05 11:32malsasuaAssigned To => Retail
2015-05-05 11:32malsasuaTriggers an Emergency Pack => No
2015-05-05 12:02malsasuaDescription Updatedbug_revision_view_page.php?rev_id=8434#r8434
2015-05-05 14:05hgbotCheckin
2015-05-05 14:05hgbotNote Added: 0077009
2015-05-05 14:05hgbotStatusnew => resolved
2015-05-05 14:05hgbotResolutionopen => fixed
2015-05-05 14:05hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3e3be280c7ca6fa14de6d864558f32dd98a06159 [^]
2015-05-05 15:56hgbotCheckin
2015-05-05 15:56hgbotNote Added: 0077014
2015-05-06 11:12hgbotCheckin
2015-05-06 11:12hgbotNote Added: 0077046
2015-05-06 11:12hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3e3be280c7ca6fa14de6d864558f32dd98a06159 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f3caa1b60a50ea3e1184f83e1b6878088028571e [^]
2015-05-06 14:13malsasuaAssigned ToRetail => malsasua
2015-05-07 10:19malsasuaRelationship addedrelated to 0029002
2015-05-07 16:30hgbotCheckin
2015-05-07 16:30hgbotNote Added: 0077096
2015-05-07 16:30hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f3caa1b60a50ea3e1184f83e1b6878088028571e [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/28882912b8a6ff4ae005af22a5b3783323579105 [^]
2015-05-07 18:51malsasuaDescription Updatedbug_revision_view_page.php?rev_id=8476#r8476
2015-05-12 11:08hgbotCheckin
2015-05-12 11:08hgbotNote Added: 0077327
2015-05-12 11:08hgbotCheckin
2015-05-12 11:08hgbotNote Added: 0077328
2015-05-25 10:11hgbotCheckin
2015-05-25 10:11hgbotNote Added: 0077685
2015-05-25 10:11hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/28882912b8a6ff4ae005af22a5b3783323579105 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e5228d71126f3cd8a21d57c1f5ccda7689e025fa [^]
2015-05-25 12:59hgbotCheckin
2015-05-25 12:59hgbotNote Added: 0077708
2015-05-25 13:00marvintmReview Assigned To => marvintm
2015-05-25 13:00marvintmStatusresolved => closed
2015-05-25 13:00marvintmFixed in Version => RR15Q3
2015-05-28 09:28hgbotCheckin
2015-05-28 09:28hgbotNote Added: 0077853
2015-06-15 08:26alostaleRelationship addedcauses 0030174
2016-01-26 19:51dmitry_mezentsevRelationship addedcauses 0031820

Notes
(0077009)
hgbot   
2015-05-05 14:05   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3e3be280c7ca6fa14de6d864558f32dd98a06159
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Tue May 05 14:04:32 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3e3be280c7ca6fa14de6d864558f32dd98a06159 [^]

[cashup refactor] fixed issue 29774: changed the way that the records are inserted in the database

---
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor.java
A src/org/openbravo/retail/posterminal/OrderGroupingProcessor_data.xsql
---
(0077014)
hgbot   
2015-05-05 15:56   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 411a1e9884622bb8070f283ec744e5604d7ca5c4
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Tue May 05 15:55:59 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/411a1e9884622bb8070f283ec744e5604d7ca5c4 [^]

[cashup refactor] related to issue 29774: updated text license

---
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor_data.xsql
---
(0077046)
hgbot   
2015-05-06 11:12   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f3caa1b60a50ea3e1184f83e1b6878088028571e
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Wed May 06 11:11:39 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f3caa1b60a50ea3e1184f83e1b6878088028571e [^]

[cashup refactor] fixed issue 29774: orders in cashup are not filtered by terminalId, only is filtered by cashupId

---
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor.java
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor_data.xsql
---
(0077096)
hgbot   
2015-05-07 16:30   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 28882912b8a6ff4ae005af22a5b3783323579105
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Tue May 12 16:29:17 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/28882912b8a6ff4ae005af22a5b3783323579105 [^]

[cashup refactor] fixed issue 29774: changed 'group by' expression, removing constant sting

---
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor.java
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor_data.xsql
---
(0077327)
hgbot   
2015-05-12 11:08   
Repository: tools/automation/pi-mobile
Changeset: c1c04ba1c3a5953acbc10e4d1d956be53cb390db
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Tue May 05 14:21:23 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/c1c04ba1c3a5953acbc10e4d1d956be53cb390db [^]

Related to issue 29530, verifies issue 29774: cashup refactor] improve the performance of cashup

---
M src-test/org/openbravo/test/mobile/common/selenium/database/InvoiceLinesOfDocumentnoRow.java
M src-test/org/openbravo/test/mobile/common/selenium/database/WebPOSDatabaseConstants.java
M src-test/org/openbravo/test/mobile/common/selenium/database/WebPOSDatabaseHelper.java
M src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
M src-test/org/openbravo/test/mobile/common/selenium/testhelpers/WebPOSSnippet.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/Layaway_Cre1Fin1.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/Layaway_Cre1Fin2.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/Layaway_Cre1Par2Fin1.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/Layaway_Cre1Par2Fin2.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/Layaway_Cre1Par2Fin3.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashUpGroupingWithDifferentsBP.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashUpNoGroupingWithDifferentsBP.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashUpSplitLines.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashUpSplitLinesNotIncludeTaxes.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashUpWithPartialPaidCredit.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashUpWithTotalPaidCredit.java
---
(0077328)
hgbot   
2015-05-12 11:08   
Repository: tools/automation/pi-mobile
Changeset: bb9819cf007e6b307d6f7c086a6da6eb0fd4aba7
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Mon May 11 18:27:17 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/bb9819cf007e6b307d6f7c086a6da6eb0fd4aba7 [^]

verified issue 29774: removed unused variables

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashUpGroupingWithDifferentsBP.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashUpNoGroupingWithDifferentsBP.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashUpSplitLines.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashUpSplitLinesNotIncludeTaxes.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashUpWithPartialPaidCredit.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashUpWithTotalPaidCredit.java
---
(0077685)
hgbot   
2015-05-25 10:11   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e5228d71126f3cd8a21d57c1f5ccda7689e025fa
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Mon May 25 10:10:35 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e5228d71126f3cd8a21d57c1f5ccda7689e025fa [^]

[cashup refactor] fixed issue 29774: small changes in the code to do it more clear

---
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor.java
---
(0077708)
hgbot   
2015-05-25 12:59   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d5bfab028cd340c468dfa61be4875ba0a52eff7c
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon May 25 12:59:24 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d5bfab028cd340c468dfa61be4875ba0a52eff7c [^]

Related to issue 29774. Made the code safer to avoid any potential collision.

---
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor.java
---
(0077853)
hgbot   
2015-05-28 09:28   
Repository: tools/automation/pi-mobile
Changeset: 039bb38b2e8a0df6cec4e82d3dd5ea75903a437c
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Thu May 21 20:09:46 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/039bb38b2e8a0df6cec4e82d3dd5ea75903a437c [^]

verified issue 29774:[cashup refactor] added two test cases with Multitax

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashUpSplitLinesMultitax.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashUpSplitLinesMultitaxNotIncludeTaxes.java
---