Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029751Openbravo ERPA. Platformpublic2015-04-30 16:382015-05-19 18:39
Reporterrafademiguel 
Assigned Torafademiguel 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q3Fixed in Version3.0PR15Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029751: It would be nice to have the ability to kill a background process
DescriptionIt would be nice to have the ability to kill a background process

Notes:

Only scheduled background processes will be killable (not process definitions or any other process launched from menu or window)

By default processes already developed (even background) are not killable

In order they to be killable, they will need to implement a new Java interface. This interface will have one method (kill), which will be invoked when the user wants to kill the process, the process itself should implement what is done when killing

Processes can be killed from process monitor window, a new button will be added. It will be only shown for processes that are currently in execution. If it is clicked on a process that is not killable, a message informing about this will be displayed (I'm not thinking about defining in AD if a process killable, just not to overload more the already crowded ad_process table)
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0034550 closed alostale [clustering] incorrect message when trying to kill a process in a node no executing bg processes 
related to defect 0035654 closed caristu module validation fails for killable BG processes using CDI 
related to feature request 0038360 new Triage Platform Base Ability to define the maximum duration of a background process 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-04-30 16:38rafademiguelNew Issue
2015-04-30 16:38rafademiguelAssigned To => rafademiguel
2015-04-30 16:38rafademiguelModules => Core
2015-04-30 16:38rafademiguelTriggers an Emergency Pack => No
2015-04-30 16:38rafademiguelReview Assigned To => alostale
2015-04-30 16:38rafademiguelNote Added: 0076919
2015-05-08 09:25guillermogilIssue Monitored: alostale
2015-05-08 11:07hgbotCheckin
2015-05-08 11:07hgbotNote Added: 0077224
2015-05-08 11:07hgbotStatusnew => resolved
2015-05-08 11:07hgbotResolutionopen => fixed
2015-05-08 11:07hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/58b343938308026445ff448289f1d656fa4294ee [^]
2015-05-08 13:27hgbotCheckin
2015-05-08 13:27hgbotNote Added: 0077236
2015-05-08 15:29hgbotCheckin
2015-05-08 15:29hgbotNote Added: 0077243
2015-05-08 15:30hgbotCheckin
2015-05-08 15:30hgbotNote Added: 0077244
2015-05-08 18:59hgbotCheckin
2015-05-08 18:59hgbotNote Added: 0077252
2015-05-08 19:56hgbotCheckin
2015-05-08 19:56hgbotNote Added: 0077253
2015-05-11 21:53hudsonbotCheckin
2015-05-11 21:53hudsonbotNote Added: 0077308
2015-05-14 15:01hgbotCheckin
2015-05-14 15:01hgbotNote Added: 0077447
2015-05-15 09:23alostaleNote Added: 0077478
2015-05-15 09:23alostaleStatusresolved => closed
2015-05-15 09:23alostaleFixed in Version => 3.0PR15Q3
2015-05-16 05:21hudsonbotCheckin
2015-05-16 05:21hudsonbotNote Added: 0077509
2015-05-19 10:48hgbotCheckin
2015-05-19 10:48hgbotNote Added: 0077568
2015-05-19 18:39hudsonbotCheckin
2015-05-19 18:39hudsonbotNote Added: 0077590
2016-11-17 10:09alostaleRelationship addedrelated to 0034550
2017-09-06 13:03caristuRelationship addedrelated to 0035654
2018-04-13 09:48caristuRelationship addedrelated to 0038360

Notes
(0076919)
rafademiguel   
2015-04-30 16:38   
https://code.openbravo.com/erp/devel/pi-killprocess [^]
(0077224)
hgbot   
2015-05-08 11:07   
Repository: erp/devel/pi
Changeset: 58b343938308026445ff448289f1d656fa4294ee
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Fri May 08 09:07:19 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/58b343938308026445ff448289f1d656fa4294ee [^]

Fixed issue 29751: Kill Process

Merge with kill process branch

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_PROCESS.xml
M modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_PROCESS.xml
M modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_PROCESS.xml
M modules/org.openbravo.utility.cleanup.log/src-db/database/sourcedata/AD_PROCESS.xml
M src-db/database/model/tables/AD_PROCESS.xml
M src-db/database/model/views/AD_PROCESS_EXECUTION_V.xml
M src-db/database/sourcedata/AD_AUXILIARINPUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_PROCESS.xml
M src-db/database/sourcedata/OBUIAPP_PROCESS.xml
M src/org/openbravo/scheduling/DefaultJob.java
M src/org/openbravo/service/system/DatabaseValidator.java
M src/org/openbravo/service/system/SystemValidationResult.java
A src/org/openbravo/common/actionhandler/KillProcess.java
A src/org/openbravo/scheduling/KillableProcess.java
---
(0077236)
hgbot   
2015-05-08 13:27   
Repository: erp/pmods/org.openbravo.retail.config
Changeset: 79eb9de019a3f55236ef3f1955da595d5333bad5
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Fri May 08 13:26:36 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.config/rev/79eb9de019a3f55236ef3f1955da595d5333bad5 [^]

Related to issue 29751: Kill Process

missing ISKILLABLE

---
M src-db/database/sourcedata/AD_PROCESS.xml
---
(0077243)
hgbot   
2015-05-08 15:29   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f9cb42460805c88dc6e187fa286883e313c02935
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Fri May 08 15:28:28 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f9cb42460805c88dc6e187fa286883e313c02935 [^]

Related to issue 29751: Kill Process

missing ISKILLABLE

---
M src-db/database/sourcedata/AD_PROCESS.xml
---
(0077244)
hgbot   
2015-05-08 15:30   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 265200a88e5c24e8b0f8c71534b326bb305caf3d
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Fri May 08 15:29:50 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/265200a88e5c24e8b0f8c71534b326bb305caf3d [^]

Related to issue 29751: Kill Process

missing ISKILLABLE

---
M src-db/database/sourcedata/AD_PROCESS.xml
---
(0077252)
hgbot   
2015-05-08 18:59   
Repository: erp/mods/org.openbravo.agingbalance
Changeset: b8c2e90d9b2bc87df8ec7a01bb8cca4875bb9686
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Fri May 08 18:57:11 2015 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.agingbalance/rev/b8c2e90d9b2bc87df8ec7a01bb8cca4875bb9686 [^]

Related to issue 29751: Kill Process

missing ISKILLABLE

---
M src-db/database/sourcedata/AD_PROCESS.xml
---
(0077253)
hgbot   
2015-05-08 19:56   
Repository: erp/mods/org.openbravo.financial.cashflowforecast
Changeset: 091ad8422d3eaa32abb1881c72a64c8de34b7b9b
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Fri May 08 19:55:52 2015 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.financial.cashflowforecast/rev/091ad8422d3eaa32abb1881c72a64c8de34b7b9b [^]

Related to issue 29751: Kill Process

missing ISKILLABLE

---
M src-db/database/sourcedata/AD_PROCESS.xml
---
(0077308)
hudsonbot   
2015-05-11 21:53   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a55bc3c14e8c [^]
Maturity status: Test
(0077447)
hgbot   
2015-05-14 15:01   
Repository: erp/devel/pi
Changeset: 59aad1232b8974f38186841c6a7d128f5ff918d9
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu May 14 14:59:55 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/59aad1232b8974f38186841c6a7d128f5ff918d9 [^]

ted to issue 29751: Killable processes

  Few minor enhacements:
    - When a process is killed, its status in process monitor is shown as "Killed
      by User"
    - When user clicks on "Kill Process" button change the message from "Process
      killed successfully" to "Kill signal sent to process" as sending the kill
      signal doesn't imply necessaryly the process to be successfully killed
    - Changed UI message levels when "Kill Process" button is clicked:
        - If signal is sent: from success to info
        - If process does not implement KillableProcess: from info to warn
    - Added ProcessBundle to KillableProcess.kill method so process instance's
      information can be accessed (ie. allows to add extra log when killing the
      process)

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/common/actionhandler/KillProcess.java
M src/org/openbravo/scheduling/DefaultJob.java
M src/org/openbravo/scheduling/KillableProcess.java
M src/org/openbravo/scheduling/Process.java
M src/org/openbravo/scheduling/ProcessMonitor.java
---
(0077478)
alostale   
2015-05-15 09:23   
code reviewed + tested
(0077509)
hudsonbot   
2015-05-16 05:21   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/33b0ebaa36ae [^]
Maturity status: Test
(0077568)
hgbot   
2015-05-19 10:48   
Repository: erp/devel/pi
Changeset: 709ae0d647125d58c810c4fb741aa5c45f500dfb
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue May 19 10:47:47 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/709ae0d647125d58c810c4fb741aa5c45f500dfb [^]

related to issue 29751: fixed success status when executing bg processes

  When a background process finsished successfully its status was incorrectly
  set to error instead of success

---
M src/org/openbravo/scheduling/ProcessMonitor.java
---
(0077590)
hudsonbot   
2015-05-19 18:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/877209d1525b [^]
Maturity status: Test