Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029727Openbravo ERP09. Financial managementpublic2015-01-18 23:172015-04-29 20:19
Reporterrjapoova 
Assigned Toeduardo_Argal 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0PR14Q4 
Target Version3.0PR15Q1.4Fixed in Version3.0PR15Q1.4 
Merge Request Status
Review Assigned Toumartirena
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date
Regression introduced in release3.0PR14Q4
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029727: Pressing Cancel in Match Statement or in Process Reconciliation does not trigger a refresh
DescriptionIn the Financial Account transactions window you can start a reconciliation flow with the Match Statement window.

That window has two buttons: Done (complete the process) and Cancel (abandon the process).

Given that cancel does not return the system in its previous state and that transactions might have been created in the background (see issue 28667), when you Cancel, the system should refresh the screen otherwise the created transactions are not visible to the user.

The same applies to the Confirm Process Reconciliation window.

This is very confusing and a source of many errors.
Steps To ReproduceSee video:
https://drive.google.com/file/d/0B2uCUQlrOPvINlU3VUxNNnJpYVU/view?usp=sharing [^]
Proposed SolutionPlease notice that if issue 28667 is resolved, this issue is not relevant since cancelling will not result in any new transaction.
Additional Information
TagsApproved
Relationships
blocks defect 0028668 closed eduardo_Argal Pressing Cancel in Match Statement or in Process Reconciliation does not trigger a refresh 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-04-28 19:33eduardo_ArgalTypedefect => backport
2015-04-28 19:33eduardo_ArgalTarget Version => 3.0PR15Q1.4
2015-04-29 18:51hgbotCheckin
2015-04-29 18:51hgbotNote Added: 0076886
2015-04-29 18:51hgbotStatusscheduled => resolved
2015-04-29 18:51hgbotResolutionopen => fixed
2015-04-29 18:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/5350a15536746adfbcf958b001477f741cbfc1cf [^]
2015-04-29 18:53umartirenaReview Assigned To => umartirena
2015-04-29 18:53umartirenaNote Added: 0076887
2015-04-29 18:53umartirenaStatusresolved => closed
2015-04-29 18:53umartirenaFixed in Version => 3.0PR15Q1.4
2015-04-29 20:19dmitry_mezentsevTag Attached: Approved

Notes
(0076886)
hgbot   
2015-04-29 18:51   
Repository: erp/backports/3.0PR15Q1.4
Changeset: 5350a15536746adfbcf958b001477f741cbfc1cf
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Wed Apr 29 16:51:01 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/5350a15536746adfbcf958b001477f741cbfc1cf [^]

Fixes issue 29727: Pressing Cancel in Match Statement or in Process Reconciliation does not trigger a refresh.
Cancel button has been removed as it was considered confusing. Now there are two buttons, one for closing the window called 'OK', as it was before, and another one called 'Reconcile'.

Both triggers refresh. Messages have been added to improve user understanding on how the window works. New message to inform the user any change will be persisted. This message can be disabled once clear and will not popup again. Message to run algorithm as well improved.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_ELEMENT.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_REFERENCE.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_REF_LIST.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementActionHandler.java
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-matchStatement.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
A modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadGetPreferenceActionHandler.java
A modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadPreferenceActionHandler.java
---
(0076887)
umartirena   
2015-04-29 18:53   
Code Review + Testing OK