Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029717Retail ModulesWeb POSpublic2015-04-28 15:192015-05-20 21:51
ReporterOrekaria 
Assigned ToOrekaria 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q3 
Merge Request Status
Review Assigned Tomalsasua
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029717: Log the state and requirements' state of the Pay button
DescriptionLog the state and requirements' state of the Pay button
Steps To ReproduceNA
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0029625 closed Retail Error in iPad, Synchronization Helper doesn't enable total button 
blocks defect 0029716RR15Q3 closed Retail Stabilization: RR15Q3 log related additions 
Attached Filespatch 4735.patch (5,925) 2015-05-20 21:51
https://issues.openbravo.com/file_download.php?file_id=8104&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-04-28 15:19OrekariaNew Issue
2015-04-28 15:19OrekariaAssigned To => Orekaria
2015-04-28 15:19OrekariaTriggers an Emergency Pack => No
2015-04-28 15:20OrekariaRelationship addedblocks 0029625
2015-04-28 15:20OrekariaRelationship addedblocks 0029716
2015-04-28 15:24hgbotCheckin
2015-04-28 15:24hgbotNote Added: 0076832
2015-04-28 15:24hgbotStatusnew => resolved
2015-04-28 15:24hgbotResolutionopen => fixed
2015-04-28 15:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c3bb568404ddcf8442d673c37123dd5d81cc1783 [^]
2015-04-28 15:38OrekariaSummaryAdd log to report the state and requirement states of the Pay button => Log the state and requirements' state of the Pay button
2015-04-28 15:38OrekariaDescription Updatedbug_revision_view_page.php?rev_id=8358#r8358
2015-04-28 15:38OrekariaFile Added: 4678.patch
2015-04-29 11:07hgbotCheckin
2015-04-29 11:07hgbotNote Added: 0076859
2015-04-29 11:07hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c3bb568404ddcf8442d673c37123dd5d81cc1783 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/90557a61924bc88c215d7e8a2ba182411ceeca41 [^]
2015-04-29 11:11OrekariaFile Added: 29717_posterminal.patch
2015-04-29 11:11OrekariaFile Deleted: 4678.patch
2015-04-29 11:12OrekariaFile Added: 29717_posterminal_logToInfo.patch
2015-05-06 14:10malsasuaNote Added: 0077055
2015-05-06 14:11malsasuaStatusresolved => new
2015-05-06 14:11malsasuaResolutionfixed => open
2015-05-07 14:35hgbotCheckin
2015-05-07 14:35hgbotNote Added: 0077094
2015-05-07 14:35hgbotStatusnew => resolved
2015-05-07 14:35hgbotResolutionopen => fixed
2015-05-07 14:35hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/90557a61924bc88c215d7e8a2ba182411ceeca41 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fcb8c6510ca3d517e4b9f88cb2bd7a0c0392d5cc [^]
2015-05-08 14:57malsasuaReview Assigned To => malsasua
2015-05-08 14:57malsasuaNote Added: 0077241
2015-05-08 14:57malsasuaStatusresolved => closed
2015-05-08 14:57malsasuaFixed in Version => RR15Q3
2015-05-20 21:47OrekariaFile Deleted: 29717_posterminal.patch
2015-05-20 21:47OrekariaFile Deleted: 29717_posterminal_logToInfo.patch
2015-05-20 21:51OrekariaFile Added: 4735.patch

Notes
(0076832)
hgbot   
2015-04-28 15:24   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c3bb568404ddcf8442d673c37123dd5d81cc1783
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Tue Apr 28 15:24:12 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c3bb568404ddcf8442d673c37123dd5d81cc1783 [^]

Fixes issue 29717: Log the state and the requirements' state of the pay button

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0076859)
hgbot   
2015-04-29 11:07   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 90557a61924bc88c215d7e8a2ba182411ceeca41
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Wed Apr 29 11:07:01 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/90557a61924bc88c215d7e8a2ba182411ceeca41 [^]

Fixes issue 29717: Log the state and the requirements' state of the pay button (II)

- some of the values could be null, the 'OB.UTIL.isNullOrUndefined' method has been used
- beautifier applied

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0077055)
malsasua   
2015-05-06 14:10   
two things that could be useful:
. identifier of receipt could be included in the log trace
. the log trace only should be displayed when the status is wrong (for example, receiptId is not null, and exist lines)
(0077094)
hgbot   
2015-05-07 14:35   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: fcb8c6510ca3d517e4b9f88cb2bd7a0c0392d5cc
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Thu May 07 14:25:37 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fcb8c6510ca3d517e4b9f88cb2bd7a0c0392d5cc [^]

Fixes issue 29717: Changes to the log and actions regarding the pay button state:

- an error will be logged if the button is expected to be enabled and it is not
- while in development, an error will be risen if the button is expected to be enabled and it is not
- the receiptId, docno and receiptBpId are shown in the log message

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0077241)
malsasua   
2015-05-08 14:57   
verified