Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0029705Openbravo ERP09. Financial managementpublic2015-04-24 19:292015-04-29 20:38
dmitry_mezentsev 
jorge-garcia 
urgenttrivialalways
closedfixed 
5
pi 
3.0PR15Q1.43.0PR15Q1.4 
umartirena
Core
Production - Confirmed Stable
3.0PR14Q4
No
0029705: Description field is filled in with "null" in the FA Transaction when matched to GL Item
Description field is filled in with "null" in the FA Transaction when matched to GL Item, see steps to reproduce
live.builds.pi

1. Go to FA Bank - Account 1.
2. Create and Process bank statement with one line selecting any GL Item.
3. Run Match Statement process. It does not find any transaction so press Add Transaction (+) and Save it keeping defaults (mention that GL Item is defaulted to the value from the Bank Statement Line).
4. Cancel or Process Reconciliation.
5. Refresh transaction lines so that created transaction appears. Mention that its Description contains "null" while should contain "GL Item: <Name>".
Approved
blocks defect 0029697 closed jorge-garcia Description field is filled in with "null" in the FA Transaction when matched to GL Item 
Issue History
2015-04-27 13:14jorge-garciaTypedefect => backport
2015-04-27 13:14jorge-garciaTarget Version => 3.0PR15Q1.4
2015-04-27 13:25dmitry_mezentsevAssigned ToTriage Finance => jorge-garcia
2015-04-28 09:48jorge-garciaNote Added: 0076807
2015-04-28 12:28hgbotCheckin
2015-04-28 12:28hgbotNote Added: 0076823
2015-04-28 12:28hgbotStatusscheduled => resolved
2015-04-28 12:28hgbotResolutionopen => fixed
2015-04-28 12:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/40f30cb8d1eb58f732510fd050ddf00601611ba6 [^]
2015-04-28 12:41umartirenaReview Assigned To => umartirena
2015-04-28 12:41umartirenaNote Added: 0076825
2015-04-28 12:41umartirenaStatusresolved => closed
2015-04-28 12:41umartirenaFixed in Version => 3.0PR15Q1.4
2015-04-29 20:38dmitry_mezentsevTag Attached: Approved

Notes
(0076807)
jorge-garcia   
2015-04-28 09:48   
Test Plan:

1. Go to FA Bank - Account 1.
2. Create and Process bank statement with one line selecting any GL Item.
3. Run Match Statement process. It does not find any transaction so press Add Transaction (+) and Save it keeping defaults (mention that GL Item is defaulted to the value from the Bank Statement Line).
4. Cancel or Process Reconciliation.
5. Refresh transaction lines so that created transaction appears. Check that its Description contains "GL Item: <Name>".
(0076823)
hgbot   
2015-04-28 12:28   
Repository: erp/backports/3.0PR15Q1.4
Changeset: 40f30cb8d1eb58f732510fd050ddf00601611ba6
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Apr 28 10:02:52 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/40f30cb8d1eb58f732510fd050ddf00601611ba6 [^]

Fixed issue 29705: Description field is set with "null" in the FA Transaction

Description field is filled in with "null" in the FA Transaction when matched
to GL Item.

The problem was in the Match Statement process, more specifically, in the
Add new transaction button. The AddTransanctionActionHandler didn't
take in consideration that the received description could be null.

The fix for this issue is to check if the received description is null
or blank.

Now, the description field fill in the correct description.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddTransactionActionHandler.java
---
(0076825)
umartirena   
2015-04-28 12:41   
Code Review + Testing OK