Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029704Openbravo ERP09. Financial managementpublic2015-04-24 19:292015-04-28 12:42
Reporterdmitry_mezentsev 
Assigned Tojorge-garcia 
PriorityurgentSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0PR15Q2Fixed in Version3.0PR15Q2 
Merge Request Status
Review Assigned Toumartirena
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date
Regression introduced in release3.0PR14Q4
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029704: Description field is filled in with "null" in the FA Transaction when matched to GL Item
DescriptionDescription field is filled in with "null" in the FA Transaction when matched to GL Item, see steps to reproduce
Steps To Reproducelive.builds.pi

1. Go to FA Bank - Account 1.
2. Create and Process bank statement with one line selecting any GL Item.
3. Run Match Statement process. It does not find any transaction so press Add Transaction (+) and Save it keeping defaults (mention that GL Item is defaulted to the value from the Bank Statement Line).
4. Cancel or Process Reconciliation.
5. Refresh transaction lines so that created transaction appears. Mention that its Description contains "null" while should contain "GL Item: <Name>".
Proposed Solution
Additional Information
TagsApproved
Relationships
blocks defect 0029697 closed jorge-garcia Description field is filled in with "null" in the FA Transaction when matched to GL Item 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-04-27 13:14jorge-garciaTypedefect => backport
2015-04-27 13:14jorge-garciaTarget Version => 3.0PR15Q2
2015-04-27 13:24dmitry_mezentsevTag Attached: Approved
2015-04-27 13:25dmitry_mezentsevAssigned ToTriage Finance => jorge-garcia
2015-04-28 09:48jorge-garciaNote Added: 0076806
2015-04-28 12:37hgbotCheckin
2015-04-28 12:37hgbotNote Added: 0076824
2015-04-28 12:37hgbotStatusscheduled => resolved
2015-04-28 12:37hgbotResolutionopen => fixed
2015-04-28 12:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q2/rev/c550fb5def49dd668fc1d3625349d4af1047a371 [^]
2015-04-28 12:42umartirenaReview Assigned To => umartirena
2015-04-28 12:42umartirenaNote Added: 0076826
2015-04-28 12:42umartirenaStatusresolved => closed
2015-04-28 12:42umartirenaFixed in Version => 3.0PR15Q2

Notes
(0076806)
jorge-garcia   
2015-04-28 09:48   
Test Plan:

1. Go to FA Bank - Account 1.
2. Create and Process bank statement with one line selecting any GL Item.
3. Run Match Statement process. It does not find any transaction so press Add Transaction (+) and Save it keeping defaults (mention that GL Item is defaulted to the value from the Bank Statement Line).
4. Cancel or Process Reconciliation.
5. Refresh transaction lines so that created transaction appears. Check that its Description contains "GL Item: <Name>".
(0076824)
hgbot   
2015-04-28 12:37   
Repository: erp/backports/3.0PR15Q2
Changeset: c550fb5def49dd668fc1d3625349d4af1047a371
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Apr 28 09:37:16 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q2/rev/c550fb5def49dd668fc1d3625349d4af1047a371 [^]

Fixed issue 29704: Description field is set with "null" in the FA Transaction

Description field is filled in with "null" in the FA Transaction when matched
to GL Item.

The problem was in the Match Statement process, more specifically, in the
Add new transaction button. The AddTransanctionActionHandler didn't
take in consideration that the received description could be null.

The fix for this issue is to check if the received description is null
or blank.

Now, the description field fill in the correct description.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddTransactionActionHandler.java
---
(0076826)
umartirena   
2015-04-28 12:42   
Code Review + Testing OK