Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029687Openbravo ERPB. User interfacepublic2015-04-23 19:352016-10-24 10:08
Reportercaristu 
Assigned Todbaz 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR15Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2014-05-15
Regression introduced in release3.0PR14Q3
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/43e598987eb706d4eac832d474b84a1d0b7ac958 [^]
Triggers an Emergency PackNo
Summary0029687: Is not possible to set the hour 12 in DateTime fields
DescriptionIs not possible to set the hour 12 in DateTime fields, it is always being converted to 0 when the field loses the focus.
Steps To Reproduce1) Go to the Work Effort window and create a new record in the header
2) Navigate to the Production Run tab
3) In the Starting Time field, type date and a hour with 12 for example: 04-23-2015 12:26:05
4) Move to another field. Notice that the Starting Time is changed to 04-23-2015 00:26:05
Proposed SolutionThe parseEditorValue method uses the OB.Utilities.Date.OBToJS which is doing this conversion waiting for a PM indicator. As this indicator is not included it then makes the replacement.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0034057 closed NaroaIriarte Wrong Tabulation Order in form fields in Organization window 
depends on backport 00296913.0PR15Q2 closed dbaz Is not possible to set the hour 12 in DateTime fields 
depends on backport 00296923.0PR15Q1.4 closed dbaz Is not possible to set the hour 12 in DateTime fields 
caused by feature request 00259363.0PR14Q3 closed dbaz DateTime reference format support hh:mm:ss a 
Attached Filesdiff fix29687.diff (1,322) 2015-04-27 15:48
https://issues.openbravo.com/file_download.php?file_id=8025&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-04-23 19:35caristuNew Issue
2015-04-23 19:35caristuAssigned To => platform
2015-04-23 19:35caristuModules => Core
2015-04-23 19:35caristuTriggers an Emergency Pack => No
2015-04-23 19:36caristuIssue Monitored: networkb
2015-04-23 19:36caristuResolution time => 1432591200
2015-04-24 08:36alostaleRelationship addedrelated to 0025936
2015-04-24 08:36alostaleStatusnew => acknowledged
2015-04-24 11:36alostaleRelationship replacedcaused by 0025936
2015-04-24 11:40alostaleRegression level => Production - Confirmed Stable
2015-04-24 11:40alostaleRegression date => 2014-05-15
2015-04-24 11:40alostaleRegression introduced in release => 3.0PR14Q3
2015-04-24 11:40alostaleRegression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/43e598987eb706d4eac832d474b84a1d0b7ac958 [^]
2015-04-24 11:40alostaleAssigned Toplatform => dbaz
2015-04-24 11:40alostalePrioritynormal => immediate
2015-04-24 11:40alostaleSeveritymajor => minor
2015-04-24 11:43alostaleStatusacknowledged => scheduled
2015-04-27 15:48dbazFile Added: fix29687.diff
2015-04-28 12:15dbazReview Assigned To => alostale
2015-04-28 12:15hgbotCheckin
2015-04-28 12:15hgbotNote Added: 0076822
2015-04-28 12:15hgbotStatusscheduled => resolved
2015-04-28 12:15hgbotResolutionopen => fixed
2015-04-28 12:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/baf06c383c41ca564846d1d7e0ccd21f157f2c55 [^]
2015-04-29 09:30alostaleNote Added: 0076847
2015-04-29 09:30alostaleStatusresolved => closed
2015-04-29 09:30alostaleFixed in Version => 3.0PR15Q3
2015-04-29 16:25hgbotCheckin
2015-04-29 16:25hgbotNote Added: 0076878
2015-04-29 18:22hgbotCheckin
2015-04-29 18:22hgbotNote Added: 0076884
2015-05-07 22:17hudsonbotCheckin
2015-05-07 22:17hudsonbotNote Added: 0077173
2015-05-07 22:17hudsonbotCheckin
2015-05-07 22:17hudsonbotNote Added: 0077184
2015-05-07 22:17hudsonbotCheckin
2015-05-07 22:17hudsonbotNote Added: 0077187
2016-10-24 10:08NaroaIriarteRelationship addedrelated to 0034057

Notes
(0076822)
hgbot   
2015-04-28 12:15   
Repository: erp/devel/pi
Changeset: baf06c383c41ca564846d1d7e0ccd21f157f2c55
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Apr 28 12:07:49 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/baf06c383c41ca564846d1d7e0ccd21f157f2c55 [^]

Fixed issue 29687: DateTime now works ok with 12:XX:XX times

The root of the problem was that there was a 'typo' and the
'minus' sign was missing in the 'if' statement in charge
of evaluate if it was in 24h mode or not. This was used later
to substract 12h to the entered date if this was in the
12:XX:XX form, change that obviously doesn't apply in the
24h mode

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities-date.js
---
(0076847)
alostale   
2015-04-29 09:30   
code reviewed

tested with 12 and 24 hour time format in grid and form views
(0076878)
hgbot   
2015-04-29 16:25   
Repository: erp/devel/pi
Changeset: 85224ff98fb5e4cb434ae5107a50df3b6ba02d0d
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Wed Apr 29 16:24:29 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/85224ff98fb5e4cb434ae5107a50df3b6ba02d0d [^]

Related to issue 29687: Added QUnit test cases

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/test/ob-utilities-date-test.js
---
(0076884)
hgbot   
2015-04-29 18:22   
Repository: erp/devel/pi
Changeset: 7c3c564c85918a61bbb4a22574303d3cb89772c3
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Wed Apr 29 18:21:34 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7c3c564c85918a61bbb4a22574303d3cb89772c3 [^]

Related to issue 29687: Added QUnit test cases - Fixed JSLint problem

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/test/ob-utilities-date-test.js
---
(0077173)
hudsonbot   
2015-05-07 22:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test
(0077184)
hudsonbot   
2015-05-07 22:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test
(0077187)
hudsonbot   
2015-05-07 22:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test