Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029683Openbravo ERPA. Platformpublic2015-04-23 16:442015-12-11 08:39
Reporterrbianchini 
Assigned Tocaristu 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version3.0PR16Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029683: web services do not filter by organization in System/Clients Entities
Descriptionweb services do not filter by organization in System/Clients Entities
Steps To Reproduce1- Login with role QA testing
2- Go to Window "Country and Regions"
3- Add a new Region for Spain (e.g: Test)
4- Connect to : https://livebuilds.openbravo.com/erp_pi_pgsql/ws/dal/Country/106 [^]
5- Notice that the result is showing data for both F&B and QA Clients, but the default role is from F&B
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
causes defect 0032584 closed inigosanchez Header tab data disappear 
causes defect 0035397 closed caristu Not possible to get on the webservice regions of a country when those are defined to client 0. 
Attached Filespng Bug.png (320,903) 2015-04-23 16:44
https://issues.openbravo.com/file_download.php?file_id=8018&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-04-23 16:44rbianchiniNew Issue
2015-04-23 16:44rbianchiniAssigned To => platform
2015-04-23 16:44rbianchiniFile Added: Bug.png
2015-04-23 16:44rbianchiniWeb browser => Google Chrome
2015-04-23 16:44rbianchiniModules => Core
2015-04-23 16:44rbianchiniTriggers an Emergency Pack => No
2015-04-24 08:26alostaleWeb browserGoogle Chrome => Google Chrome
2015-04-24 08:26alostalePrioritynormal => urgent
2015-04-24 08:26alostaleStatusnew => acknowledged
2015-11-11 11:34alostalePriorityurgent => high
2015-11-17 11:18caristuAssigned Toplatform => caristu
2015-11-17 11:18caristuStatusacknowledged => scheduled
2015-11-17 17:57caristuReview Assigned To => alostale
2015-11-17 17:57caristuWeb browserGoogle Chrome => Google Chrome
2015-11-17 17:58caristuIssue Monitored: alostale
2015-11-17 17:59hgbotCheckin
2015-11-17 17:59hgbotNote Added: 0081933
2015-11-17 17:59hgbotStatusscheduled => resolved
2015-11-17 17:59hgbotResolutionopen => fixed
2015-11-17 17:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2c0caa49fcc0792e77c29ad705fe662b1eaf12d3 [^]
2015-11-23 21:17hudsonbotCheckin
2015-11-23 21:17hudsonbotNote Added: 0082249
2015-11-27 10:50hgbotCheckin
2015-11-27 10:50hgbotNote Added: 0082413
2015-11-28 15:24hudsonbotCheckin
2015-11-28 15:24hudsonbotNote Added: 0082448
2015-11-30 09:53alostaleNote Added: 0082459
2015-11-30 09:53alostaleStatusresolved => new
2015-11-30 09:53alostaleResolutionfixed => open
2015-11-30 09:53alostaleNote Edited: 0082459bug_revision_view_page.php?bugnote_id=0082459#r10382
2015-12-01 11:35hgbotCheckin
2015-12-01 11:35hgbotNote Added: 0082481
2015-12-01 11:35caristuStatusnew => scheduled
2015-12-01 11:36caristuStatusscheduled => resolved
2015-12-01 11:36caristuResolutionopen => fixed
2015-12-02 00:10hudsonbotCheckin
2015-12-02 00:10hudsonbotNote Added: 0082510
2015-12-11 08:39alostaleNote Added: 0082669
2015-12-11 08:39alostaleStatusresolved => closed
2015-12-11 08:39alostaleFixed in Version => 3.0PR16Q1
2016-04-05 13:07inigosanchezRelationship addedcauses 0032584
2017-03-01 18:02caristuRelationship addedcauses 0035397

Notes
(0081933)
hgbot   
2015-11-17 17:59   
Repository: erp/devel/pi
Changeset: 2c0caa49fcc0792e77c29ad705fe662b1eaf12d3
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Nov 17 17:57:32 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2c0caa49fcc0792e77c29ad705fe662b1eaf12d3 [^]

fixes issue 29683: web services not filter system/client entity by client

The problem here was that system/client entities can have children properties which belongs to different clients. So it was necessary to filter the children properties by the current client also, when returning the web service results.

---
M src/org/openbravo/dal/xml/EntityXMLConverter.java
M src/org/openbravo/service/rest/DalWebService.java
---
(0082249)
hudsonbot   
2015-11-23 21:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test
(0082413)
hgbot   
2015-11-27 10:50   
Repository: erp/devel/pi
Changeset: 90a660b52e0712467ae41e4e962cae35df8997ae
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Nov 27 10:48:02 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/90a660b52e0712467ae41e4e962cae35df8997ae [^]

related to issue 29683: check client/org in web services when requesting by id

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
M src/org/openbravo/service/rest/DalWebService.java
---
(0082448)
hudsonbot   
2015-11-28 15:24   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a30fd74371da [^]
Maturity status: Test
(0082459)
alostale   
2015-11-30 09:53   
reopening because of code review for changeset 90a660b52e07:

Don't create query by concatenating strings, it can be used for HQL injection. Use parameterized query instead.
(0082481)
hgbot   
2015-12-01 11:35   
Repository: erp/devel/pi
Changeset: 1ff6e13ac85672bd37e76a86390cdd449c418c0e
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Dec 01 11:34:45 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1ff6e13ac85672bd37e76a86390cdd449c418c0e [^]

related to issue 29683: use parameterized query when requesting by id

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
M src/org/openbravo/service/rest/DalWebService.java
---
(0082510)
hudsonbot   
2015-12-02 00:10   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a52bb700bbaf [^]
Maturity status: Test
(0082669)
alostale   
2015-12-11 08:39   
code reviewed + tested