Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0029682Openbravo ERP07. Sales managementpublic2015-04-23 12:542015-05-07 22:17
ngarcia 
AtulOpenbravo 
urgentmajoralways
closedfixed 
5
 
3.0PR15Q3 
aferraz
Core
No
0029682: Repeated discount lines are introduced by Copy Lines process in Sales Invoice if same basic discount is defined for more BP
Repeated discount lines are introduced by Copy Lines process in Sales Invoice if same basic discount is defined for more BP
As group admin role:
   Define the same Basic Discount for more than one Business Partner and set is as Apply in Order (Business Partner - Basic Discount tab)
   Create a Sales Invoice for that Business Partner and book it
   Check the discount is applied
   Create a new Sales Invoice header and Copy Lines from the previously created invoice
   Check more than one discount line is created
Check the select function of the CopyFrom Invoice_data.xsql file
No tags attached.
Issue History
2015-04-23 12:54ngarciaNew Issue
2015-04-23 12:54ngarciaAssigned To => Triage Finance
2015-04-23 12:54ngarciaModules => Core
2015-04-23 12:54ngarciaResolution time => 1432504800
2015-04-23 12:54ngarciaTriggers an Emergency Pack => No
2015-04-23 12:55ngarciaIssue Monitored: networkb
2015-04-28 08:32AtulOpenbravoAssigned ToTriage Finance => AtulOpenbravo
2015-04-28 08:33AtulOpenbravoStatusnew => scheduled
2015-04-28 09:27AtulOpenbravoNote Added: 0076805
2015-05-05 19:13hgbotCheckin
2015-05-05 19:13hgbotNote Added: 0077031
2015-05-05 19:13hgbotStatusscheduled => resolved
2015-05-05 19:13hgbotResolutionopen => fixed
2015-05-05 19:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/628d66d2161bb5c25f669729f05d24954b8bd569 [^]
2015-05-05 19:13aferrazReview Assigned To => aferraz
2015-05-05 19:13aferrazNote Added: 0077032
2015-05-05 19:13aferrazStatusresolved => closed
2015-05-05 19:13aferrazFixed in Version => 3.0PR15Q3
2015-05-07 22:17hudsonbotCheckin
2015-05-07 22:17hudsonbotNote Added: 0077215

Notes
(0076805)
AtulOpenbravo   
2015-04-28 09:27   
Test Plan
- Login as group admin role:
- Define the same Basic Discount for more than one Business Partner and set is as Apply in Order (Business Partner - Basic Discount tab).
- Create a Sales Invoice for that Business Partner with one line product.
- In Sales Invoice / Discount Tab add Discount defined for the Business Partner above and book invoice. Check that discount line is added in the invoice.
- Create a new Sales Invoice header and Copy Lines from the previously created invoice.
- Check that Discount lines are created properly and not the number of times the same Basic Discount defined for the business partners as earlier.
(0077031)
hgbot   
2015-05-05 19:13   
Repository: erp/devel/pi
Changeset: 628d66d2161bb5c25f669729f05d24954b8bd569
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Apr 28 12:50:22 2015 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/628d66d2161bb5c25f669729f05d24954b8bd569 [^]

Fixes Issue 29682:Repeated discount lines are introduced by Copy Lines process
 in Sales Invoice if same basic discount is defined for more BP

There was no relation between business partner discount and business partner
while selecting records from invoice lines.

---
M src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice_data.xsql
---
(0077032)
aferraz   
2015-05-05 19:13   
Code review + Testing OK
(0077215)
hudsonbot   
2015-05-07 22:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test