Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029666Openbravo ERP04. Warehouse managementpublic2015-04-22 11:372015-05-07 22:16
ReporterVictorVillar 
Assigned Toumartirena 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0PR15Q2Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2014-08-20
Regression introduced in release3.0PR14Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/186b3f5bcf21 [^]
Triggers an Emergency PackNo
Summary0029666: Null Pointer exception of the Costing Background Process when you are creating a new costing rule (standard)
DescriptionNull Pointer exception of the Costing Background Process when you are creating a new costing rule (standard)
Steps To ReproduceAs group admin role,
 Go to Costing rule:
    create a new costing rule -> type: Standard
    Org: US
    Warehouse dimension: No
    Backdated transactions fixed: Yes (also it happens, if you do not check it)
    Fix Backdated From: Blank
Validate it.

 Go to Process Request window,
    Unschedule the costing background process
    Create a new one: Run inmediately.
Go to Process Monitor window,
   Realise that the process has 'Success' status but there is nothing in the Process Log.

The reason:
867946fe 84026822 [DefaultQuartzScheduler_Worker-8] ERROR org.openbravo.costing.CostingBackground -
java.lang.NullPointerException
    at org.openbravo.costing.StandardAlgorithm.getOpeningInventoryCost(StandardAlgorithm.java:63)
    at org.openbravo.costing.StandardAlgorithm.getTransactionCost(StandardAlgorithm.java:38)
    at org.openbravo.costing.CostingServer.process(CostingServer.java:104)
    at org.openbravo.costing.CostingBackground.doExecute(CostingBackground.java:119)
    at org.openbravo.service.db.DalBaseProcess.execute(DalBaseProcess.java:80)
    at org.openbravo.scheduling.DefaultJob.execute(DefaultJob.java:58)
    at org.quartz.core.JobRunShell.run(JobRunShell.java:202)
    at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:525)

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00296773.0PR15Q2 closed umartirena Null Pointer exception of the Costing Background Process when you are creating a new costing rule (standard) 
depends on backport 00296783.0PR15Q1.4 closed umartirena Null Pointer exception of the Costing Background Process when you are creating a new costing rule (standard) 
caused by feature request 0022855 closed dmiguelez It would be fine to have the cost adjustment functionality implemented 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-04-22 11:37VictorVillarNew Issue
2015-04-22 11:37VictorVillarAssigned To => umartirena
2015-04-22 11:37VictorVillarModules => Core
2015-04-22 11:37VictorVillarResolution time => 1432332000
2015-04-22 11:37VictorVillarRegression level => Production - QA Approved
2015-04-22 11:37VictorVillarTriggers an Emergency Pack => No
2015-04-22 18:08VictorVillarSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=8332#r8332
2015-04-22 18:13VictorVillarSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=8333#r8333
2015-04-23 10:06umartirenaRegression date => 2014-08-20
2015-04-23 10:06umartirenaRegression introduced in release => 3.0PR14Q4
2015-04-23 10:06umartirenaRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/186b3f5bcf21 [^]
2015-04-23 10:07umartirenaStatusnew => scheduled
2015-04-23 12:49dmitry_mezentsevRelationship addedcaused by 0022855
2015-04-23 12:50dmitry_mezentsevRegression levelProduction - QA Approved => Production - Confirmed Stable
2015-04-24 11:29hgbotCheckin
2015-04-24 11:29hgbotNote Added: 0076744
2015-04-24 11:29hgbotStatusscheduled => resolved
2015-04-24 11:29hgbotResolutionopen => fixed
2015-04-24 11:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/038e26600576ccd2ed3d23edaf9b91d623c8deba [^]
2015-04-24 11:31vmromanosReview Assigned To => vmromanos
2015-04-24 11:31vmromanosNote Added: 0076747
2015-04-24 11:31vmromanosStatusresolved => closed
2015-05-07 22:16hudsonbotCheckin
2015-05-07 22:16hudsonbotNote Added: 0077152

Notes
(0076744)
hgbot   
2015-04-24 11:29   
Repository: erp/devel/pi
Changeset: 038e26600576ccd2ed3d23edaf9b91d623c8deba
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Thu Apr 23 10:20:01 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/038e26600576ccd2ed3d23edaf9b91d623c8deba [^]

Fixes bug 29666: Fix NPE in Costing Background with Standard Costing Rule

In Cost Adjustment project new method has been added to calculate an opening inventory cost. This method uses 'CostinUtils.getStandardCostDefinition' method, that tries to get an standard cost for that opening inventory. If it does not found any standard or legacy cost, it returns null. So, in this moment a NPE error was happening. To fix this problem, at this point a controlled error is raised to notify the user that no cost has been found.

---
M src/org/openbravo/costing/StandardAlgorithm.java
---
(0076747)
vmromanos   
2015-04-24 11:31   
Code review + testing OK
(0077152)
hudsonbot   
2015-05-07 22:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test