Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029648ModulesSEPA Credit Transfer Customer-to-Bankpublic2015-04-21 11:222015-05-04 17:28
Reportermaite 
Assigned Tojorge-garcia 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Support ticket35736
OBNetwork customerOBPS
Regression introduced in release
Summary0029648: "BtchBookg" should not be set to FALSE as it is non-mandatory tag
Description"BtchBookg" should not be set to FALSE as it is non-mandatory tag
Steps To ReproduceObtain SEPA credit transfer file and realize that "BtchBookg" tag appears set to FALSE
Proposed SolutionpaymentInstruction.setBtchBookg(Boolean.FALSE); should be removed from:

modules/org.openbravo.sepa.iso20022.credittransfer.customertobank/src/org/openbravo/sepa/iso20022/credittransfer/customertobank/pain/x001/x001/x04/report/CreditTransfer.java

modules/org.openbravo.sepa.iso20022.credittransfer.customertobank/src/org/openbravo/sepa/iso20022/credittransfer/customertobank/pain/x001/x001/x03/report/CreditTransfer.java
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-04-21 11:22maiteNew Issue
2015-04-21 11:22maiteAssigned To => Triage Finance
2015-04-21 11:22maiteResolution time => 1432504800
2015-04-21 11:22maiteSupport ticket => 35736
2015-04-21 11:22maiteOBNetwork customer => Yes
2015-04-21 11:23maiteIssue Monitored: networkb
2015-04-24 14:08jorge-garciaStatusnew => scheduled
2015-04-24 14:08jorge-garciaAssigned ToTriage Finance => jorge-garcia
2015-04-27 12:58jorge-garciaNote Added: 0076780
2015-05-04 17:27hgbotCheckin
2015-05-04 17:27hgbotNote Added: 0076954
2015-05-04 17:27hgbotStatusscheduled => resolved
2015-05-04 17:27hgbotResolutionopen => fixed
2015-05-04 17:27hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.sepa.iso20022.credittransfer.customertobank/rev/8ad324af901cfbab77abcc9b87635ae667b34340 [^]
2015-05-04 17:27hgbotCheckin
2015-05-04 17:27hgbotNote Added: 0076955
2015-05-04 17:28vmromanosReview Assigned To => vmromanos
2015-05-04 17:28vmromanosNote Added: 0076956
2015-05-04 17:28vmromanosStatusresolved => closed

Notes
(0076780)
jorge-garcia   
2015-04-27 12:58   
Test Plan:

1. Register Remittance with remittance type "SEPA Credit Transfer Customer-to-Bank (pain.001.001.03)", add any line and process
2. Create remittance file and realize that "BtchBookg" tag doesn't appear in the SEPA credit transfer file.
3. Register Remittance with remittance type "SEPA Credit Transfer Customer-to-Bank (pain.001.001.04)", add any line and process
4. Create remittance file and realize that "BtchBookg" tag doesn't appear in the SEPA credit transfer file.
(0076954)
hgbot   
2015-05-04 17:27   
Repository: erp/pmods/org.openbravo.sepa.iso20022.credittransfer.customertobank
Changeset: 8ad324af901cfbab77abcc9b87635ae667b34340
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Apr 27 11:46:32 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.sepa.iso20022.credittransfer.customertobank/rev/8ad324af901cfbab77abcc9b87635ae667b34340 [^]

Fixed issue 29648: "BtchBookg" should not be set to FALSE

"BtchBookg" should not be set to FALSE as it is non-mandatory tag.

The solution is to remove the setter from CreditTransfer.java and now, the
BtchBookg doesn't appear in the credit transfer file.

---
M src/org/openbravo/sepa/iso20022/credittransfer/customertobank/pain/x001/x001/x03/report/CreditTransfer.java
M src/org/openbravo/sepa/iso20022/credittransfer/customertobank/pain/x001/x001/x04/report/CreditTransfer.java
---
(0076955)
hgbot   
2015-05-04 17:27   
Repository: erp/pmods/org.openbravo.sepa.iso20022.credittransfer.customertobank
Changeset: 3c8d39a89da3debc6ca4f0a34a070c6ca9f7b3ab
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon May 04 17:27:35 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.sepa.iso20022.credittransfer.customertobank/rev/3c8d39a89da3debc6ca4f0a34a070c6ca9f7b3ab [^]

Related to issue 29648: updated ad_module.UPDATEINFO

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0076956)
vmromanos   
2015-05-04 17:28   
Code review + testing OK.

It will be available in SEPA Credit Transfer Customer-to-Bank 1.0.5 (or higher)