Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029616Openbravo ERP09. Financial managementpublic2015-04-16 13:582015-05-07 22:16
Reportermaite 
Assigned Toaferraz 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q2Fixed in Version 
Merge Request Status
Review Assigned Toeduardo_Argal
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029616: Error in GLJournalAccountingCheck validation
DescriptionError in GLJournalAccountingCheck validation
Steps To ReproduceWhen exists a negative gl journal line and system is configured to "not allow negative amount" during posting, build validation fails although accounting information is correct
Proposed Solution
Additional Information
TagsApproved
Relationships
blocks defect 0029610 closed aferraz Error in GLJournalAccountingCheck validation 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-04-16 18:37aferrazTypedefect => backport
2015-04-16 18:37aferrazTarget Version => 3.0PR15Q2
2015-04-16 19:08dmitry_mezentsevAssigned ToTriage Finance => aferraz
2015-04-16 19:08dmitry_mezentsevTag Attached: Approved
2015-04-17 11:37hgbotCheckin
2015-04-17 11:37hgbotNote Added: 0076601
2015-04-17 11:37hgbotStatusscheduled => resolved
2015-04-17 11:37hgbotResolutionopen => fixed
2015-04-17 11:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q2/rev/af63dcb16553bf6446e66fcea181641b4c774988 [^]
2015-04-17 11:40eduardo_ArgalReview Assigned To => eduardo_Argal
2015-04-17 11:40eduardo_ArgalNote Added: 0076603
2015-04-17 11:40eduardo_ArgalStatusresolved => closed
2015-04-27 19:32hgbotCheckin
2015-04-27 19:32hgbotNote Added: 0076799
2015-04-27 19:32hgbotStatusclosed => resolved
2015-04-27 19:32hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/backports/3.0PR15Q2/rev/af63dcb16553bf6446e66fcea181641b4c774988 [^] => http://code.openbravo.com/erp/devel/pi/rev/39988fbbd2426ecad607882f496f7b78a9664eb2 [^]
2015-04-27 19:33eduardo_ArgalNote Added: 0076800
2015-04-27 19:33eduardo_ArgalStatusresolved => closed
2015-05-07 22:16hudsonbotCheckin
2015-05-07 22:16hudsonbotNote Added: 0077167

Notes
(0076601)
hgbot   
2015-04-17 11:37   
Repository: erp/backports/3.0PR15Q2
Changeset: af63dcb16553bf6446e66fcea181641b4c774988
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Apr 16 18:33:31 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q2/rev/af63dcb16553bf6446e66fcea181641b4c774988 [^]

Fixes issue 29616: Error in GLJournalAccountingCheck validation

Query in GLJournalAccountingCheck build validation has been changed to avoid build validation fail, when exists a negative gl journal line and system is configured to "not allow negative amount" during posting, although accounting information is correct

---
M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/GLJournalAccountingCheckData.class
M src-util/buildvalidation/src/org/openbravo/buildvalidation/GLJournalAccountingCheck_data.xsql
---
(0076603)
eduardo_Argal   
2015-04-17 11:40   
Code Reviewed and Tested.
Now alerts just thrown for the required scenarios, if those are attended then build continues as expected.

Test: update from q1, adding right and wrong data, to q2
-First test it fails
-Then test it passes
(0076799)
hgbot   
2015-04-27 19:32   
Repository: erp/devel/pi
Changeset: 39988fbbd2426ecad607882f496f7b78a9664eb2
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Apr 16 18:33:31 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/39988fbbd2426ecad607882f496f7b78a9664eb2 [^]

Fixes issue 29616: Error in GLJournalAccountingCheck validation

Query in GLJournalAccountingCheck build validation has been changed to avoid build validation fail, when exists a negative gl journal line and system is configured to "not allow negative amount" during posting, although accounting information is correct

---
M src-util/buildvalidation/src/org/openbravo/buildvalidation/GLJournalAccountingCheck_data.xsql
---
(0076800)
eduardo_Argal   
2015-04-27 19:33   
Wrong push. Entered this same number by mistake.
Issue was already resolved and closed
(0077167)
hudsonbot   
2015-05-07 22:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test