Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029519Retail ModulesWeb POSpublic2015-04-08 09:422015-04-16 13:37
Reporterjecharri 
Assigned Tomalsasua 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Toadrianromero
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029519: Created invoice in the cash up has not got the correct address
DescriptionCreated invoice in the cash up has not got the correct address, you can create an order with one address and invoice this order and it should have the same address but it is not happening that.
Steps To Reproduce-Go to Web POS
-Create an address for the BP
-Create an order
-Verify that new order has this address
-Do the cash up
-Verify that generated invoice has the first address of the possible addresses

If you check JAVA
modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/OrderGroupingProcessor.java
and you verify line
invoice.setPartnerAddress(order.getBusinessPartner().getBusinessPartnerLocationList().get(0));
you will see that we are not doing properly.


P.S.:the client needs and script to fix the wrong invoices
Proposed SolutionWe should check that the address is marked as invoicing address. Also we should think in the case where we group all the orders in one invoice. Probably we should group by BP and also might be necessary to group by address.

It is something that must be evaluated and think properly what is the solution that we want to apply.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-04-08 09:42jecharriNew Issue
2015-04-08 09:42jecharriAssigned To => Retail
2015-04-08 09:42jecharriResolution time => 1428616800
2015-04-08 09:42jecharriTriggers an Emergency Pack => No
2015-04-08 09:43jecharriSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=8192#r8192
2015-04-08 18:21hgbotCheckin
2015-04-08 18:21hgbotNote Added: 0076386
2015-04-08 18:21hgbotStatusnew => resolved
2015-04-08 18:21hgbotResolutionopen => fixed
2015-04-08 18:21hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7bff7c538c5489efc0133275604444ef0bce0943 [^]
2015-04-09 09:51hgbotCheckin
2015-04-09 09:51hgbotNote Added: 0076401
2015-04-09 09:51hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7bff7c538c5489efc0133275604444ef0bce0943 [^] => http://code.openbravo.com/retail/backports/3.0RR15Q2/org.openbravo.retail.posterminal/rev/7bff7c538c5489efc0133275604444ef0bce0943 [^]
2015-04-13 19:02marvintmAssigned ToRetail => malsasua
2015-04-16 13:37adrianromeroReview Assigned To => adrianromero
2015-04-16 13:37adrianromeroNote Added: 0076587
2015-04-16 13:37adrianromeroStatusresolved => closed

Notes
(0076386)
hgbot   
2015-04-08 18:21   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 7bff7c538c5489efc0133275604444ef0bce0943
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Wed Apr 08 18:21:30 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7bff7c538c5489efc0133275604444ef0bce0943 [^]

fixed issue 29519: added group by invoice address to order grouping process in cashup and the invoice address asigned to invoice is the invoice address of order

---
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor.java
---
(0076401)
hgbot   
2015-04-09 09:51   
Repository: retail/backports/3.0RR15Q2/org.openbravo.retail.posterminal
Changeset: 7bff7c538c5489efc0133275604444ef0bce0943
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Wed Apr 08 18:21:30 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q2/org.openbravo.retail.posterminal/rev/7bff7c538c5489efc0133275604444ef0bce0943 [^]

fixed issue 29519: added group by invoice address to order grouping process in cashup and the invoice address asigned to invoice is the invoice address of order

---
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor.java
---
(0076587)
adrianromero   
2015-04-16 13:37   
Verified