Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029503Openbravo ERPA. Platformpublic2015-04-07 10:062015-04-22 13:02
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR15Q2 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029503: [Google Sign In Module] blank g+ icon in login page
DescriptionThe sign in icon in login page that should appear when google sign in module is installed appears as blank using recent (tested with 43) chrome version.
Steps To Reproduce* Install Google Sign In module [1]
* Open Login page
  -> next to the "Sign in using:" text a g+ icon should be seen [2] but a blank square appears instead

[1] http://wiki.openbravo.com/wiki/Modules:Google_Sign_In [^]
[2] http://wiki.openbravo.com/w/images/7/7a/SignInUsingOAuth2.png [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-04-07 10:06alostaleNew Issue
2015-04-07 10:06alostaleAssigned To => alostale
2015-04-07 10:06alostaleOBNetwork customer => No
2015-04-07 10:06alostaleModules => Core
2015-04-07 10:06alostaleTriggers an Emergency Pack => No
2015-04-07 10:06alostaleReview Assigned To => dbaz
2015-04-07 10:15hgbotCheckin
2015-04-07 10:15hgbotNote Added: 0076355
2015-04-07 10:15hgbotStatusnew => resolved
2015-04-07 10:15hgbotResolutionopen => fixed
2015-04-07 10:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.integration.google.signin/rev/27c6a1f6381d7dbfcc6c423efb3e6be8f319f781 [^]
2015-04-22 09:52alostaleReview Assigned Todbaz => AugustoMauch
2015-04-22 13:02AugustoMauchNote Added: 0076687
2015-04-22 13:02AugustoMauchStatusresolved => closed
2015-04-22 13:02AugustoMauchFixed in Version => 3.0PR15Q2

Notes
(0076355)
hgbot   
2015-04-07 10:15   
Repository: erp/pmods/org.openbravo.integration.google.signin
Changeset: 27c6a1f6381d7dbfcc6c423efb3e6be8f319f781
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Apr 07 10:14:40 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.integration.google.signin/rev/27c6a1f6381d7dbfcc6c423efb3e6be8f319f781 [^]

fixed bug 29503: blank g+ icon in login page

  fixed css style for g+ icon, it was:

     background: url('../web/org.openbravo.integration.google.signin/images/signinbutton.png') 2 -18px;

  and now it is:

     background: url('../web/org.openbravo.integration.google.signin/images/signinbutton.png') 2px -18px;

---
M src/org/openbravo/integration/google/signin/button/button.ftl
---
(0076687)
AugustoMauch   
2015-04-22 13:02   
Code reviewed and verified in pi@ceb90ebdebd2