Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0029496Openbravo ERP03. Procurement managementpublic2015-04-01 17:252015-06-26 15:57
VictorVillar 
jorge-garcia 
urgentmajoralways
closedfixed 
5
 
 
vmromanos
Core
No
0029496: It is not possible to do a return to vendor using non stocked products
It is not possible to do a return to vendor using non stocked products
As group admin role,
  Go to Product window,
   create a new one
   Item: Yes
   Stocked= No
 Go to Price tab:
    select the Bebidas alegres price list
    Unit Price:2
    List price: 2
Go to Purchase order (business partner: Bebidas alegres)
   create a new one selecting the product created before.
   qty: 1
Complete it.
 Create a goods Receipt (business partner: Bebidas alegres)related with this Purchase order.
   Use 'Create Lines From' to select the product
Complete it.
 Create the Purchase Invoice (business partner: Bebidas alegres) related with this goods receipt.
Complete it.

 Go to Return to vendor window,
   create a new one (business partner: Bebidas alegres) selecting the goods receipt created before.
 Return qty: 1
Complete it.
  Go to Return to vendor shipment.
     create a new one (business partner: Bebidas alegres) selecting the return to vendor created before.
 Realise that it does not appear any register.
No tags attached.
related to defect 0032520 closed AtulOpenbravo Wrong available quantity is shown in Return To Vendor Shipment Pick and Edit when there is not stock 
Issue History
2015-04-01 17:25VictorVillarNew Issue
2015-04-01 17:25VictorVillarAssigned To => Sandrahuguet
2015-04-01 17:25VictorVillarModules => Core
2015-04-01 17:25VictorVillarResolution time => 1430431200
2015-04-01 17:25VictorVillarTriggers an Emergency Pack => No
2015-04-01 17:25VictorVillarIssue Monitored: networkb
2015-04-07 16:02jorge-garciaStatusnew => scheduled
2015-04-07 16:02jorge-garciaAssigned ToSandrahuguet => jorge-garcia
2015-04-13 09:21jorge-garciaNote Added: 0076461
2015-06-15 14:01vmromanosAssigned Tojorge-garcia => Triage Finance
2015-06-25 15:35hgbotCheckin
2015-06-25 15:35hgbotNote Added: 0078509
2015-06-25 15:35hgbotStatusscheduled => resolved
2015-06-25 15:35hgbotResolutionopen => fixed
2015-06-25 15:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a111a9e90082f9008ca2e2224436f5d260c35326 [^]
2015-06-25 15:35hgbotCheckin
2015-06-25 15:35hgbotNote Added: 0078510
2015-06-25 15:35hgbotCheckin
2015-06-25 15:35hgbotNote Added: 0078511
2015-06-25 15:35vmromanosAssigned ToTriage Finance => jorge-garcia
2015-06-25 15:36vmromanosReview Assigned To => vmromanos
2015-06-25 15:36vmromanosNote Added: 0078512
2015-06-25 15:36vmromanosStatusresolved => closed
2015-06-26 15:57hudsonbotCheckin
2015-06-26 15:57hudsonbotNote Added: 0078542
2015-06-26 15:57hudsonbotCheckin
2015-06-26 15:57hudsonbotNote Added: 0078543
2015-06-26 15:57hudsonbotCheckin
2015-06-26 15:57hudsonbotNote Added: 0078544
2017-09-28 09:40aferrazRelationship addedrelated to 0032520

Notes
(0076461)
jorge-garcia   
2015-04-13 09:21   
Test Plan:

As group admin role,
  Go to Product window,
   create a new one
   Item: Yes
   Stocked= No
 Go to Price tab:
    select the Bebidas alegres price list
    Unit Price:2
    List price: 2
Go to Purchase order (business partner: Bebidas alegres)
   create a new one selecting the product created before.
   qty: 1
Complete it.
 Create a goods Receipt (business partner: Bebidas alegres)related with this Purchase order.
   Use 'Create Lines From' to select the product
Complete it.
 Create the Purchase Invoice (business partner: Bebidas alegres) related with this goods receipt.
Complete it.

 Go to Return to vendor window,
   create a new one (business partner: Bebidas alegres) selecting the goods receipt created before.
 Return qty: 1
Complete it.
  Go to Return to vendor shipment.
     create a new one (business partner: Bebidas alegres) selecting the return to vendor created before.
 Realise that it appears the register it's just created.
(0078509)
hgbot   
2015-06-25 15:35   
Repository: erp/devel/pi
Changeset: a111a9e90082f9008ca2e2224436f5d260c35326
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Apr 09 11:00:22 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a111a9e90082f9008ca2e2224436f5d260c35326 [^]

Fixed issue 29496: Not possible to do return to vendor using non stocked product

It is not possible to do a return to vendor using non stocked products.

The Pick and Edit window didn't show order from non stocked produts caused by
a Hibernate error when creating the sql from the HQL Where Clause.

The solution is to change the HQL where clause from this window and avoid the
cross join of the m_locator table. A subselect query has been added to the
Where Clause to avoid this error.

In addition, a new constraint has been added to the HQL Where Clause and now
the products without a storage bin are shown as well.

---
M src-db/database/sourcedata/AD_TAB.xml
---
(0078510)
hgbot   
2015-06-25 15:35   
Repository: erp/devel/pi
Changeset: 3f6a959095d44c82ff089e7237f432ec37ae2e9c
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu May 07 16:18:01 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3f6a959095d44c82ff089e7237f432ec37ae2e9c [^]

Related to issue 29496: Not possible to do a return with non stocked product

Not possible to do return to vendor using non stocked product.

The problem here was that the Return to Vendor line of a non stocked product
appears in the Pick/Edit Lines window in the Return to Vendor Shipment
window, but, when selected, a error message appears and it's not possible
to done the picking.

Now, we save the property stockable of the product, and we check if the product
is non stockable. Now, the Pick/Edit Lines works fine and it is possible to
process the Return to Vendor Shipment.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/return-material/ob-return-material.js
M src-db/database/model/views/M_RM_SHIPMENT_PICK_EDIT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0078511)
hgbot   
2015-06-25 15:35   
Repository: erp/devel/pi
Changeset: 405ac3729ec74f3954b4fa361ed1f271fdaa6918
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Jun 25 15:32:39 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/405ac3729ec74f3954b4fa361ed1f271fdaa6918 [^]

Related to issue 29496: Code review improvements

Added the same AD_Element_ID to the new IsStocked column as in the Product table
Updated copyright and fixed typo

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/return-material/ob-return-material.js
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0078512)
vmromanos   
2015-06-25 15:36   
Code review + testing OK
(0078542)
hudsonbot   
2015-06-26 15:57   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/60ba8db95a9d [^]
Maturity status: Test
(0078543)
hudsonbot   
2015-06-26 15:57   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/60ba8db95a9d [^]
Maturity status: Test
(0078544)
hudsonbot   
2015-06-26 15:57   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/60ba8db95a9d [^]
Maturity status: Test