Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029481Openbravo ERP01. General setuppublic2015-03-31 17:102015-05-11 21:53
Reporteregoitz 
Assigned Toaferraz 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR15Q3 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket35371
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029481: On an environment with thousends of currency convert, inserting a new conversion takes more than a second.
DescriptionWhen inserting a conversion rate on an environment with thousends of conversion, the inserting action takes more than a second.
That happens becuase the trigger c_conversion_rate_trg2 checks if there exist more than one conversion for the same currencies on the same dates.
Steps To Reproduce-On an enviroment with more than 25.000 rows on c_conversion_rate table, insert a new conversion.

Proposed SolutionChange the trigger c_conversion_rate_trg2 to check duplicated conversion only for the currencies you are inserting/updating.
Additional Information
TagsPerformance
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-03-31 17:10egoitzNew Issue
2015-03-31 17:10egoitzAssigned To => Sandrahuguet
2015-03-31 17:10egoitzOBNetwork customer => Yes
2015-03-31 17:10egoitzModules => Core
2015-03-31 17:10egoitzSupport ticket => 35371
2015-03-31 17:10egoitzResolution time => 1430344800
2015-03-31 17:10egoitzTriggers an Emergency Pack => No
2015-03-31 17:11egoitzTag Attached: Performance
2015-04-14 12:48Triage FinanceAssigned ToSandrahuguet => Triage Finance
2015-05-06 17:54aferrazStatusnew => scheduled
2015-05-06 17:54aferrazAssigned ToTriage Finance => aferraz
2015-05-11 13:16hgbotCheckin
2015-05-11 13:16hgbotNote Added: 0077279
2015-05-11 13:16hgbotStatusscheduled => resolved
2015-05-11 13:16hgbotResolutionopen => fixed
2015-05-11 13:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/10f0bcd9165b12d0b38661287db9cc4c5e27f4ca [^]
2015-05-11 13:18SandrahuguetReview Assigned To => Sandrahuguet
2015-05-11 13:18SandrahuguetNote Added: 0077280
2015-05-11 13:18SandrahuguetStatusresolved => closed
2015-05-11 13:18SandrahuguetFixed in Version => 3.0PR15Q3
2015-05-11 21:53hudsonbotCheckin
2015-05-11 21:53hudsonbotNote Added: 0077318

Notes
(0077279)
hgbot   
2015-05-11 13:16   
Repository: erp/devel/pi
Changeset: 10f0bcd9165b12d0b38661287db9cc4c5e27f4ca
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu May 07 16:36:25 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/10f0bcd9165b12d0b38661287db9cc4c5e27f4ca [^]

Fixes issue 29481: Bad performance when inserting a new Conversion Rate

C_CONVERSION_RATE_TRG2.xml trigger has been deleted. Instead, an event handler has been added in order to check for duplicated conversions only for the currencies you are inserting/updating.
C_CONVERSION_RATE_TRG2.xml trigger was not updated because it produced mutating table error in oracle

---
A src/org/openbravo/event/ConversionRateEventHandler.java
R src-db/database/model/triggers/C_CONVERSION_RATE_TRG2.xml
---
(0077280)
Sandrahuguet   
2015-05-11 13:18   
Code review + testing OK
(0077318)
hudsonbot   
2015-05-11 21:53   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a55bc3c14e8c [^]
Maturity status: Test