Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029463Retail ModulesWeb POSpublic2015-03-30 18:202015-07-17 09:10
Reporteraaroncalero 
Assigned Tojorge-garcia 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q4Fixed in VersionRR15Q3 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029463: It is possible to give change or pay a return ticket if there is no cash available
DescriptionThe check to decide if there is enough cash to complete a sale/return is done depending on the current selected payment method.
Since credit cards are not "cash" payment methods, they skip that check, so it is possible to complete sales even if there is no cash available for change or returns.
Steps To ReproduceLogin in WebPOS
Do a cashup and don't keep anything.
Create a ticket and add a product for 100€
Tap on the total button and add cash: 110€.
Verify that the "There is not enough cash available." message appears and the Done button is disabled.
Click on Card payment method.
Verify that the Done button is enabled and the sale can be completed.
Proposed SolutionThe check to allow/disallow completing a sale should be done taking into account all current cash values and all entered payments, it shouldn't depend on the current selected payment method.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0029312 closed mario_castello A sale can be finished when there is no cash available 
causes defect 0032563 closed ranjith_qualiantech_com [SERQA 861] JS Error when you do an initial count without Cash payment method 
Attached Filesdiff Issue29463_Option1.diff (2,140) 2015-04-01 13:58
https://issues.openbravo.com/file_download.php?file_id=7954&type=bug
diff Issue29463_Option2.diff (2,719) 2015-04-01 13:58
https://issues.openbravo.com/file_download.php?file_id=7955&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-03-30 18:20aaroncaleroNew Issue
2015-03-30 18:20aaroncaleroAssigned To => aaroncalero
2015-03-30 18:20aaroncaleroTriggers an Emergency Pack => No
2015-03-30 18:20aaroncaleroRelationship addedrelated to 0029312
2015-03-30 18:21aaroncaleroAssigned Toaaroncalero => Retail
2015-03-30 19:04mario_castelloAssigned ToRetail => mario_castello
2015-04-01 13:32malsasuaAssigned Tomario_castello => Retail
2015-04-01 13:58malsasuaFile Added: Issue29463_Option1.diff
2015-04-01 13:58malsasuaFile Added: Issue29463_Option2.diff
2015-06-09 13:22malsasuaResolution time => 1436479200
2015-06-11 13:27marvintmAssigned ToRetail => jorge-garcia
2015-06-25 12:35hgbotCheckin
2015-06-25 12:35hgbotNote Added: 0078503
2015-06-25 12:35hgbotStatusnew => resolved
2015-06-25 12:35hgbotResolutionopen => fixed
2015-06-25 12:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fad40c5f7cf15a304ceca15e6bf39dff77e55ad3 [^]
2015-06-29 17:04migueldejuanaNote Added: 0078569
2015-06-29 17:04migueldejuanaStatusresolved => new
2015-06-29 17:04migueldejuanaResolutionfixed => open
2015-06-29 18:54hgbotCheckin
2015-06-29 18:54hgbotNote Added: 0078574
2015-07-01 10:09marvintmTarget VersionRR15Q3 => RR15Q4
2015-07-03 09:37hgbotCheckin
2015-07-03 09:37hgbotNote Added: 0078634
2015-07-03 09:37hgbotStatusnew => resolved
2015-07-03 09:37hgbotResolutionopen => fixed
2015-07-03 09:37hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fad40c5f7cf15a304ceca15e6bf39dff77e55ad3 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/464633dd387fd0cd4fb468d2bd62b368f5170b34 [^]
2015-07-17 09:10migueldejuanaReview Assigned To => migueldejuana
2015-07-17 09:10migueldejuanaNote Added: 0078907
2015-07-17 09:10migueldejuanaStatusresolved => closed
2015-07-17 09:10migueldejuanaFixed in Version => RR15Q3
2016-06-02 12:58dmitry_mezentsevRelationship addedcauses 0032563

Notes
(0078503)
hgbot   
2015-06-25 12:35   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: fad40c5f7cf15a304ceca15e6bf39dff77e55ad3
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Jun 25 09:37:16 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fad40c5f7cf15a304ceca15e6bf39dff77e55ad3 [^]

Fixed issue 29463: It is possible to pay a return ticket if there is no cash

It is possible to give change or pay a return ticket if there is no cash
available.

The solution is to check if there is cash to cover the overpayment. If no, the
cash payment is deleted an a warning message appears indicating that there is
not enough cash and that the cash payment has been deleted.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0078569)
migueldejuana   
2015-06-29 17:04   
There is a functionality to give change with another currency:

- Add product 100€
- Add payment 110€
- 10€ of change, but we can select $ and we would give 1,12$ change .

With this change, we cannot do this.

We should check if it is working fine in this case:

- Add product 100€
- Add payment 110€
- 10€ of change, but we can select Card and we would give 10€ change by card return.
(0078574)
hgbot   
2015-06-29 18:54   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4697eaa6e2ead1a439b7130a4d529294863b6e68
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Jun 29 18:53:20 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4697eaa6e2ead1a439b7130a4d529294863b6e68 [^]

Backout commit 4799 / issue 29463

The proposed solution doesn't fix the real problem of the issue 29463.

The problem is not that you can done a payment with no cash and the return
of change by card method, the real problem is that the data generated in this
case is not saved well in the backend.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0078634)
hgbot   
2015-07-03 09:37   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 464633dd387fd0cd4fb468d2bd62b368f5170b34
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Jul 03 09:02:45 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/464633dd387fd0cd4fb468d2bd62b368f5170b34 [^]

Fixed issue 29463: It Is possible to give change or a return ticket with no cash

Web POS doesn't support to pay the change of a transaction with a credit card.

The proposal solution is to not allow the customer to pay the change with a
credit card or pay a change with no cash.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0078907)
migueldejuana   
2015-07-17 09:10   
Tested and reviewed in 976cfed505b7