Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0029453Openbravo ERPA. Platformpublic2015-03-27 12:232015-04-08 18:40
umartirena 
alostale 
immediatemajorhave not tried
closedfixed 
5
 
3.0PR15Q1.33.0PR15Q1.3 
AugustoMauch
Core
Pre packaging ( pi )
pi
https://code.openbravo.com/erp/devel/pi/rev/9216d290b2f2 [^]
No
0029453: Process Definition popup is not closed after executing the process behind
Process Definition popup is not closed after executing the process behind. The popup keeps opened even the process finishes successfully or raises any error. So it is impossible to know what has happened.
In Live Builds:

Go to Organization window:
 * Select F&B España, S.A org and remove its currency

Go to Costing Rule window and create a new record:
 * Org: F&B España, S.A
 * Costing Algorithm: Average Algorithm
 * Select Backdated Transactions Fixed.

Save and Click on Validate Costing Rule.

Notice that the popup keeps opened forever and it does not display nor success neither error.
If look at the log you will see that the following error has been raised:

ERROR org.openbravo.base.exception.OBException - @NoCurrencyInCostingRuleOrg@
org.openbravo.base.exception.OBException: @NoCurrencyInCostingRuleOrg@
    at org.openbravo.costing.CostingRuleProcess.execute(CostingRuleProcess.java:81)
    at org.openbravo.costing.CostingRuleProcessActionHandler.doExecute(CostingRuleProcessActionHandler.java:66)
    at org.openbravo.client.application.process.BaseProcessActionHandler.execute(BaseProcessActionHandler.java:152)
    at org.openbravo.client.kernel.BaseActionHandler.execute(BaseActionHandler.java:71)
    at org.openbravo.client.kernel.KernelServlet.processActionRequest(KernelServlet.java:294)
    at org.openbravo.client.kernel.KernelServlet.doGet(KernelServlet.java:186)
    at org.openbravo.client.kernel.KernelServlet.doPost(KernelServlet.java:267)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
No tags attached.
related to backport 00294163.0PR15Q1.3 closed alostale Duplicated records in Used Credit Source tab when clicking Done more than once in Add Details pop-up 
blocks defect 0029439 closed alostale Process Definition popup is not closed after executing the process behind 
Issue History
2015-03-30 10:04alostaleTypedefect => backport
2015-03-30 10:04alostaleTarget Version => 3.0PR15Q1.3
2015-03-30 10:04alostaleRelationship addedrelated to 0029416
2015-03-30 11:53ngarciaIssue Monitored: ngarcia
2015-04-07 07:58hgbotCheckin
2015-04-07 07:58hgbotNote Added: 0076346
2015-04-07 07:58hgbotStatusscheduled => resolved
2015-04-07 07:58hgbotResolutionopen => fixed
2015-04-07 07:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q1.3/rev/7113377f5e9f3aee9e0989ebfc14369328ec3214 [^]
2015-04-07 08:00alostaleReview Assigned To => AugustoMauch
2015-04-08 18:40AugustoMauchNote Added: 0076390
2015-04-08 18:40AugustoMauchStatusresolved => closed
2015-04-08 18:40AugustoMauchFixed in Version => 3.0PR15Q1.3

Notes
(0076346)
hgbot   
2015-04-07 07:58   
Repository: erp/backports/3.0PR15Q1.3
Changeset: 7113377f5e9f3aee9e0989ebfc14369328ec3214
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Mar 30 10:07:10 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.3/rev/7113377f5e9f3aee9e0989ebfc14369328ec3214 [^]

fixed bug 29453: Process Definition without params popup is not closed

  When a process defintion has no parameters, it is not closed after execution/failure.

  The problem was due the invokation of allRequiredParametersSet which now is performed
  after validation, this method incorretly assumed there was a form with paramters.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
---
(0076390)
AugustoMauch   
2015-04-08 18:40   
Code reviewed and verified in [1]@eda5123f66b0

[1] https://code.openbravo.com/erp/backports/3.0PR15Q1.3/ [^] [^]