Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0029440Openbravo ERP09. Financial managementpublic2015-03-27 12:572015-03-31 00:07
jonalegriaesarte 
umartirena 
normalmajorhave not tried
closedfixed 
5
3.0PR15Q1.1 
3.0PR15Q3 
vmromanos
Core
Production - QA Approved
2015-02-16
3.0PR15Q1.1
https://code.openbravo.com/erp/devel/pi/rev/7a7b3954ec59 [^]
No
0029440: In a environment with costs not calculated the user can not get the sales invoice dimensional report
In a environment with costs not calculated the user can not get the sales invoice dimensional report. The issue comes from the following commit:
https://code.openbravo.com/erp/devel/pi/rev/7a7b3954ec59 [^]

In this commit, a cost initialization was added, to set a value in a new column. If the costing process fails the first time the initialization is done, the process reverts all the changes and the preference needed to show the report is not set. That's why the report fails.
- Environment in Q3.7 where the cost process is failing.
- Update to Q1.1.
- Costing background process still failing
- Sales invoice dimensional report is not working fine
Add a commit in the initialization process in costing background process.
No tags attached.
depends on backport 00294543.0PR15Q1.3 closed umartirena In a environment with costs not calculated the user can not get the sales invoice dimensional report 
caused by defect 00281113.0PR15Q2 closed umartirena InitializeMTransCostDateacctData modulescript has several performance issues 
Issue History
2015-03-27 12:57jonalegriaesarteNew Issue
2015-03-27 12:57jonalegriaesarteAssigned To => umartirena
2015-03-27 12:57jonalegriaesarteModules => Core
2015-03-27 12:57jonalegriaesarteTriggers an Emergency Pack => No
2015-03-27 14:34umartirenaRegression level => Production - QA Approved
2015-03-27 14:34umartirenaRegression date => 2015-02-16
2015-03-27 14:34umartirenaRegression introduced in release => 3.0PR15Q1.1
2015-03-27 14:34umartirenaRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/7a7b3954ec59 [^]
2015-03-27 16:33dmitry_mezentsevRelationship addedcaused by 0028111
2015-03-30 10:12umartirenaStatusnew => scheduled
2015-03-30 13:59jonalegriaesarteTarget Version3.0PR15Q2 => 3.0PR15Q3
2015-03-30 16:31hgbotCheckin
2015-03-30 16:31hgbotNote Added: 0076147
2015-03-30 16:31hgbotStatusscheduled => resolved
2015-03-30 16:31hgbotResolutionopen => fixed
2015-03-30 16:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1377ec1649244e79cb535cbc02ff18403727bc06 [^]
2015-03-30 16:32vmromanosReview Assigned To => vmromanos
2015-03-30 16:32vmromanosNote Added: 0076148
2015-03-30 16:32vmromanosStatusresolved => closed
2015-03-31 00:07hudsonbotCheckin
2015-03-31 00:07hudsonbotNote Added: 0076165

Notes
(0076147)
hgbot   
2015-03-30 16:31   
Repository: erp/devel/pi
Changeset: 1377ec1649244e79cb535cbc02ff18403727bc06
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Mon Mar 30 10:10:41 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1377ec1649244e79cb535cbc02ff18403727bc06 [^]

Fixes bug 29440: Initialize dateacct column is always been done.

At the beginning of costing background a process to initialize dateacct column of m_transaction_cost has being added. This process is independant from Costing Background, but it was added here to avoid the performance problems that it was causing when executing as a modulescript.

It this columns are not initialized it will not be possible to launch 'Sales Invoice Dimensional Report' and 'Valued Stock Report'. The problem happens when the Costing Background process fails for the first transaction that is calculating, because it rollbacks everything, including the process to initialize dateacct column, so, it is not possible to launch the two reports.

A OBDal.getInstance().getConnection(true).commit() has been added right after initializing dateacct to maintain this changes even when the Costing background fails on the first transaction.

---
M src/org/openbravo/costing/CostingBackground.java
---
(0076148)
vmromanos   
2015-03-30 16:32   
Code review + testing OK
(0076165)
hudsonbot   
2015-03-31 00:07   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/34da08f135b8 [^]
Maturity status: Test