Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0029431Openbravo ERP07. Sales managementpublic2015-03-26 12:272015-03-27 02:12
adrianromero 
umartirena 
immediatemajorhave not tried
closedfixed 
5
 
 
vmromanos
Core
Code review
2015-03-11
https://code.openbravo.com/erp/devel/pi/rev/35a4e54c3ffc [^]
No
0029431: It is not possible to delete an invoice line when using price including taxes
When trying to delete an invoice line when using price including taxes the following error appears:

ERROR: record "new" is not assigned yet Detail: The tuple structure of a not-yet-assigned record is indeterminate. Where: PL/pgSQL function "c_invoiceline_trg2" line 70 at assignment
* Login in https://livebuilds.openbravo.com/retail_pi_pgsql [^]
* Select Role White Valley Admin Group
* Go to invoices. Create a new invoice and a new line
* Try to delete the line
* The error described in the description appears and cannot be deleted the line

See attached image
The problem is in the following line: https://code.openbravo.com/erp/devel/pi/file/54218273885c/src-db/database/model/triggers/C_INVOICELINE_TRG2.xml#l72 [^]

When deleting this line is reached and "NEW" can only be used whe updating or inserting.
No tags attached.
related to defect 00290733.0PR15Q2 closed umartirena Review deleting logic of tax lines in C_INVOICELINE_TRG2 
png Captura de pantalla de 2015-03-26 12:19:04.png (154,318) 2015-03-26 12:27
https://issues.openbravo.com/file_download.php?file_id=7938&type=bug
png
Issue History
2015-03-26 12:27adrianromeroNew Issue
2015-03-26 12:27adrianromeroAssigned To => Sandrahuguet
2015-03-26 12:27adrianromeroFile Added: Captura de pantalla de 2015-03-26 12:19:04.png
2015-03-26 12:27adrianromeroModules => Core
2015-03-26 12:27adrianromeroTriggers an Emergency Pack => No
2015-03-26 12:30adrianromeroRegression level => Code review
2015-03-26 12:30adrianromeroRegression date => 2015-03-11
2015-03-26 12:30adrianromeroRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/35a4e54c3ffc [^]
2015-03-26 12:31adrianromeroAssigned ToSandrahuguet => umartirena
2015-03-26 17:54vmromanosStatusnew => scheduled
2015-03-26 17:55hgbotCheckin
2015-03-26 17:55hgbotNote Added: 0076025
2015-03-26 17:55hgbotStatusscheduled => resolved
2015-03-26 17:55hgbotResolutionopen => fixed
2015-03-26 17:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4cfbd5d699d2359289733749c3fef93f34d0f2e9 [^]
2015-03-26 17:56vmromanosReview Assigned To => vmromanos
2015-03-26 17:56vmromanosNote Added: 0076027
2015-03-26 17:56vmromanosStatusresolved => closed
2015-03-27 02:12hudsonbotCheckin
2015-03-27 02:12hudsonbotNote Added: 0076046
2015-03-27 10:25umartirenaRelationship addedrelated to 0029073

Notes
(0076025)
hgbot   
2015-03-26 17:55   
Repository: erp/devel/pi
Changeset: 4cfbd5d699d2359289733749c3fef93f34d0f2e9
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Thu Mar 26 16:41:55 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4cfbd5d699d2359289733749c3fef93f34d0f2e9 [^]

Fixes issue 29431: Add missing inserting to if clause

---
M src-db/database/model/triggers/C_INVOICELINE_TRG2.xml
---
(0076027)
vmromanos   
2015-03-26 17:56   
Code review + testing OK
(0076046)
hudsonbot   
2015-03-27 02:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b8858c8b542b [^]
Maturity status: Test