Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0029423Openbravo ERP04. Warehouse managementpublic2015-03-26 08:342015-04-01 08:31
umartirena 
umartirena 
highmajoralways
closedfixed 
5
 
3.0PR15Q1.2 
aferraz
No
Core
No
0029423: [Cost Adjustment] Adjustment amounts of more than 2 decimal precision are being created in costing background
While running Costing Background process with the functionality of Cost Adjustments, in certain cases adjustment are being created of amount with more than two decimal precision, and this is wrong, as an amount always has to has at most two decimal precision. Two cases detected are while using orphan lines or negative amount shipments.
In live.builds

As System Admin:
 * Change costing precision and price precision to 4 for EUR Currency.

In F&B:
 * Enable "RM Allow Orphan Line" preference.
 * Have a valid average costing rule for F&B España org.
 * Create a Product
 * Add a Costing Record:
  - Org: F&B España
  - Cost: 5.5555
  - Cost Type: Average
  - Starting Date: 01/01/2014
  - Ending Date: 31/12/9999
 * Create a Goods Shipment:
  - Org: F&B España
  - Business Partner: Alimentos y Supermercados
  - Movement Date: 10/02/2015
 * Add a Line:
  - Product: The new product
  - Qty: 10.257
  - Storage Bin: RN 0-0-0
 * Complete it
 * Go to Return from Customer window
 * Create a Header:
  - Org: F&B España
  - Business Partner: Alimentos y Supermercados
  - Order Date: 05/02/2015
 * Click on "Insert Orphan Line":
  - Product: The new product
  - Returned: 5.236
  - Unit Price: 12.33
  - Tax: Arrendamiento 21% (Cobros) - IVA Normal
 * Click OK and Book it
 * Go to Return Material Receipt:
 * Create a Header:
  - Org: F&B España
  - Business Partner: Alimentos y Supermercados
  - Movement Date: 05/02/2015
 * Click on Pick/Edit Lines:
 * Select the line created in previous Return from Customer
  - Received: 5.236
  - Storage Bin: RN 0-0-0
 * Click Done and Complete it
 * Go to Process Request window
 * Run Costing Background process

 * In pgadmin run the following query: "select * from m_costadjustmentline order by created desc"

 Realize that an adjustment line of amount -0.0045 has been created, what is wrong because it should have been of 0.00 amount.
Approved
blocks defect 00294173.0PR15Q2 closed umartirena [Cost Adjustment] Adjustment amounts of more than 2 decimal precision are being created in costing background 
Issue History
2015-03-26 10:28umartirenaTypedefect => backport
2015-03-26 10:28umartirenaTarget Version => 3.0PR15Q1.2
2015-03-26 13:32dmitry_mezentsevTag Attached: Approved
2015-03-27 14:50hgbotCheckin
2015-03-27 14:50hgbotNote Added: 0076091
2015-03-27 14:50hgbotStatusscheduled => resolved
2015-03-27 14:50hgbotResolutionopen => fixed
2015-03-27 14:50hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q1.2/rev/db2646aeed64c352b1ff068074139f0558633d30 [^]
2015-03-27 14:55aferrazReview Assigned To => aferraz
2015-03-27 14:55aferrazNote Added: 0076092
2015-03-27 14:55aferrazStatusresolved => closed
2015-04-01 08:11hgbotCheckin
2015-04-01 08:11hgbotNote Added: 0076244
2015-04-01 08:11hgbotStatusclosed => resolved
2015-04-01 08:11hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/backports/3.0PR15Q1.2/rev/db2646aeed64c352b1ff068074139f0558633d30 [^] => http://code.openbravo.com/erp/backports/3.0PR15Q2/rev/db2646aeed64c352b1ff068074139f0558633d30 [^]
2015-04-01 08:31priyamStatusresolved => closed
2015-04-01 08:31priyamNote Added: 0076247

Notes
(0076091)
hgbot   
2015-03-27 14:50   
Repository: erp/backports/3.0PR15Q1.2
Changeset: db2646aeed64c352b1ff068074139f0558633d30
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Thu Mar 26 13:11:19 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.2/rev/db2646aeed64c352b1ff068074139f0558633d30 [^]

Fixes bug 29423: Round with standard precision cost adjutment amounts

There are certain places in which the amount to be adjusted was being rounded to costing precision, instead of standard precision, and this is wrong because the amounts allways has to be at most of precision 2.

---
M src/org/openbravo/costing/AverageCostAdjustment.java
---
(0076092)
aferraz   
2015-03-27 14:55   
Code review + Testing OK
(0076244)
hgbot   
2015-04-01 08:11   
Repository: erp/backports/3.0PR15Q2
Changeset: db2646aeed64c352b1ff068074139f0558633d30
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Thu Mar 26 13:11:19 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q2/rev/db2646aeed64c352b1ff068074139f0558633d30 [^]

Fixes bug 29423: Round with standard precision cost adjutment amounts

There are certain places in which the amount to be adjusted was being rounded to costing precision, instead of standard precision, and this is wrong because the amounts allways has to be at most of precision 2.

---
M src/org/openbravo/costing/AverageCostAdjustment.java
---
(0076247)
priyam   
2015-04-01 08:31   
closed again, as the status changed due the merge tag of 3.0PR15Q1.2 to backports/3.0PR15Q2