Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029388Openbravo ERPZ. Otherspublic2015-03-24 16:192015-04-22 10:15
Reporterngarcia 
Assigned Toalostale 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR15Q2 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2014-06-19
Regression introduced in release3.0PR14Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/f94f08e02e3a [^]
Triggers an Emergency PackYes
Summary0029388: Duplicated records in Used Credit Source tab when clicking Done more than once in Add Details pop-up
DescriptionDuplicated records in Used Credit Source tab when clicking Done more than once in Add Details pop-up
Steps To ReproduceAs group admin:
   Create a Payment In to generate credit to a Customer
   Create a Sales Invoice for a bigger amount than the credit generated
   Create a Payment In, select the previously created credit and click on Done repeatedly
   Check more than one record is introduced in Used Credit Source tab
   Reactivate the Payment In and check the Used Credit field of the payment in which the credit was generated is negative
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00294163.0PR15Q1.3 closed alostale Duplicated records in Used Credit Source tab when clicking Done more than once in Add Details pop-up 
depends on defect 00294183.0PR15Q2 closed alostale API change in process definition client side validation function 
caused by design defect 0025978 closed eduardo_Argal Performance problems in APRM manual screens 
caused by feature request 0029391 closed Sandrahuguet Add Payment refactor project 
related to defect 0029426 closed alostale unneeded param in callback for client side validation of process definition 
causes defect 0029439 closed alostale Process Definition popup is not closed after executing the process behind 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-03-24 16:19ngarciaNew Issue
2015-03-24 16:19ngarciaAssigned To => umartirena
2015-03-24 16:19ngarciaModules => Core
2015-03-24 16:19ngarciaTriggers an Emergency Pack => No
2015-03-24 16:19ngarciaIssue Monitored: networkb
2015-03-24 16:38jpcalventeIssue Monitored: jpcalvente
2015-03-24 17:03umartirenaAssigned Toumartirena => ngarcia
2015-03-24 17:03umartirenaAssigned Tongarcia => platform
2015-03-24 17:23umartirenaRegression introduced in release => 3.0PR14Q3
2015-03-24 17:23umartirenaRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/f94f08e02e3a [^]
2015-03-24 17:23umartirenaTriggers an Emergency PackNo => Yes
2015-03-24 19:19alostalePriorityurgent => immediate
2015-03-25 08:28alostaleRegression level => Production - Confirmed Stable
2015-03-25 08:28alostaleRegression date => 2014-06-19
2015-03-26 08:18alostaleStatusnew => scheduled
2015-03-26 08:18alostaleAssigned Toplatform => alostale
2015-03-26 08:44alostaleRelationship addeddepends on 0029418
2015-03-26 10:33hgbotCheckin
2015-03-26 10:33hgbotNote Added: 0075992
2015-03-26 10:33hgbotStatusscheduled => resolved
2015-03-26 10:33hgbotResolutionopen => fixed
2015-03-26 10:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9216d290b2f207e748568dc7430aaf7ca41d5033 [^]
2015-03-26 10:35dmitry_mezentsevRelationship addedcaused by 0025978
2015-03-26 11:29alostaleRelationship addedrelated to 0029426
2015-03-26 11:54alostaleReview Assigned To => alostale
2015-03-26 16:26alostaleReview Assigned Toalostale => AugustoMauch
2015-03-26 16:35hudsonbotCheckin
2015-03-26 16:35hudsonbotNote Added: 0076022
2015-03-26 18:24AugustoMauchNote Added: 0076032
2015-03-26 18:24AugustoMauchStatusresolved => closed
2015-03-26 18:24AugustoMauchFixed in Version => 3.0PR15Q2
2015-03-26 18:26AugustoMauchNote Added: 0076033
2015-03-30 09:57alostaleRelationship addedcauses 0029439
2015-04-22 10:15dmitry_mezentsevRelationship addedcaused by 0029391

Notes
(0075992)
hgbot   
2015-03-26 10:33   
Repository: erp/devel/pi
Changeset: 9216d290b2f207e748568dc7430aaf7ca41d5033
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Mar 26 10:26:30 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9216d290b2f207e748568dc7430aaf7ca41d5033 [^]

fixed bug 29388, related to issue 29418: Done can be clicked more than once

  In process definition Done button was enabled and clickable while client side
  validations were being evaluated. This was specially noticeable if those validations
  perform backend requests to be completed (which is the case of Add Payment).

  Fixed by disabling Done button as first step before executing any validation.

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addTransaction.js
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-findTransaction.js
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-matchStatement.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
M web/js/validateCostingRuleProcess.js
---
(0076022)
hudsonbot   
2015-03-26 16:35   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/74bd53f51456 [^]
Maturity status: Test
(0076032)
AugustoMauch   
2015-03-26 18:24   
Code reviewed and verified in pi@9a240957107d
(0076033)
AugustoMauch   
2015-03-26 18:26   
The data was fixed in this issue [1]

[1] https://issues.openbravo.com/view.php?id=29145 [^]