Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002938Openbravo ERP09. Financial managementpublic2008-04-26 00:142008-07-08 10:45
Reportergalderromo 
Assigned Tocromero 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version2.40beta 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0002938: Copy From Settlement does not work
DescriptionIt fails during execution due to empty not null columns on insertion.

The solution, in my opinion:

CopyFromSettlement_data.xsql

28,7 → 28,7
ON THE MAIN SELECT INCLUDE:
status_initial as status,


77,8 → 77,8
NOT THIS:
INSERT INTO C_DEBT_PAYMENT ( C_DEBT_PAYMENT_ID, AD_CLIENT_ID, AD_ORG_ID,CREATEDBY, UPDATEDBY, ISRECEIPT,
C_SETTLEMENT_GENERATE_ID,DESCRIPTION, C_BPARTNER_ID, C_CURRENCY_ID, C_BANKACCOUNT_ID,C_CASHBOOK_ID,
PAYMENTRULE, AMOUNT, WRITEOFFAMT, DATEPLANNED, ISMANUAL,GLITEMAMT,C_GLITEM_ID, ISDIRECTPOSTING, ISPAID,ISVALID)
VALUES (TO_NUMBER(?),TO_NUMBER(?),TO_NUMBER(?),TO_NUMBER(?),TO_NUMBER(?),?,TO_NUMBER(?),?,TO_NUMBER(?),TO_NUMBER(?),TO_NUMBER(?),TO_NUMBER(?),?,TO_NUMBER(?),TO_NUMBER(?),TO_DATE(?),?,0,TO_NUMBER(?),?,'N','N')

BUT THIS:
INSERT INTO C_DEBT_PAYMENT ( C_DEBT_PAYMENT_ID, AD_CLIENT_ID, AD_ORG_ID,CREATEDBY, UPDATEDBY, ISRECEIPT,
C_SETTLEMENT_GENERATE_ID,DESCRIPTION, C_BPARTNER_ID, C_CURRENCY_ID, C_BANKACCOUNT_ID,C_CASHBOOK_ID,
PAYMENTRULE, AMOUNT, WRITEOFFAMT, DATEPLANNED, ISMANUAL,GLITEMAMT,C_GLITEM_ID, ISDIRECTPOSTING, ISPAID,ISVALID, STATUS, STATUS_INITIAL)
VALUES (TO_NUMBER(?),TO_NUMBER(?),TO_NUMBER(?),TO_NUMBER(?),TO_NUMBER(?),?,TO_NUMBER(?),?,TO_NUMBER(?),TO_NUMBER(?),TO_NUMBER(?),TO_NUMBER(?),?,TO_NUMBER(?),TO_NUMBER(?),TO_DATE(?),?,0,TO_NUMBER(?),?,'N','N',?,?)
]]>
</Sql>
<Parameter name="cDebtPeymentId"/>

INCLUDE TWO MORE PARAMETERS
100,6 → 100,8
<Parameter name="status"/>
<Parameter name="status"/>



CopyFromSettlement.java
122,7 → 122,9
NOT THIS:
CopyFromSettlementData.insertDebtPayment(conn,this, strDebtPayment, to[0].client, to[0].org, vars.getUser(), data[i].isreceipt, strSettlement, data[i].description, strCBPartnerId, data[i].cCurrencyId, data[i].cBankaccountId, data[i].cCashbookId, data[i].paymentrule, strImporte, data[i].writeoffamt, strDate, data[i].ismanual, data[i].cGlitemId, data[i].isdirectposting);
BUT THIS:
CopyFromSettlementData.insertDebtPayment(conn,this, strDebtPayment, to[0].client, to[0].org, vars.getUser(), data[i].isreceipt, strSettlement, data[i].description, strCBPartnerId, data[i].cCurrencyId, data[i].cBankaccountId, data[i].cCashbookId, data[i].paymentrule, strImporte, data[i].writeoffamt, strDate, data[i].ismanual, data[i].cGlitemId, data[i].isdirectposting, data[i].status);
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0003699 closed cromero Copy From Settlement does not work 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2008-07-08 10:45psarobeStatusresolved => closed
2008-07-08 10:45psarobeFixed in Version2.40alpha-r2 => 2.40beta

Notes
(0006527)
user71   
2005-06-01 00:00   
(edited on: 2008-06-12 09:43)
This bug was originally reported in SourceForge bug tracker and then migrated to Mantis.

You can see the original bug report in:
https://sourceforge.net/support/tracker.php?aid=1951949 [^]
(0003637)
cromero   
2008-04-28 10:41   
(edited on: 2008-06-12 09:26)
Logged In: YES
user_id=1500614
Originator: NO

Inserted status should be the initial status that the payment had.
(0003638)
cromero   
2008-05-06 02:20   
(edited on: 2008-06-12 09:26)
Logged In: YES
user_id=1500614
Originator: NO

Fixed in the trunk in revision 3956