Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029371Retail ModulesWeb POSpublic2015-03-23 13:102015-05-22 13:30
ReporterOrekaria 
Assigned ToOrekaria 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q2 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression levelProduction - QA Approved
Regression date
Regression introduced in releaseRR15Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/775ab7f8908fe31eb57e9eed063d52b798925fe2 [^]
Triggers an Emergency PackNo
Summary0029371: The login button is firing 2 events when mouse clicked
DescriptionThe login button is firing 2 events when mouse clicked
Steps To ReproduceOpen the WebPOS
Open the javascript generated file
Set a breakpoint in the 'loginButtonAction' method
With the mouse, click on the log in button
Verify that the method is being executed twice
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0029378RR15Q1.3 closed Orekaria The login button is firing 2 events when mouse clicked 
caused by design defect 0027602RR14Q4 closed Orekaria Tests: Would be helpful if the 'Log In' button should trigger with a regular 'click' event 
blocks feature request 0029377RR15Q3 closed Orekaria Stabilization: RR15Q2 related 
blocks defect 0029365 closed Orekaria Stabilization: Prevent concurrent logins 
causes defect 0029288 closed Orekaria Stabilization: The propertiesLoadersReady event is being fired for every property 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-03-23 13:10OrekariaNew Issue
2015-03-23 13:10OrekariaAssigned To => Orekaria
2015-03-23 13:10OrekariaTriggers an Emergency Pack => No
2015-03-23 13:11OrekariaRegression level => Production - QA Approved
2015-03-23 13:11OrekariaRegression introduced in release => RR15Q1
2015-03-23 15:05OrekariaRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/775ab7f8908fe31eb57e9eed063d52b798925fe2 [^]
2015-03-23 15:05OrekariaStatusnew => scheduled
2015-03-23 15:06OrekariaRelationship addedblocks 0029377
2015-03-23 17:42OrekariaRelationship addedblocks 0029365
2015-03-23 17:55OrekariaSummaryThe login button is firing 2 events when tapped => The login button is firing 2 events when mouse clicked
2015-03-23 17:55OrekariaDescription Updatedbug_revision_view_page.php?rev_id=8081#r8081
2015-03-23 17:55OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=8083#r8083
2015-03-23 18:50dmitry_mezentsevRelationship addedcaused by 0027602
2015-03-23 21:24hgbotCheckin
2015-03-23 21:24hgbotNote Added: 0075903
2015-03-23 21:24hgbotStatusscheduled => resolved
2015-03-23 21:24hgbotResolutionopen => fixed
2015-03-23 21:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4675a1c23050412b50d5774a5d2abaee896ef199 [^]
2015-03-24 20:35OrekariaRelationship addedcauses 0029288
2015-03-27 11:54OrekariaNote Added: 0076072
2015-03-27 11:55OrekariaNote Edited: 0076072bug_revision_view_page.php?bugnote_id=0076072#r8125
2015-03-27 12:35migueldejuanaReview Assigned To => migueldejuana
2015-03-27 12:35migueldejuanaNote Added: 0076077
2015-03-27 12:35migueldejuanaStatusresolved => closed
2015-03-27 12:35migueldejuanaFixed in Version => RR15Q2
2015-04-10 15:03hgbotCheckin
2015-04-10 15:03hgbotNote Added: 0076450
2015-04-10 15:03hgbotStatusclosed => resolved
2015-04-10 15:03hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4675a1c23050412b50d5774a5d2abaee896ef199 [^] => http://code.openbravo.com/retail/backports/3.0RR15Q1.3/org.openbravo.mobile.core/rev/18f01bb7cc1eefbbbbf372942d6e850bac8c097e [^]
2015-04-13 13:09marvintmStatusresolved => closed
2015-05-22 13:30hgbotCheckin
2015-05-22 13:30hgbotNote Added: 0077659

Notes
(0075903)
hgbot   
2015-03-23 21:24   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 4675a1c23050412b50d5774a5d2abaee896ef199
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Mon Mar 23 21:24:20 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4675a1c23050412b50d5774a5d2abaee896ef199 [^]

Fixes issue 29371: The 'log in' button fires 1 event instead of 2

---
M web/org.openbravo.mobile.core/source/component/ob-login.js
---
(0076072)
Orekaria   
2015-03-27 11:54   
(edited on: 2015-03-27 11:55)
The tap event is substituted by the click event to allow foreign javascript context to activate the button
This fix was introduced to allow the chrome extension to interact with the application
The fix is verified to work with Android, IOS and PC

There could be another solution that is: fired both events when the button is clicked, but deactivate the click if the tap event is detected
(0076077)
migueldejuana   
2015-03-27 12:35   
Tested and reviewed in 9a4b58581d34
(0076450)
hgbot   
2015-04-10 15:03   
Repository: retail/backports/3.0RR15Q1.3/org.openbravo.mobile.core
Changeset: 18f01bb7cc1eefbbbbf372942d6e850bac8c097e
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Mon Mar 23 21:24:20 2015 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR15Q1.3/org.openbravo.mobile.core/rev/18f01bb7cc1eefbbbbf372942d6e850bac8c097e [^]

Fixes issue 29371: The 'log in' button fires 1 event instead of 2

---
M web/org.openbravo.mobile.core/source/component/ob-login.js
---
(0077659)
hgbot   
2015-05-22 13:30   
Repository: tools/automation/pi-mobile
Changeset: 9f391c57ae66c49ade5c80c6abb7a4fafbd056b5
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Thu May 21 17:42:14 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/9f391c57ae66c49ade5c80c6abb7a4fafbd056b5 [^]

Related to issue 29371: The 'login' button is fired with a 'click' instead of a 'tap'

---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/EnyoNode.java
---