Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029353Openbravo ERP01. General setuppublic2015-03-20 12:482015-05-07 22:17
Reportervmromanos 
Assigned Tovmromanos 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionDebian 5.0
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Toeduardo_Argal
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029353: Initial Client Setup: Apply dataset process only takes into account direct dependencies
DescriptionWhen you apply several datasets at the same time, the systems tries to apply them in order based on the definition of the module dependencies.

This process seems to work fine when the dependencies are directly declared in the modules, however the indirect dependencies are not taken into account in Initial Client Setup

Example: SEPA direct debit depends on SEPA Framework, that depends on Remittance Infrastructure, that depends on APRM module, that finally depends on Core. Here you have a simplified graph:

SEPA direct debit --> SEPA Framework --> Remittance Infrastructure --> APRM --> Core.


If you run an Initial Client setup and you select the Core, Remittance Infrastructure and SEPA direct debit datasets, the process fails because they are not applied in the right order.

If you manually change the dependencies to have a "direct dependency" as follows, the datasets are properly applied:
SEPA direct debit --> Remittance Infrastructure
Remittance Infrastructure --> Core


Enterprise Module Management doesn't seem to be affected by this issue.
Steps To ReproduceInstall SEPA direct debit module (+dependencies)
Run Initial Client setup and select the Core, Remittance Infrastructure and SEPA direct debit datasets.
Proposed SolutionIndirect dependencies should be taken into when deciding the order used for applying the datasets
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0028351 closed reinaldoguerra Modules The initial client setup process does not work selecting the SEPA Direct Debit Customer-to-Bank dataset 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-03-20 12:48vmromanosNew Issue
2015-03-20 12:48vmromanosAssigned To => Sandrahuguet
2015-03-20 12:48vmromanosModules => Core
2015-03-20 12:48vmromanosTriggers an Emergency Pack => No
2015-03-20 12:49vmromanosRelationship addedcauses 0028351
2015-03-20 12:51vmromanosRelationship replacedhas duplicate 0028351
2015-03-20 14:09vmromanosSummaryApply dataset process only takes into account direct dependencies => Initial Client Setup: Apply dataset process only takes into account direct dependencies
2015-03-20 14:09vmromanosDescription Updatedbug_revision_view_page.php?rev_id=8053#r8053
2015-03-23 13:37vmromanosStatusnew => scheduled
2015-03-23 13:37vmromanosAssigned ToSandrahuguet => vmromanos
2015-03-23 16:02vmromanosNote Added: 0075881
2015-04-30 21:34hgbotCheckin
2015-04-30 21:34hgbotNote Added: 0076921
2015-04-30 21:34hgbotStatusscheduled => resolved
2015-04-30 21:34hgbotResolutionopen => fixed
2015-04-30 21:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ffae20f94461f6555892e3cdf8ef72985064c1e6 [^]
2015-04-30 21:34hgbotCheckin
2015-04-30 21:34hgbotNote Added: 0076922
2015-04-30 21:38eduardo_ArgalReview Assigned To => eduardo_Argal
2015-04-30 21:38eduardo_ArgalNote Added: 0076923
2015-04-30 21:38eduardo_ArgalStatusresolved => closed
2015-05-07 22:17hudsonbotCheckin
2015-05-07 22:17hudsonbotNote Added: 0077192
2015-05-07 22:17hudsonbotCheckin
2015-05-07 22:17hudsonbotNote Added: 0077193

Notes
(0075881)
vmromanos   
2015-03-23 16:02   
Test plan I:
Install SEPA direct debit module (+dependencies)
Run Initial Client setup and select the Core, Remittance Infrastructure and SEPA direct debit datasets.
Verify datasets are properly applied

Test plan II:
Run Initial Client setup and select no modules
Verify Client is properly created

Test plan III:
Run Initial Client setup and select core module
Verify Client is properly created
(0076921)
hgbot   
2015-04-30 21:34   
Repository: erp/devel/pi
Changeset: ffae20f94461f6555892e3cdf8ef72985064c1e6
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Mar 23 16:09:38 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ffae20f94461f6555892e3cdf8ef72985064c1e6 [^]

Fixed bug 29353: ICS implemented indirect dataset dependencies

When getting the module dependencies we take into account all the modules installed in the instance instead of only the one selected by the user.
We use the UpdateReferenceDataData.selectModules() method, which is used by the Enterprise Module Management process too, to get the right order.
The UpdateReferenceDataData class is now public to be called from InitialClientSetup.java.
Added missed ProcessingDataset message

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/erpCommon/ad_forms/UpdateReferenceData_data.xsql
M src/org/openbravo/erpCommon/businessUtility/InitialClientSetup.java
---
(0076922)
hgbot   
2015-04-30 21:34   
Repository: erp/devel/pi
Changeset: 0bc90e3c757f13d84f07b5c60a638cc4ade2217c
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Thu Apr 30 19:24:38 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0bc90e3c757f13d84f07b5c60a638cc4ade2217c [^]

Related to issue 29353: Refactor of class in FIN_Utility so it can be used in core. This is now used in Initial Client Setup

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ExecutePayments.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
M src/org/openbravo/erpCommon/businessUtility/InitialClientSetup.java
M src/org/openbravo/erpCommon/utility/Utility.java
---
(0076923)
eduardo_Argal   
2015-04-30 21:38   
Code Reviewed and tested.

Test plan I:
Install SEPA direct debit module (+dependencies)
Run Initial Client setup and select the Core, Remittance Infrastructure and SEPA direct debit datasets.
Verify datasets are properly applied

Test plan II:
Run Initial Client setup and select no modules
Verify Client is properly created

Test plan III:
Run Initial Client setup and select core module
Verify Client is properly created

Test plan IV:
Install SEPA direct debit module (+dependencies)
Install other modules containing as well datasets
Run Initial Client setup and select all datasets.
Verify datasets are properly applied
(0077192)
hudsonbot   
2015-05-07 22:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test
(0077193)
hudsonbot   
2015-05-07 22:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test