Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029313Openbravo ERPA. Platformpublic2015-03-17 12:552016-06-17 19:37
Reporterjonalegriaesarte 
Assigned Toalostale 
PriorityimmediateSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q2Fixed in Version3.0PR15Q2 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2013-07-11
Regression introduced in release3.0MP26
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/bed326b6ddf6f08b10cf22cd7403aff84c0e3750 [^]
Triggers an Emergency PackNo
Summary0029313: Download attachments selecting several records is not working fine
DescriptionDownload attachments selecting several records is not working fine. This functionality was working fine in old releases (tested in MP20)
Steps To Reproduce- Sales invoice window, select one invoice, add an attachement
- Select a different invoice and add a new attachement
- In grid mode, select both invoices and download the attachments, using the attachment button.
- The zip file downloaded can not be opened. It is corrupted.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0028842 closed NaroaIriarte When you attach a file, the created record in table c_file has context organization instead of document organization 
depends on backport 00293243.0PR15Q1.2 closed alostale Download attachments seleting several records is not working fine 
depends on backport 00293253.0PR14Q3.8 closed alostale Download attachments seleting several records is not working fine 
caused by design defect 00206233.0MP25 closed shankarb 32K limit for attachments 
has duplicate defect 0031306 closed platform Downloading attachments from different rows at the same time does not work 
related to defect 0029329 closed alostale can't download attachments for 2 files with same name and without extension 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-03-17 12:55jonalegriaesarteNew Issue
2015-03-17 12:55jonalegriaesarteAssigned To => AugustoMauch
2015-03-17 12:55jonalegriaesarteModules => Core
2015-03-17 12:55jonalegriaesarteResolution time => 1427065200
2015-03-17 12:55jonalegriaesarteTriggers an Emergency Pack => No
2015-03-17 14:37alostaleAssigned ToAugustoMauch => platform
2015-03-18 08:16alostaleAssigned Toplatform => alostale
2015-03-18 08:16alostaleStatusnew => acknowledged
2015-03-18 08:25alostaleNote Added: 0075714
2015-03-18 08:53alostaleRelationship addedcaused by 0020623
2015-03-18 08:55alostaleReview Assigned To => AugustoMauch
2015-03-18 08:55alostaleRegression level => Production - Confirmed Stable
2015-03-18 08:55alostaleRegression date => 2013-07-11
2015-03-18 08:55alostaleRegression introduced in release => 3.0MP26
2015-03-18 08:55alostaleRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/bed326b6ddf6f08b10cf22cd7403aff84c0e3750 [^]
2015-03-18 08:55alostaleStatusacknowledged => scheduled
2015-03-18 09:01alostaleRelationship addedrelated to 0028842
2015-03-18 09:07alostaleSummaryDownload attachments seleting several records is not working fine => Download attachments selecting several records is not working fine
2015-03-18 09:07alostaleDescription Updatedbug_revision_view_page.php?rev_id=8012#r8012
2015-03-18 09:27hgbotCheckin
2015-03-18 09:27hgbotNote Added: 0075717
2015-03-18 09:27hgbotStatusscheduled => resolved
2015-03-18 09:27hgbotResolutionopen => fixed
2015-03-18 09:27hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7b67971d79d29f3521e21c45778fa93a6bea0fbd [^]
2015-03-18 09:27hgbotCheckin
2015-03-18 09:27hgbotNote Added: 0075718
2015-03-18 10:17alostaleNote Added: 0075723
2015-03-18 10:45alostaleRelationship addedrelated to 0029329
2015-03-18 15:38hudsonbotCheckin
2015-03-18 15:38hudsonbotNote Added: 0075741
2015-03-18 15:38hudsonbotCheckin
2015-03-18 15:38hudsonbotNote Added: 0075742
2015-03-20 12:12AugustoMauchNote Added: 0075787
2015-03-20 12:12AugustoMauchStatusresolved => closed
2015-03-20 12:12AugustoMauchFixed in Version => 3.0PR15Q2
2015-10-30 07:33alostaleRelationship addedrelated to 0031306
2015-10-30 07:42alostaleRelationship replacedhas duplicate 0031306
2016-04-18 13:02hgbotCheckin
2016-04-18 13:02hgbotNote Added: 0085700
2016-04-18 13:02hgbotStatusclosed => resolved
2016-04-18 13:02hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/7b67971d79d29f3521e21c45778fa93a6bea0fbd [^] => http://code.openbravo.com/erp/devel/pi/rev/44f2ec446db1484d32f31e140e1b862ea5a428ef [^]
2016-04-18 13:03hgbotCheckin
2016-04-18 13:03hgbotNote Added: 0085701
2016-04-19 09:51gorkaionNote Added: 0085733
2016-04-19 09:51gorkaionStatusresolved => closed
2016-06-17 19:36hudsonbotCheckin
2016-06-17 19:36hudsonbotNote Added: 0087459
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087460

Notes
(0075714)
alostale   
2015-03-18 08:25   
This error appears in log:

867f0e26 250522 [http-8080-3] ERROR org.openbravo.erpCommon.businessUtility.TabAttachments - Error while downloading attachments
java.io.FileNotFoundException: /opt/openbravo/attachments/318-5057F53393774AC3A952F9143426A922,A5ABE40B99F94D94A5FAAC741E659EA5/a (No such file or directory)
    at java.io.FileInputStream.open(Native Method)
    at java.io.FileInputStream.<init>(FileInputStream.java:146)
    at java.io.FileInputStream.<init>(FileInputStream.java:101)
    at org.openbravo.erpCommon.businessUtility.TabAttachments.printPageFileMultiple(TabAttachments.java:313)
(0075717)
hgbot   
2015-03-18 09:27   
Repository: erp/devel/pi
Changeset: 7b67971d79d29f3521e21c45778fa93a6bea0fbd
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Mar 18 09:08:59 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7b67971d79d29f3521e21c45778fa93a6bea0fbd [^]

fixed bug 29313: attachment download of different records at once fails

  It generated an invalid zip file.

  The problem was it tried to find the attachment directory based on the whole
  list of ids to download instead of splitting it.

---
M src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
---
(0075718)
hgbot   
2015-03-18 09:27   
Repository: erp/devel/pi
Changeset: bb2fdcffc42931b4ea760eef97756dfc6e084a56
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Mar 18 09:10:10 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/bb2fdcffc42931b4ea760eef97756dfc6e084a56 [^]

related to bug 29313: code cleanup

  removed unneeded code

---
M src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
---
(0075723)
alostale   
2015-03-18 10:17   
Added test cases in testlink https://testlink.openbravo.com/testlink [^]

Within Platform > Attachments
(0075741)
hudsonbot   
2015-03-18 15:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/327af339611e [^]
Maturity status: Test
(0075742)
hudsonbot   
2015-03-18 15:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/327af339611e [^]
Maturity status: Test
(0075787)
AugustoMauch   
2015-03-20 12:12   
Code reviewed and verified in pi@bb2fdcffc429
(0085700)
hgbot   
2016-04-18 13:02   
Repository: erp/devel/pi
Changeset: 44f2ec446db1484d32f31e140e1b862ea5a428ef
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Mar 18 09:08:59 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/44f2ec446db1484d32f31e140e1b862ea5a428ef [^]

fixed bug 29313: attachment download of different records at once fails

  It generated an invalid zip file.

  The problem was it tried to find the attachment directory based on the whole
  list of ids to download instead of splitting it.

---
M src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
---
(0085701)
hgbot   
2016-04-18 13:03   
Repository: erp/devel/pi
Changeset: 1bcb50bd93e22cb409350719c6f91687aa08efad
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Mar 18 09:10:10 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1bcb50bd93e22cb409350719c6f91687aa08efad [^]

related to bug 29313: code cleanup

  removed unneeded code

---
M src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
---
(0085733)
gorkaion   
2016-04-19 09:51   
issue reopened by attachment enhancement project merge. checked that it is not reproduced.
(0087459)
hudsonbot   
2016-06-17 19:36   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087460)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test