Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029277Retail ModulesWeb POSpublic2015-03-13 19:412015-03-18 12:17
ReporterOrekaria 
Assigned ToOrekaria 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029277: Stabilization: Prevent LogClient logging itself in an infinite loop
DescriptionStabilization: Prevent LogClient logging itself in an infinite loop
Steps To ReproduceIn 'LogClientLoader.java', 'saveLogClient' method, add an throw exception just before the DAL flush
Verify that the error is being returned to the client, and that the client is returning again the error to the server, ad infinitum

This flush error happens when the logclient tries to save a log line with an existing logclient id
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0029102RR15Q3 closed Orekaria Stabilization: RR15Q2 log related additions 
related to defect 0028964 closed malsasua It is possible that we are losing log traces in client side 
depends on feature request 0029279 closed Orekaria Add a method to report user logged status 
related to defect 0029336 closed Orekaria When the LogClientLoader raises a duplicated id error, the error is sent back to the client 
blocks defect 0029332 new Retail Performance: LogClient should not persist until the business layer has persisted 
blocks defect 0029363 closed Orekaria Stabilization: LogClient should not flush to the server if the application is busy 
blocks feature request 0029377RR15Q3 closed Orekaria Stabilization: RR15Q2 related 
blocks defect 0028504RR15Q3 closed marvintm Log Client has a really bad performance and it is really difficult to work 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-03-13 19:41OrekariaNew Issue
2015-03-13 19:41OrekariaAssigned To => Orekaria
2015-03-13 19:41OrekariaTriggers an Emergency Pack => No
2015-03-13 22:43OrekariaRelationship addedrelated to 0029102
2015-03-13 22:59hgbotCheckin
2015-03-13 22:59hgbotNote Added: 0075584
2015-03-13 22:59hgbotStatusnew => resolved
2015-03-13 22:59hgbotResolutionopen => fixed
2015-03-13 22:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/eb6ba4057dbdc2b58a0adb511e1493ee9874477f [^]
2015-03-14 00:03hgbotCheckin
2015-03-14 00:03hgbotNote Added: 0075588
2015-03-14 00:03hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/eb6ba4057dbdc2b58a0adb511e1493ee9874477f [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3c2c77418b5dac4fd18865b19af9acc06641172c [^]
2015-03-14 03:49hgbotCheckin
2015-03-14 03:49hgbotNote Added: 0075591
2015-03-15 21:06OrekariaRelationship addedrelated to 0028964
2015-03-15 21:12hgbotCheckin
2015-03-15 21:12hgbotNote Added: 0075600
2015-03-16 09:59OrekariaRelationship addeddepends on 0029279
2015-03-16 18:29OrekariaSummaryStabilization: Circular LogClient logging => Stabilization: Prevent LogClient logging itself in an infinite loop
2015-03-16 18:29OrekariaDescription Updatedbug_revision_view_page.php?rev_id=7996#r7996
2015-03-17 12:52marvintmReview Assigned To => marvintm
2015-03-17 12:52marvintmStatusresolved => closed
2015-03-17 12:52marvintmFixed in Version => RR15Q2
2015-03-18 12:17OrekariaRelationship addedrelated to 0029332
2015-03-18 12:43OrekariaRelationship addedrelated to 0029336
2015-03-18 13:31OrekariaRelationship replacedblocks 0029332
2015-03-20 17:27OrekariaRelationship addedblocks 0029363
2015-03-23 14:54OrekariaRelationship addedblocks 0029377
2015-03-31 09:58OrekariaRelationship addedblocks 0028504
2015-08-28 14:04OrekariaRelationship addedblocks 0030695

Notes
(0075584)
hgbot   
2015-03-13 22:59   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: eb6ba4057dbdc2b58a0adb511e1493ee9874477f
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Fri Mar 13 20:19:29 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/eb6ba4057dbdc2b58a0adb511e1493ee9874477f [^]

Fixes issue 29277: LogClient does not save its own messages

The log logic must not log its own logic because it causes infinite message loop

---
M src/org/openbravo/mobile/core/utils/LogClientLoader.java
M web/org.openbravo.mobile.core/source/utils/logClientSyncUtils.js
---
(0075588)
hgbot   
2015-03-14 00:03   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 3c2c77418b5dac4fd18865b19af9acc06641172c
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Mar 14 00:02:45 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3c2c77418b5dac4fd18865b19af9acc06641172c [^]

Fixes issue 29277: LogClient does not save its own messages (II)

- fixed incorrect escape char
- added missing return

---
M web/org.openbravo.mobile.core/source/utils/logClientSyncUtils.js
---
(0075591)
hgbot   
2015-03-14 03:49   
Repository: tools/automation/pi-mobile
Changeset: a0c86a5539f27387df45f22d6809d9f78537c3e4
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Fri Mar 13 23:13:22 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a0c86a5539f27387df45f22d6809d9f78537c3e4 [^]

Related to issue 28933, verifies issue 29277: Added 'I29277_LogClientCircular' test (II)

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I29277_LogClientCircular.java
---
(0075600)
hgbot   
2015-03-15 21:12   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: e7d2c648bfdcfb911e458b5519eeaaec9041f9e1
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sun Mar 15 21:11:02 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e7d2c648bfdcfb911e458b5519eeaaec9041f9e1 [^]

Partially backed out issue 29277: Removed the 'ConstraintViolationException' catcher when flushing

---
M src/org/openbravo/mobile/core/utils/LogClientLoader.java
---