Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029265Openbravo ERPI. Performancepublic2015-03-06 13:372015-03-20 19:23
Reporterlorenzofidalgo 
Assigned Toumartirena 
PrioritynormalSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0PR14Q3.8Fixed in Version3.0PR14Q3.8 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerNo
Web browserGoogle Chrome, Mozilla Firefox
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029265: Clicking select all and after that unselect all records in AddPayment window induces browser to get stuck
DescriptionIf there is enough lines (I have tested this with 60 and 90 records and it has been successfully reproduced), clicking "select all" records and after that clicking same button (which is "unselect all" at that moment) induces browser to get stuck. [See screenshots].

I have tested this localhost and livebuilds in pi pgsql context.

Steps To Reproduce[It is adviced to create as many puchase invoice records as possible with at least one product line each one and complete them to test this].

Login ERP using QAAdmin role.
Go to "Financial Account" window.
Select "Spain Cashbook" role.
Go to "Transaction" tab.
Create a new record.
Transaction Type: "BP Withdrawal".
Click "+" in Payment field to add a payment.
In "Add Payment" window:
--
Clear filters.
Click "select all" checkbox and next to that, click it again to "unselect all".
It will probably broke. If it does not, repeat "select all" + "unselect all" several times.
Proposed Solution
Additional Information
TagsApproved
Relationships
blocks defect 0029172 closed umartirena Clicking select all and after that unselect all records in AddPayment window induces browser to get stuck 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-03-12 17:10SandrahuguetTypedefect => backport
2015-03-12 17:10SandrahuguetTarget Version => 3.0PR14Q3.8
2015-03-13 13:02hgbotCheckin
2015-03-13 13:02hgbotNote Added: 0075550
2015-03-13 13:02hgbotStatusscheduled => resolved
2015-03-13 13:02hgbotResolutionopen => fixed
2015-03-13 13:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR14Q3.8/rev/a7cded5c96cff9af029ddfaf5f9a965980f639ce [^]
2015-03-13 14:00SandrahuguetReview Assigned To => Sandrahuguet
2015-03-13 14:00SandrahuguetNote Added: 0075564
2015-03-13 14:00SandrahuguetStatusresolved => closed
2015-03-13 14:00SandrahuguetFixed in Version => 3.0PR14Q3.8
2015-03-13 17:35dmitry_mezentsevTag Attached: Approved
2015-03-17 19:31umartirenaNote Added: 0075705
2015-03-17 19:31umartirenaStatusclosed => new
2015-03-17 19:31umartirenaResolutionfixed => open
2015-03-17 19:31umartirenaFixed in Version3.0PR14Q3.8 =>
2015-03-17 19:33umartirenaNote Edited: 0075705bug_revision_view_page.php?bugnote_id=0075705#r8010
2015-03-18 09:54hgbotCheckin
2015-03-18 09:54hgbotNote Added: 0075722
2015-03-18 17:11hgbotCheckin
2015-03-18 17:11hgbotNote Added: 0075745
2015-03-18 17:19umartirenaNote Deleted: 0075722
2015-03-18 18:12umartirenaStatusnew => scheduled
2015-03-18 18:12umartirenaStatusscheduled => resolved
2015-03-18 18:12umartirenaFixed in Version => 3.0PR14Q3.8
2015-03-18 18:12umartirenaResolutionopen => fixed
2015-03-18 18:49SandrahuguetNote Added: 0075753
2015-03-18 18:49SandrahuguetStatusresolved => closed
2015-03-20 19:23hudsonbotCheckin
2015-03-20 19:23hudsonbotNote Added: 0075829

Notes
(0075550)
hgbot   
2015-03-13 13:02   
Repository: erp/backports/3.0PR14Q3.8
Changeset: a7cded5c96cff9af029ddfaf5f9a965980f639ce
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Fri Mar 13 13:00:24 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR14Q3.8/rev/a7cded5c96cff9af029ddfaf5f9a965980f639ce [^]

Fixes bug 29265 Improved performance select/deselect all records in OrderInv grid

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0075564)
Sandrahuguet   
2015-03-13 14:00   
Code review + testing OK
(0075705)
umartirena   
2015-03-17 19:31   
(edited on: 2015-03-17 19:33)
Reopened because it does not update differences after reload of Order Invoices grid
(0075745)
hgbot   
2015-03-18 17:11   
Repository: erp/backports/3.0PR14Q3.8
Changeset: 18bb658d54a0e4dd538750b5e0833939b7a0e143
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Mar 18 17:09:46 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR14Q3.8/rev/18bb658d54a0e4dd538750b5e0833939b7a0e143 [^]

Related to bug 29265: Delete obaprmAllRecordsSelectedByUser in OrderInvoice Load

While executing invalidateCache() function to reload OrderInvoice grid it internally calls to 'OB.APRM.AddPayment.deselectAllRecords' overriden method that sets obaprmAllRecordsSelectedByUser property to true. This property is only needed when manually the select/unselect all checkbox is clicked.

This was causing on certain scenarios that methods to update totals were not being called:
* OB.APRM.AddPayment.updateInvOrderTotal(view.theForm, orderInvoice);
* OB.APRM.AddPayment.updateActualExpected(view.theForm);
* OB.APRM.AddPayment.updateDifference(view.theForm);

So, in order to avoid this in OrderInvoiceOnLoad function, if the property 'obaprmAllRecordsSelectedByUser' exists, it will be deleted.

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0075753)
Sandrahuguet   
2015-03-18 18:49   
Code review + testing OK
(0075829)
hudsonbot   
2015-03-20 19:23   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a670497786d1 [^]
Maturity status: Test